Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PPMA/RA demo code #2

Merged
merged 10 commits into from Dec 4, 2019

Conversation

@frusciante8989
Copy link

frusciante8989 commented Nov 11, 2019

Added code specific to PPMA & RA tradeshow, for Automata blog post. Files added are:

  • evaUtilities.py
  • main.py
    AA
Copy link
Member

LouisBrunner left a comment

They are some (minor) issues, the code could also use a README.md to explain how to configure it and set it up?

examples/machine_vision_object_pickup/main.py Outdated Show resolved Hide resolved
examples/machine_vision_object_pickup/main.py Outdated Show resolved Hide resolved
examples/machine_vision_object_pickup/evaUtilities.py Outdated Show resolved Hide resolved
Copy link
Member

LouisBrunner left a comment

Only the configuration thing and it's good to go

examples/machine_vision_object_pickup/main.py Outdated Show resolved Hide resolved
@frusciante8989

This comment has been minimized.

Copy link
Author

frusciante8989 commented Dec 3, 2019

Modified minor typos and added a config folder, with the required parameters initialised to 0 (commit 6e1fa39)

@frusciante8989 frusciante8989 requested a review from LouisBrunner Dec 3, 2019
Copy link
Member

Charlesworth left a comment

Can you add a REAME.md just quickly explaining what this example does, like:

Also please make a new link in the included examples top level readme. Please get rid of the comments on the top of each file, we already have a license and your pull request will attribute you as the author.

@Charlesworth

This comment has been minimized.

Copy link
Member

Charlesworth commented Dec 4, 2019

Please can you also put in the example README which version of eva this works with, I'm guessing 2.1.2?

@frusciante8989 frusciante8989 requested a review from Charlesworth Dec 4, 2019
Copy link
Member

Charlesworth left a comment

Great stuff, thanks for adding this. Defo the most useful example yet a it does something useful

@frusciante8989

This comment has been minimized.

Copy link
Author

frusciante8989 commented Dec 4, 2019

Great stuff, thanks for adding this. Defo the most useful example yet a it does something useful

haha cool! thanks :)

@Charlesworth Charlesworth merged commit af0b02f into automata-tech:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.