Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more card features #1

Merged
merged 1 commit into from Mar 5, 2020
Merged

Add more card features #1

merged 1 commit into from Mar 5, 2020

Conversation

@LouisBrunner
Copy link
Member

LouisBrunner commented Mar 3, 2020

This PR adds the following:

  • Stronger checks on reading card data
  • Enum for card subkeys
  • Functions to edit card metadata
  • Functions to check and set the PINs
  • Function to factory reset the card (might be Yubikey specific?)
  • Function to unblock the User PIN
  • Function to generate a key on the card
Copy link
Member

Charlesworth left a comment

only stylistic, merge when ready

agent/card_set.go Show resolved Hide resolved
agent/card_set.go Show resolved Hide resolved
agent/card_set.go Outdated Show resolved Hide resolved
@LouisBrunner LouisBrunner force-pushed the feature/more_cards_func branch from 6681fb4 to d765dba Mar 5, 2020
@LouisBrunner LouisBrunner requested a review from Charlesworth Mar 5, 2020
@LouisBrunner LouisBrunner merged commit 3b5c612 into master Mar 5, 2020
@LouisBrunner LouisBrunner deleted the feature/more_cards_func branch Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.