Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperalignment #156

Closed
tiborauer opened this issue Jul 27, 2018 · 6 comments
Closed

Hyperalignment #156

tiborauer opened this issue Jul 27, 2018 · 6 comments
Assignees
Labels

Comments

@tiborauer
Copy link
Member

Does anybody know what it is? I can see it in the parameter set, but no module is using it.

@jooh
Copy link
Collaborator

jooh commented Jul 30, 2018

Looks like remnants of legacy stuff to me.

aa_engine/aas_getdirectory_bydomain.m:    case 'hyperalignment_searchlight_package'
aa_engine/aas_getdirectory_bydomain.m:        directory=sprintf(['hyperalignment_searchlight_packages' filesep '%d'],index);
aa_engine/aas_getdirectory_bydomain.m:    case {'subject','hyperalignment_subject','isc_subject'} 
aa_engine/aas_getNames_bydomain.m:        case 'hyperalignment_searchlight_package'
aa_engine/aas_getNames_bydomain.m:        case 'hyperalignment_subject' 
aa_engine/aas_getN_bydomain.m:    case {'searchlight_package','hyperalignment_searchlight_package'}
aa_engine/aas_getN_bydomain.m:    case {'subject','hyperalignment_subject','isc_subject'}
aa_testcode/aatest_dependencies.m:% Source is hyperalignment_searchlight_package, target is subject[ 3 ]: hyperalignment_searchlight_package[ 1 ] hyperalignment_subject[ 1 1 ] hyperalignment_subject[ 1 2 ] hyperalignment_subject[ 1 3 ] hyperalignment_subject[ 1 4 ] hyperalignment_searchlight_package[ 2 ] hyperalignment_subject[ 2 1 ] hyperalignment_subject[ 2 2 ] hyperalignment_subject[ 2 3 ] hyperalignment_subject[ 2 4 ]  
aa_testcode/aatest_dependencies.m:% Source is hyperalignment_searchlight_package, target is subject[ 3 ]: hyperalignment_searchlight_package[ 1 ] hyperalignment_searchlight_package[ 2 ] 
aa_testcode/aatest_dependencies.m:    [deps commonind desc]=aas_getdependencies_bydomain(aap,'hyperalignment_searchlight_package','subject',[3],wtr_list{wtrind},1);
aa_testcode/aatest_dependencies.m:    fprintf('Source is hyperalignment_searchlight_package, target is subject[ 3 ]: %s\n',desc);

@tiborauer
Copy link
Member Author

We should then remove it from the settings and the code.

@jooh
Copy link
Collaborator

jooh commented Jul 31, 2018

Happy to take care of that if @rhodricusack has no objections?

@tiborauer
Copy link
Member Author

I think you can go ahead.

@jpeelle
Copy link
Member

jpeelle commented Aug 18, 2018

Closing this based on our discussions - @jooh will remove in a future PR (if not already, sorry I may have missed it).

@jpeelle jpeelle closed this as completed Aug 18, 2018
@tiborauer
Copy link
Member Author

No, It is not covered by #161 (or #163).

@tiborauer tiborauer reopened this Aug 18, 2018
@automaticanalysis automaticanalysis locked and limited conversation to collaborators Feb 12, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
Projects
None yet
Development

No branches or pull requests

4 participants