Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
meminfo bug: AA no longer supports non-bash shells #191
I have been getting a few user complaints like the below:
This happens because ulimit is sh-family, not csh, so it's not available on our standard CBU shells. The meminfo function appears to have been refactored under the assumption that this function is always available.
A possible workaround for now is to set aap.directory_conventions.linuxshell = 'bash'. But reading the code I can see that there are ulimit calls that use
At a higher level, the complexity we introduce by supporting different options for linuxshell, fslshell, freesurfershell AND also using the odd direct
Or so I thought. In fact, linuxshell appears to be a dead parameter. As far as I can tell it is never used anywhere. aas_shell does some very weird stuff with the cache to work out what shell to use. Does anyone understand how this code works? Shouldn't it be using linuxshell instead?
I agree that the current approach is convoluted..
I like the idea of using the user's $SHELL. I think that is what aas_shell tries to do. It search for the shell for the first time, then put it into the cache, so it does not have to search next time.
I am not sure, however, whether system depends on user's $SHELL or not.