Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggestion: consider renaming few things for readibility #104

Closed
alaypatel07 opened this issue Jun 14, 2018 · 1 comment
Closed

suggestion: consider renaming few things for readibility #104

alaypatel07 opened this issue Jun 14, 2018 · 1 comment
Assignees
@jmrodri

Comments

@alaypatel07
Copy link
Contributor

The function ConvertBuncleToSpec takes input parameter spec, which should be renamed to bundleSpec.

This file conversions.go has functions that says "convert_ToAPB" that should be renamed to "convert_ToSpec_"
@jmrodri jmrodri self-assigned this Jul 3, 2018
@jmrodri
Copy link
Contributor

jmrodri commented Jul 3, 2018

I do not think we should rename the input parameter. The type is of bundle.Spec that should identify what it is, bundleSpec is just superfluous.

Right now the convert_ToAPB while it isn't correct with today's terminology, it is consistent with all the other calls. I vote to leave it alone, just a historical wart as the code has progressed.

@jmrodri jmrodri closed this as completed Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmrodri jmrodri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmrodri @alaypatel07