Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundles filtered log is hard to read #147

Closed
jmrodri opened this issue Jul 23, 2018 · 5 comments
Closed

Bundles filtered log is hard to read #147

jmrodri opened this issue Jul 23, 2018 · 5 comments
Assignees
@jmrodri

Comments

@jmrodri
Copy link
Contributor

jmrodri commented Jul 23, 2018

Feels like the log statement shouldn't be all on one line. it's hard to read:

time="2018-07-23T21:27:57Z" level=info msg="Bundles filtered by white/blacklist filter:-> ansibleplaybookbundle/apb-tools-> ansibleplaybookbundle/origin-ansible-service-broker-> ansibleplaybookbundle/hello-world-> ansibleplaybookbundle/mediawiki123-> ansibleplaybookb     undle/ansible-service-broker-> ansibleplaybookbundle/apb-base-> ansibleplaybookbundle/origin-> ansibleplaybookbundle/py-zip-demo-> ansibleplaybookbundle/asb-installer-> ansibleplaybookbundle/photo-album-demo-app-> ansibleplaybookbundle/helm-bundle-base-> ansibleplayb     ookbundle/deploy-broker-> ansibleplaybookbundle/photo-album-demo-api-> ansibleplaybookbundle/apb-assets-base-> ansibleplaybookbundle/manageiq-apb-runner-> ansibleplaybookbundle/vnc-client-> ansibleplaybookbundle/mediawiki-> ansibleplaybookbundle/origin-service-catalo     g-> ansibleplaybookbundle/origin-recycler-> ansibleplaybookbundle/vnc-desktop-> ansibleplaybookbundle/origin-deployer-> ansibleplaybookbundle/origin-docker-registry-> ansibleplaybookbundle/origin-haproxy-router-> ansibleplaybookbundle/origin-pod-> ansibleplaybookbund     le/origin-sti-builder-> ansibleplaybookbundle/kubevirt-ansible"

The -> should be in front of the apbs, but it looks like it is after.

     if len(filteredNames) != 0 {
         var buffer bytes.Buffer
         buffer.WriteString("Bundles filtered by white/blacklist filter:")
         for _, name := range filteredNames {
             buffer.WriteString(fmt.Sprintf("-> %s", name))
         }
         log.Infof(buffer.String())
     }
@jmrodri
Copy link
Contributor Author

jmrodri commented Jul 23, 2018

If we keep it on a single line, I suggest we replace -> with maybe |

time="2018-07-23T21:27:57Z" level=info msg="Bundles filtered by white/blacklist filter: |ansibleplaybookbundle/apb-tools |ansibleplaybookbundle/origin-ansible-service-broker |ansibleplaybookbundle/hello-world |ansibleplaybookbundle/mediawiki123 |ansibleplaybookbundle/ansible-service-broker |ansibleplaybookbundle/apb-base |ansibleplaybookbundle/origin |ansibleplaybookbundle/py-zip-demo |ansibleplaybookbundle/asb-installer |ansibleplaybookbundle/photo-album-demo-app |ansibleplaybookbundle/helm-bundle-base |ansibleplayb  ookbundle/deploy-broker |ansibleplaybookbundle/photo-album-demo-api |ansibleplaybookbundle/apb-assets-base |ansibleplaybookbundle/manageiq-apb-runner |ansibleplaybookbundle/vnc-client |ansibleplaybookbundle/mediawiki |ansibleplaybookbundle/origin-service-catalog |ansibleplaybookbundle/origin-recycler |ansibleplaybookbundle/vnc-desktop |ansibleplaybookbundle/origin-deployer |ansibleplaybookbundle/origin-docker-registry |ansibleplaybookbundle/origin-haproxy-router |ansibleplaybookbundle/origin-pod |ansibleplaybookbundle/origin-sti-builder |ansibleplaybookbundle/kubevirt-ansible"

@jmrodri
Copy link
Contributor Author

jmrodri commented Jul 23, 2018

I think I'd prefer one per line instead:

time="2018-07-23T21:27:57Z" level=info msg="Bundles filtered by white/blacklist filter:
    -> ansibleplaybookbundle/apb-tools
    -> ansibleplaybookbundle/origin-ansible-service-broker
    -> ansibleplaybookbundle/hello-world
    -> ansibleplaybookbundle/mediawiki123
    -> ansibleplaybookbundle/ansible-service-broker
    -> ansibleplaybookbundle/apb-base
    -> ansibleplaybookbundle/origin
    -> ansibleplaybookbundle/py-zip-demo
    -> ansibleplaybookbundle/asb-installer
    -> ansibleplaybookbundle/photo-album-demo-app
    -> ansibleplaybookbundle/helm-bundle-base
    -> ansibleplaybookbundle/deploy-broker
    -> ansibleplaybookbundle/photo-album-demo-api
    -> ansibleplaybookbundle/apb-assets-base
    -> ansibleplaybookbundle/manageiq-apb-runner
    -> ansibleplaybookbundle/vnc-client
    -> ansibleplaybookbundle/mediawiki
    -> ansibleplaybookbundle/origin-service-catalog
    -> ansibleplaybookbundle/origin-recycler
    -> ansibleplaybookbundle/vnc-desktop
    -> ansibleplaybookbundle/origin-deployer
    -> ansibleplaybookbundle/origin-docker-registry
    -> ansibleplaybookbundle/origin-haproxy-router
    -> ansibleplaybookbundle/origin-pod
    -> ansibleplaybookbundle/origin-sti-builder
    -> ansibleplaybookbundle/kubevirt-ansible"

@jmrodri
Copy link
Contributor Author

jmrodri commented Jul 23, 2018 •
edited

Or better yet one per line

time="2018-07-23T21:27:57Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/apb-tools
time="2018-07-23T21:27:58Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/origin-ansible-service-broker
time="2018-07-23T21:27:58Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/hello-world
time="2018-07-23T21:27:58Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/mediawiki123
time="2018-07-23T21:27:58Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/ansible-service-broker
time="2018-07-23T21:27:58Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/apb-base
time="2018-07-23T21:27:58Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/origin
time="2018-07-23T21:27:59Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/py-zip-demo
time="2018-07-23T21:27:59Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/asb-installer
time="2018-07-23T21:27:59Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/photo-album-demo-app
time="2018-07-23T21:27:59Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/helm-bundle-base
time="2018-07-23T21:27:59Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/deploy-broker
time="2018-07-23T21:27:59Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/photo-album-demo-api
time="2018-07-23T21:27:59Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/apb-assets-base
time="2018-07-23T21:27:60Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/manageiq-apb-runner
time="2018-07-23T21:27:60Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/vnc-client
time="2018-07-23T21:27:60Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/mediawiki
time="2018-07-23T21:27:60Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/origin-service-catalog
time="2018-07-23T21:27:60Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/origin-recycler
time="2018-07-23T21:27:60Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/vnc-desktop
time="2018-07-23T21:27:61Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/origin-deployer
time="2018-07-23T21:27:61Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/origin-docker-registry
time="2018-07-23T21:27:61Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/origin-haproxy-router
time="2018-07-23T21:27:61Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/origin-pod
time="2018-07-23T21:27:61Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/origin-sti-builder
time="2018-07-23T21:27:61Z" level=info msg="Bundles filtered by white/blacklist filter: -> ansibleplaybookbundle/kubevirt-ansible"

@jmrodri
Copy link
Contributor Author

jmrodri commented Jul 23, 2018

Let's make it look like we did with **Bundles passing white/blaclist filter:"

if len(validNames) != 0 {                                
    log.Debugf("Bundles passing white/blacklist filter:")
    for _, name := range validNames {                    
        log.Debugf("-> %s", name)                        
    }                                                    
}                                                        
time="2018-07-23T21:28:08Z" level=debug msg="Bundles passing white/blacklist filter:"
 465 time="2018-07-23T21:28:08Z" level=debug msg="-> openshift/php"                  
 466 time="2018-07-23T21:28:08Z" level=debug msg="-> openshift/postgresql"           
 467 time="2018-07-23T21:28:08Z" level=debug msg="-> openshift/python"               
 468 time="2018-07-23T21:28:08Z" level=debug msg="-> openshift/httpd"                
 469 time="2018-07-23T21:28:08Z" level=debug msg="-> openshift/mysql"                
 470 time="2018-07-23T21:28:08Z" level=debug msg="-> openshift/nginx"                
 471 time="2018-07-23T21:28:08Z" level=debug msg="-> openshift/nodejs"               
 472 time="2018-07-23T21:28:08Z" level=debug msg="-> openshift/perl"                 
 473 time="2018-07-23T21:28:08Z" level=debug msg="-> openshift/redis"                
 474 time="2018-07-23T21:28:08Z" level=debug msg="-> openshift/ruby"                 
 475 time="2018-07-23T21:28:08Z" level=debug msg="-> openshift/jenkins"              
 476 time="2018-07-23T21:28:08Z" level=debug msg="-> openshift/mariadb"              
 477 time="2018-07-23T21:28:08Z" level=debug msg="-> openshift/mongodb"

@jmrodri jmrodri mentioned this issue Jul 23, 2018
Merged
@jmrodri jmrodri self-assigned this Jul 24, 2018
@jmrodri
Copy link
Contributor Author

jmrodri commented Jul 26, 2018

Fixed by PR #149

@jmrodri jmrodri closed this as completed Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmrodri jmrodri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmrodri