Bug 1723422 - properly handle pagination url #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmrodri
commented
Jun 29, 2019
jmrodri
commented
- set path and query string properly
- fix getNextImageURL parsing of path url
- add unit test for getNextImageURL
* set path and query string properly * fix getNextImageURL parsing of path url * add unit test for getNextImageURL
shawn-hurley
approved these changes
Jul 1, 2019
Contributor
shawn-hurley
left a comment
shawn-hurley
left a comment
There was a problem hiding this comment.
I think it will fix the problem, just some nits.
registries/adapters/oauth/client.go
Outdated
|
|
||
| // path might be a fully qualified URL and we only want the path | ||
| // and query bits | ||
| thebits, err := url.Parse(path) |
Contributor
There was a problem hiding this comment.
personally, I would change the variable name but not a blocker
Contributor
Author
There was a problem hiding this comment.
changed to pathAsUrl let me know if that is not okay.
Contributor
Author
There was a problem hiding this comment.
actually changed it to pathAsURL since pathAsUrl pissed off lint :)
registries/adapters/oauth/client.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| req.URL.Path = thebits.Path |
Contributor
There was a problem hiding this comment.
could we just set req.URL = thebits?
Contributor
Author
There was a problem hiding this comment.
The comment on NewRequest states they use the base URL from the client. So I wanted to keep the same functionality.
// NewRequest - creates and returns a *http.Request assuming the GET method.
// The base URL configured on the Client gets used with its Path component
// replaced by the path argument. If a token is available, it is added to the
// request automatically. "Accept: application/json" is added to all requests.
// The caller should customize the request as necessary before using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.