Allow dependencies to be defined on params #70
Conversation
philipgough
changed the title
|
I have read through the attached issue and I like the solution that you guys came up with. Since this will involve an addition to the Bundle spec this type of change will require a version bump of the Bundle Spec along with documentation updates (see here for current documentation around Bundle spec). |
|
From discussing at the community meeting we agreed that this will require a minor version bump of the Bundle spec bringing us to version |
| Updatable bool `json:"updatable"` | ||
| DisplayType string `json:"displayType,omitempty" yaml:"display_type,omitempty"` | ||
| DisplayGroup string `json:"displayGroup,omitempty" yaml:"display_group,omitempty"` | ||
| Dependencies []Dependency `json:"dependencies,omitempty" yaml:"dependencies,omitempty"` |
There was a problem hiding this comment.
We can only handle a single dependency here currently in the broker due to limitations in the frontend lib but I think to future proof where we may be able to do this if we can extend that lib, leaving this as a slice makes sense IMO. What do people think?
The spec itself should be able to support multiple dependencies if my understanding of it is correct.
There was a problem hiding this comment.
Agreed @philipgough allow multiple dependencies.
|
Thanks for doing a doc PR! |
| @@ -1,3 +1,6 @@ | |||
| vendor* | |||
| coverage-all.out | |||
| coverage.out | |||
|
|
|||
| # IDE baggage | |||
| .idea/ | |||
| Updatable bool `json:"updatable"` | ||
| DisplayType string `json:"displayType,omitempty" yaml:"display_type,omitempty"` | ||
| DisplayGroup string `json:"displayGroup,omitempty" yaml:"display_group,omitempty"` | ||
| Dependencies []Dependency `json:"dependencies,omitempty" yaml:"dependencies,omitempty"` |
There was a problem hiding this comment.
Agreed @philipgough allow multiple dependencies.
philipgough
changed the title
Relates to openshift/ansible-service-broker#859