Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use H1 for header title and cover image caption #177

Merged
merged 7 commits into from May 19, 2016

Conversation

@gemedet
Copy link
Contributor

gemedet commented Apr 19, 2016

This allows markup inside the header title and cover image caption, e.g.:

<header>
    <figure>
        <figcaption>Some caption <i>in italic</i></figcaption>
    </figure>
    <h1>Some title <b>in bold</b></h1>
</header>

Follows facebook/facebook-instant-articles-sdk-php#93

@gemedet gemedet changed the title Use H1 for cover image caption Use H1 for header title and cover image caption May 5, 2016
@everton-rosario everton-rosario merged commit ed25fc8 into Automattic:master May 19, 2016
@everton-rosario

This comment has been minimized.

Copy link
Collaborator

everton-rosario commented May 19, 2016

Hello @gemedet !
This was a nice catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.