Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative URL issue with oembeds not using absolute URLs #290

Merged
merged 3 commits into from Jul 8, 2016

Conversation

@stuartshields
Copy link
Contributor

stuartshields commented May 24, 2016

This fixes an issue when oembeds like instagram, twitter etc. use <script async="" defer="defer" src="//platform.instagram.com/en_US/embeds.js"/> instead of <script async="" defer="defer" src="https://platform.instagram.com/en_US/embeds.js"/>. Without this fix Facebook Instant Articles will report an error to the user about the article.

@stuartshields stuartshields changed the title Fix-relative-url-issue Add dom to fix relative URL issue in scripts Fix relative URL issue with oembeds not using absolute URLs May 24, 2016
@everton-rosario

This comment has been minimized.

Copy link
Collaborator

everton-rosario commented Jul 8, 2016

@stuartshields Thanks for this PR.

Sorry for the long wait on reviewing.

Merging it.

@everton-rosario everton-rosario merged commit 9396fdc into Automattic:master Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.