Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the global $post object has been set #301

Merged
merged 1 commit into from Jul 8, 2016

Conversation

Projects
None yet
3 participants
@srtfisher
Copy link
Contributor

commented May 27, 2016

No description provided.

@@ -296,7 +296,7 @@ protected function _get_the_content() {
// If we’re not it the loop or otherwise properly setup.
$reset_postdata = false;
if ( $this->_post->ID !== $post->ID ) {
if ( empty( $post ) || $this->_post->ID !== $post->ID ) {

This comment has been minimized.

Copy link
@stuartshields

stuartshields May 28, 2016

Contributor

@srtfisher What instance did you come across to need this?

This comment has been minimized.

Copy link
@srtfisher

srtfisher May 28, 2016

Author Contributor

Adding this plugin to a VIP site caused issues when running unit tests.
On Sat, May 28, 2016 at 3:10 AM Stuart Shields notifications@github.com
wrote:

In class-instant-articles-post.php
#301 (comment)
:

@@ -296,7 +296,7 @@ protected function _get_the_content() {

    // If we’re not it the loop or otherwise properly setup.
    $reset_postdata = false;
  •   if ( $this->_post->ID !== $post->ID ) {
    
  •   if ( empty( $post ) || $this->_post->ID !== $post->ID ) {
    

@srtfisher https://github.com/srtfisher What instance did you come
across to need this?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Automattic/facebook-instant-articles-wp/pull/301/files/3a281fca4daef5af11ce01cd7446c51a4f191696#r64985112,
or mute the thread
https://github.com/notifications/unsubscribe/AAVJH1DrYWJBWb-aicXnnO26Uy0OCbU1ks5qF-p1gaJpZM4Io2Km
.

@everton-rosario everton-rosario merged commit 91194ce into Automattic:master Jul 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.