Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always use HTTPS to load JavaScript SDK; update to 2.6 #329

Merged
merged 1 commit into from Jul 12, 2016

Conversation

@paulschreiber
Copy link
Contributor

paulschreiber commented Jun 20, 2016

The Facebook SDK should always be loaded over HTTPS. We shouldn't use a protocol-relative URL.

Also bumped the SDK version to 2.6, which is current.

@philipjohn

This comment has been minimized.

Copy link
Member

philipjohn commented Jul 6, 2016

@diegoquinteiro Do you see any issue with the version bump here?

@diegoquinteiro

This comment has been minimized.

Copy link
Collaborator

diegoquinteiro commented Jul 12, 2016

@philipjohn no, it is good! :shipit:

@philipjohn philipjohn merged commit 6bc81c6 into Automattic:master Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.