This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Add subtitle to $header when rendering post to IA #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin has functions built-in for subtitles; however it does not include it when constructing the header. Including it here allows users to use the built-in `instant_articles_subtitle` filter that allows users to target their subtitles, should they be part of their theme. We’ve run into an issue during the submission process where subtitles where missing and Facebook mandating that we include them.
|
@jacobarriola nice catch! Please join our group @ Facebook: https://web.facebook.com/groups/629655867187397/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin has functions built-in for subtitles; however it does not include it when constructing the header. Including it here allows users to use the built-in
instant_articles_subtitlefilter that allows users to target their subtitles, should they be part of their theme.We’ve run into an issue during the submission process where subtitles were missing and Facebook mandating that we include them.