Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit blocker option - No warnings in transformer to publish #375

Merged
merged 3 commits into from Jul 25, 2016

Conversation

@everton-rosario
Copy link
Collaborator

everton-rosario commented Jul 21, 2016

This PR:

  • Creates a flag in settings "block_publish_with_warnings"
  • Flag defaults to false (disabled)
  • If flag is true and transformer results in warnings, Instant Article is not registered

Depends on SDK: facebook/facebook-instant-articles-sdk-php#154

@@ -25,7 +25,7 @@
"selector" : "span"
}, {
"class": "ParagraphRule",
"selector": "p"
"selector": "pad"

This comment has been minimized.

Copy link
@diegoquinteiro

diegoquinteiro Jul 22, 2016

Collaborator

that doesn't look right ;)

This comment has been minimized.

Copy link
@everton-rosario

everton-rosario Jul 22, 2016

Author Collaborator

#fuuuu
that was a test case.
Tks for spotting it :-)

&& $publishing_settings['block_publish_with_warnings'] ) {
// Unpublishes if already published
$client->removeArticle( $article->get_canonical_url() );

This comment has been minimized.

Copy link
@diegoquinteiro

diegoquinteiro Jul 22, 2016

Collaborator

love this; let's prevent outdated posts to be live =)

@diegoquinteiro

This comment has been minimized.

Copy link
Collaborator

diegoquinteiro commented Jul 22, 2016

overall it is good, but please fix you test leftover =)

@everton-rosario everton-rosario mentioned this pull request Jul 22, 2016
1 of 1 task complete
@everton-rosario everton-rosario merged commit 323b020 into master Jul 25, 2016
@everton-rosario everton-rosario deleted the block_warnings branch Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.