Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack compat: YouTube and Facebook embeds #39

Merged
merged 2 commits into from Mar 9, 2016

Conversation

Projects
None yet
4 participants
@bjornjohansen
Copy link
Contributor

commented Mar 8, 2016

Do not "fix" bare YouTube URLs on the own line as we have have oEmbed to handle those.

By unregistering the embed handler that Jetpack registers, we avoid the Jetpack YouTube HTML output altogether and let the oEmbed handler handle it.

Fixes #20

@bjornjohansen bjornjohansen changed the title Jetpack compat: Do not "fix" bare YouTube URLs on the own line as we have have oEmbed to handle those. Jetpack compat: YouTube and Facebook embeds Mar 8, 2016

@bjornjohansen

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2016

c422595 takes care of proper Facebook post embeds.
Fixes #25

philipjohn added a commit that referenced this pull request Mar 9, 2016

Merge pull request #39 from DekodeInteraktiv/jetpack-compat
Jetpack compat: YouTube and Facebook embeds

@philipjohn philipjohn merged commit 711c0a2 into Automattic:master Mar 9, 2016

@rinatkhaziev

This comment has been minimized.

It's no biggie, but sdk.js should probably load current version (which is v2.5 right now).

@bjornjohansen bjornjohansen deleted the DekodeInteraktiv:jetpack-compat branch Mar 9, 2016

@aldnin

This comment has been minimized.

Copy link

commented on c422595 Apr 21, 2016

Tested with facebook embedded posts and Jetpack:
Constant is not set when it is being checked to be defined in this compat file. Implementation does not work in my testing environment for facebook postings, although Jetpack embeds postings perfectly on the website. Pulled the most recent version of the facebook-instantarticles-wp plugin, tested with WordPress 4.4.2 and Jetpack 4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.