Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the instant_articles_post_types filter when registering metaboxes #416

Merged

Conversation

Projects
None yet
5 participants
@technosailor
Copy link
Contributor

technosailor commented Aug 22, 2016

This PR:

  • Uses the already exiting instant_articles_post_types filter and applies to post type support in the register_meta_box() call.

Fixes #415

@everton-rosario
Copy link
Collaborator

everton-rosario left a comment

Hey @technosailor thanks for this! You've filed a task and also a PR, awesome!

Can you please rebase it and then we can wait the continuous integration run again. When you sent this PR the tests were broken.

@everton-rosario everton-rosario added this to the 3.2 milestone Oct 4, 2016

@diegoquinteiro
Copy link
Collaborator

diegoquinteiro left a comment

nice catch!

@diegoquinteiro

This comment has been minimized.

Copy link
Collaborator

diegoquinteiro commented Oct 5, 2016

That one just needs a rebase.

demoive added a commit that referenced this pull request Oct 6, 2016

@demoive

This comment has been minimized.

Copy link
Contributor

demoive commented Oct 7, 2016

@philipjohn I think the failed check is the same as explained by @everton-rosario here: #423 (comment)

@demoive demoive added fixready and removed needs review labels Oct 7, 2016

@philipjohn philipjohn merged commit 53fb17e into Automattic:master Oct 11, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@technosailor

This comment has been minimized.

Copy link
Contributor Author

technosailor commented Oct 11, 2016

I think my email filters were snarfing up notifications on this PR but it looks like everything got sorted. Thanks, @philipjohn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.