Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Playbuzz plugin #417

Merged
merged 3 commits into from Oct 11, 2016

Conversation

Projects
None yet
2 participants
@everton-rosario
Copy link
Collaborator

commented Aug 23, 2016

This PR:

  • Adds compat support for the playbuzz plugin
  • Adds setup rules for the playbuzz markup
  • Checks to enable these rules only if playbuzz is enabled.

Fixes #134

@everton-rosario everton-rosario added this to the 3.2 milestone Oct 4, 2016

compat.php Outdated
@@ -46,3 +45,10 @@
$gti = new Instant_Articles_Get_The_Image;
$gti->init();
}
// Load support for Playbuzz plugin
if ( is_plugin_active( 'playbuzz/index.php' ) ) {

This comment has been minimized.

Copy link
@philipjohn

philipjohn Oct 5, 2016

Member

This isn't going to work on VIP (which is probably more our problem, but we should fix it here anyway) but also is vulnerable to changes in the playbuzz plugin itself.

It'd be more reliable to check for the existence of a class or function, if possible.

This comment has been minimized.

Copy link
@everton-rosario

everton-rosario Oct 6, 2016

Author Collaborator

Ok @philipjohn I've changed the way to check if plugin is active by verifying the functions they define/implement.

This should work on VIP.

Changed to verify if plugins are active by other means, since VIP doe…
…sn't work well with 'is_plugin_active' function.

@philipjohn philipjohn merged commit 614020e into master Oct 11, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@philipjohn philipjohn deleted the playbuzz branch Oct 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.