Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #452 - Use of empty() on PHP prior to v5.5 #464

Merged
merged 1 commit into from Sep 19, 2016

Conversation

Projects
None yet
3 participants
@demoive
Copy link
Contributor

commented Sep 16, 2016

This PR:

  • Makes use of count() instead of empty() when checking for get_settings_errors() since it always returns an Array.

Fixes #452

@everton-rosario everton-rosario added this to the 3.1.2 milestone Sep 16, 2016

@everton-rosario

This comment has been minimized.

Copy link
Collaborator

commented Sep 16, 2016

LGTM.

@philipjohn can you have it released on the patch fix?

@philipjohn philipjohn merged commit b089b76 into Automattic:master Sep 19, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.