Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apester plugin support #609

Merged
merged 3 commits into from Feb 16, 2017

Conversation

Projects
None yet
2 participants
@oraricha
Copy link
Contributor

commented Feb 12, 2017

This PR:

  • Adds compat support for the Apester plugin
  • Adds setup rules for the Apester markup
  • Enables these rules by default - not dependant on Apester plugin installation state
@oraricha

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2017

Hey @philipjohn,
Regarding Issue #610,
I've Added compat support for Apester medias, including auto loading the transformer rules.
Please review and approve if all is OK.
Thank you

@diegoquinteiro diegoquinteiro added this to the 3.4 milestone Feb 13, 2017

@diegoquinteiro
Copy link
Collaborator

left a comment

It is possible that the script end up no being enclosed in a paragraph depending on the markup structure (for instance, it may appear inside a blockquote instead depending on the user input).

{
"rules": [{
"class": "IgnoreRule",
"selector": "//p/script[contains(@src,'apester')]"

This comment has been minimized.

Copy link
@diegoquinteiro

diegoquinteiro Feb 13, 2017

Collaborator

You should ignore the script even if outside of the paragraph:

    "selector": "//script[contains(@src,'apester')]"

The empty paragraph should be stripped out automatically.

This comment has been minimized.

Copy link
@oraricha

oraricha Feb 14, 2017

Author Contributor

Thanks @diegoquinteiro, you're correct. I've changed the file properly. CI is running checks...

@diegoquinteiro
Copy link
Collaborator

left a comment

Looks great. Thank you so much for contributing!

@oraricha

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2017

Thanks @diegoquinteiro 👍
When will the changes be merged and available in production?

@diegoquinteiro diegoquinteiro merged commit 7a4b8d6 into Automattic:master Feb 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@diegoquinteiro

This comment has been minimized.

Copy link
Collaborator

commented Feb 16, 2017

@oraricha we'll be wrapping up 3.4 soon and launch on the plugin repository. Meanwhile you can ZIP this repository and upload it directly (after running composer install).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.