Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Google Analytics compat #629

Merged
merged 1 commit into from May 29, 2017

Conversation

@dlackty
Copy link
Contributor

dlackty commented Mar 3, 2017

This PR:

  • Supports google-analytics-for-wordpress plugin version 6 or later
  • Keeps compatilbility with previous versions
  • Follows plugin name rebranding

Relates to #620

@everton-rosario

This comment has been minimized.

Copy link
Collaborator

everton-rosario commented Mar 6, 2017

@dlackty hey, thanks for this PR.
How does this compare to #620?

Can we group together both PRs?

@dlackty

This comment has been minimized.

Copy link
Contributor Author

dlackty commented Mar 7, 2017

@everton-rosario I've took a look on that PR and left a comment. Please have a look.

@dlackty dlackty force-pushed the dlackty:support-monsterinsights branch from d2f86ce to c6dadba May 28, 2017
@dlackty

This comment has been minimized.

Copy link
Contributor Author

dlackty commented May 28, 2017

@everton-rosario Just rebased this on master branch. Could you please have a look or suggest someone to review this? This integration between IA & GA has been broken for months and I believe other users might encounter this too.

Copy link
Collaborator

everton-rosario left a comment

This looks good to me.

@everton-rosario everton-rosario added this to the 4.0 milestone May 29, 2017
@everton-rosario everton-rosario merged commit f628530 into Automattic:master May 29, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.