Fix "Empty string supplied as input" bug #647
Conversation
Fix `PHP Warning: DOMDocument::loadHTML(): Empty string supplied as input`, by verifying the content and making sure if it is empty, do not `transformString`.
abdusfauzi
changed the title
There was a problem hiding this comment.
get_the_content calls has few filters, and probably calling twice should be avoided.
Thanks for your PRs @abdusfauzi
class-instant-articles-post.php
Outdated
| @@ -690,7 +690,9 @@ public function to_instant_article() { | |||
| Video::setDefaultCommentEnabled( $settings_publishing[ 'comments_on_media' ] ); | |||
| } | |||
|
|
|||
| $transformer->transformString( $this->instant_article, $this->get_the_content(), get_option( 'blog_charset' ) ); | |||
| if ( '' != $this->get_the_content() ) { | |||
There was a problem hiding this comment.
Is this happening to you?
I'd change this, so we call only once the get_the_content() method here.
Can you do it like this:
$the_content = $this->get_the_content();
if ( '' != $the_content ) {
$transformer->transformString...
}
There was a problem hiding this comment.
Cool. No problem 👌🏻
There was a problem hiding this comment.
@everton-rosario Rewrite the fix to reduce the get_the_content() call only once.
class-instant-articles-post.php
Outdated
| @@ -690,7 +690,9 @@ public function to_instant_article() { | |||
| Video::setDefaultCommentEnabled( $settings_publishing[ 'comments_on_media' ] ); | |||
| } | |||
|
|
|||
| $transformer->transformString( $this->instant_article, $this->get_the_content(), get_option( 'blog_charset' ) ); | |||
| if ( '' != $this->get_the_content() ) { | |||
There was a problem hiding this comment.
Cool. No problem 👌🏻
class-instant-articles-post.php
Outdated
| $transformer->transformString( $this->instant_article, $this->get_the_content(), get_option( 'blog_charset' ) ); | ||
|
|
||
| $the_content = $this->get_the_content(); | ||
| if ( '' != $the_content ) { |
There was a problem hiding this comment.
Can you please use the Type::isTextEmpty() method for this? Ty
There was a problem hiding this comment.
@vkama i'm sorry, i wish i understand how to use the suggested Type:isTextEmpty() 😰 Would you mind show me sample?
There was a problem hiding this comment.
use Facebook\InstantArticles\Validators\Type;
if (!Type::isTextEmpty($the_content)) { ... }
class-instant-articles-post.php
Outdated
| @@ -691,7 +693,7 @@ public function to_instant_article() { | |||
| } | |||
|
|
|||
| $the_content = $this->get_the_content(); | |||
| if ( '' != $the_content ) { | |||
| if (!Type::isTextEmpty($the_content)) { | |||
This PR:
Fixes #
Fix
PHP Warning: DOMDocument::loadHTML(): Empty string supplied as input, by verifying the content and making sure if it is empty, do nottransformString.Automattic/facebook-instant-articles-wp#628