Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change meta box and readme so user doesn't think IAs are actually submitted to Facebook #792

Merged
merged 4 commits into from Nov 2, 2017

Conversation

Projects
None yet
3 participants
@timjacobi
Copy link
Collaborator

timjacobi commented Oct 30, 2017

Due to the recent change in the Graph API articles are not being published to Facebook automatically anymore but rather have to be shared first. See also #791

This updates all messaging to account for this change.

@timjacobi timjacobi requested review from diegoquinteiro and pestevez Oct 30, 2017

@timjacobi timjacobi changed the title Change meta box and readme so user doesn't think IAs are actually Change meta box and readme so user doesn't think IAs are actually submitted to Facebook Oct 30, 2017

@everton-rosario
Copy link
Collaborator

everton-rosario left a comment

Please also consider removing the call to the rescrape call, since it is not working anymore.
This way we won't have this misleading call in the code.

The code lies here: facebook-instant-articles.php
Function: function rescrape_article( $post_id, $post )

@@ -22,39 +22,39 @@
<p>
<b>
<span class="dashicons dashicons-yes"></span>
This post will be available as an Instant Article.
This post will be available as Instant Article.

This comment has been minimized.

Copy link
@everton-rosario

everton-rosario Oct 31, 2017

Collaborator
  • once shared on Facebook.
README.md Outdated
@@ -57,7 +60,7 @@ You can propose popular transformer rules to be included in the plugin by [sugge

**How do I post articles to Instant Articles after plugin is installed?**

You can re-publish existing articles (simply edit + save) or post new articles in order to submit them to Instant Articles. After you have 10 articles added, you will be able to submit them for review.
You can re-publish existing articles (simply edit + save) or post new articles in order to make them available as Instant Articles. After you have 5 articles added and shared, you will be able to submit them for review.

This comment has been minimized.

Copy link
@everton-rosario

everton-rosario Oct 31, 2017

Collaborator

... After you have 5 articles added and shared on Facebook, you will...

@timjacobi

This comment has been minimized.

Copy link
Collaborator Author

timjacobi commented Oct 31, 2017

@everton-rosario this PR is only to update the messaging. I agree we should remove the API calls but I will do that in a separate PR.

@everton-rosario
Copy link
Collaborator

everton-rosario left a comment

LGTM

@diegoquinteiro
Copy link
Collaborator

diegoquinteiro left a comment

Thanks for reviewing the language here, it's long overdue! Please take a look at my comments =)

README.md Outdated
@@ -39,6 +39,9 @@ Facebook requires a minimum number of articles in your feed before they will rev

More likely than not, this is because there is markup in the body of your post that is not mapped to a recognized Instant Article component. On the “Edit Post” screen for your post, look for additional information about the *transformed* output shown within the **Facebook Instant Articles** module located at the bottom of the screen.

**Why doesn't my post appear in the list of Instant Articles in the publisher tools?**
In order for your post to be imported you have to share it on your page first.

This comment has been minimized.

Copy link
@diegoquinteiro

diegoquinteiro Oct 31, 2017

Collaborator

Actually it works when any user shares the link on any page/profile. Maybe we should phrase it as:

Your posts are imported to your library when they are shared 
on Facebook for the first time. 

Alternatively, you can trigger a manual scrape by pasting your 
URL on our [Share Debugger](http://developers.facebook.com/tools/debug)

This comment has been minimized.

Copy link
@timjacobi

timjacobi Oct 31, 2017

Author Collaborator

I like it!

README.md Outdated
@@ -57,7 +60,7 @@ You can propose popular transformer rules to be included in the plugin by [sugge

**How do I post articles to Instant Articles after plugin is installed?**

You can re-publish existing articles (simply edit + save) or post new articles in order to submit them to Instant Articles. After you have 10 articles added, you will be able to submit them for review.
You can re-publish existing articles (simply edit + save) or post new articles in order to make them available as Instant Articles. After you have 5 articles added and shared, you will be able to submit them for review.

This comment has been minimized.

Copy link
@diegoquinteiro

diegoquinteiro Oct 31, 2017

Collaborator

I think now it's 10 indeed: https://developers.facebook.com/docs/instant-articles/quickstart#review

In fact, now you don't need to edit+save your posts to submit - it doesn't work anymore. We should let them know that new articles will be submitted when shared and old articles can be re-scraped through the Share Debugger.

@@ -22,39 +22,39 @@
<p>
<b>
<span class="dashicons dashicons-yes"></span>
This post will be available as an Instant Article.
This post will be available as Instant Article.

This comment has been minimized.

Copy link
@diegoquinteiro

diegoquinteiro Oct 31, 2017

Collaborator

Maybe:

"This post will be available as Instant Article when shared on Facebook"

</b>
</p>
<hr>
<?php elseif ( ! $published ) : ?>
<p>
<b>
<span class="dashicons dashicons-media-document"></span>
This post will be submitted to Instant Articles once it is published.
This post will be available as Instant Article once it is published.

This comment has been minimized.

Copy link
@diegoquinteiro

diegoquinteiro Oct 31, 2017

Collaborator

Here too:

"This post will be available as Instant Article once it is published and shared on Facebook"

@diegoquinteiro
Copy link
Collaborator

diegoquinteiro left a comment

Some small fixes and we'll be good to go.

README.md Outdated
@@ -57,7 +61,7 @@ You can propose popular transformer rules to be included in the plugin by [sugge

**How do I post articles to Instant Articles after plugin is installed?**

You can re-publish existing articles (simply edit + save) or post new articles in order to submit them to Instant Articles. After you have 10 articles added, you will be able to submit them for review.
You can re-publish existing articles (simply edit + save) or post new articles in order to make them available as Instant Articles. After you have 5 articles added and shared on Facebook, you will be able to submit them for review.

This comment has been minimized.

Copy link
@diegoquinteiro

diegoquinteiro Nov 1, 2017

Collaborator

The first sentence is still inaccurate. Editing + saving the article does nothing anymore. You need to share it (even without editing+saving). Check my previous comment. Also, we now require 10 articles, not 5.

@@ -22,39 +22,39 @@
<p>
<b>
<span class="dashicons dashicons-yes"></span>
This post will be available as an Instant Article.
This post will be available as Instant Article once it is published and shared on Facebook.

This comment has been minimized.

Copy link
@diegoquinteiro

diegoquinteiro Nov 1, 2017

Collaborator

At this condition the article is already published, so maybe:

This post will be available as Instant Article once it is shared on Facebook.

@timjacobi timjacobi merged commit 5cabc96 into Automattic:master Nov 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@timjacobi timjacobi deleted the timjacobi:update-ia-info branch Nov 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.