Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
remove article rescrape code #798
Thanks for the heads up. Can I ask you how did you learn about that? I've a site WP site with IA plugin and I was notified of some misbehaviour with posts not appearing in instant library and this could have shed some light on the issue.
Hey guys, this is the DEFINITELY WRONG way for this change to be communicated and explained.
For starters, this change, along with a detailed explanation of the Graph API changes, should have been on the Instant Articles Blog becuase it is enormous and important and that blog promises to keep us up to date.
I can imagine why you wouldn't want that though, because this change is uniquely terrible for users and publishers, and deeply embarrassing to Facebook. Still though, at least here on Github, it needed to be explained more usefully.
You should definitely be able to link to the place where the Graph API change was announced.
You should also be able to explain how the change made it impossible for you to replace this feature with the new version of the API, since it cripples the plugin to have this feature removed.
You should also have stated all the different effects this change would have had, for example that unlike before, where Instant Articles would update when the post was updated, now they will remain in the cache, stale and wrong, for 30 days. For more details see #878
This change creates fake news by making updates to articles not show on Facebook. If we correct an article, our users will see the wrong version. By not making this clear to us as publishers, you left us ignorant of the problem, and guilty of false news without even knowing it.
referenced this pull request
Feb 15, 2018
So, now I have looked through all the Graph API changes in the changelog, going back to 2016, and none of them imply that this should be broken, or that this feature should have been removed from this plugin.
Here is the section that relates to scraping which does not mention deprecation
Now, this was all in the "90-Day Breaking Changes" section, which, because the release date was July 18 2017, means that this change to the
But how does that API change mean that we can't have scraping in this plugin?!?
I can see that it broke, but why can't you fix it?
Based on reading the code, it doesn't seem like the GET/POST change is the culprit, as the code deleted from the plugin was already using POST. This leads me to believe that what broke the plugin was "This node now requires a valid access token."
So I don't even know exactly what that implies or entails, but I know that now I want to have an access token, and I want to use it to keep my posts up to date automatically the way this plugin kept them up to date before.
What is involved in getting an access token, and why can't this plugin accomplish it for us?
Was this problem discussed in a meeting that we don't have access to? Is it impossible?
It seems like this is the specific question that should have been discussed in this ticket, or at least there should have been an explanation of it, along with a link to the changelog.
Looks to me like the feature is still there, and this is something that can be fixed.