-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add fit/transform interface to the data validation #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fit/transform interface to the data validation #1041
Conversation
franchuterivera
commented
Dec 20, 2020
- Creates fit/transform interface to input validator
- Adds more checking thanks to pytest (we also move to pytest instead of unittest)
Codecov Report
@@ Coverage Diff @@
## development #1041 +/- ##
===============================================
+ Coverage 85.46% 85.66% +0.20%
===============================================
Files 127 128 +1
Lines 10177 10272 +95
===============================================
+ Hits 8698 8800 +102
+ Misses 1479 1472 -7
Continue to review full report at Codecov.
|
mfeurer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, This looks great but there are a lot of changes to look at, so I only left a few initial comments and remarks and will have a detailed look at the new transformers afterwards.
|
I was also wondering whether |
mfeurer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part 2 of the review. Tests are still to come.
mfeurer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And one more batch of comments.
Do you think you can elaborate more on this? Do you mean making sure all metrics works for all type of data? |
98273b3 to
1fa170c
Compare
|
There is one thing pending that needs further discussion... which is the fact that infer objects from pandas will not make an object column with letters categorical. Should we handle this ourselves using some heuristic? |
Yes, that's what I meant here. The score code looks a bit broken to me at the moment.
As I mentioned above, this will be handled by an upcoming PR. |