Raise error if ensemble is not built #480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix minor printing error in sprint_statistics.
Revert "Fix#460"
Codecov Report
@@ Coverage Diff @@
## development #480 +/- ##
===============================================
- Coverage 78.6% 78.54% -0.07%
===============================================
Files 130 130
Lines 10093 10098 +5
===============================================
- Hits 7934 7931 -3
- Misses 2159 2167 +8
Continue to review full report at Codecov.
|
ahn1340
changed the title
Contributor
Author
|
This should fix #460. |
mfeurer
approved these changes
May 18, 2018
ahn1340
added a commit
to ahn1340/auto-sklearn
that referenced
this pull request
May 29, 2018
* . * . * AutoSklearnClassifier/Regressor's fit, refit, fit_ensemble now return self. * Initial commit. Work in Progress. * Fix minor printing error in sprint_statistics. * Revert "Fix#460" * Resolve rebase conflict * combined unittests to reduce travis runtime * . * . * . * . * .
mfeurer
pushed a commit
that referenced
this pull request
Nov 9, 2018
* . * . * AutoSklearnClassifier/Regressor's fit, refit, fit_ensemble now return self. * Initial commit. Work in Progress. * Fix minor printing error in sprint_statistics. * Revert "Fix#460" * Raise error if ensemble is not built (#480) * . * . * AutoSklearnClassifier/Regressor's fit, refit, fit_ensemble now return self. * Initial commit. Work in Progress. * Fix minor printing error in sprint_statistics. * Revert "Fix#460" * Resolve rebase conflict * combined unittests to reduce travis runtime * . * . * . * . * . * ADD Auto-sklearn 0.4.1 release note to releases.rst
mfeurer
pushed a commit
that referenced
this pull request
Dec 6, 2018
* . * . * AutoSklearnClassifier/Regressor's fit, refit, fit_ensemble now return self. * Initial commit. Work in Progress. * Fix minor printing error in sprint_statistics. * Revert "Fix#460" * Raise error if ensemble is not built (#480) * . * . * AutoSklearnClassifier/Regressor's fit, refit, fit_ensemble now return self. * Initial commit. Work in Progress. * Fix minor printing error in sprint_statistics. * Revert "Fix#460" * Resolve rebase conflict * combined unittests to reduce travis runtime * . * . * . * . * . * Check target type at the beginning of the fitting process. * . * Fixed minor error in uniitest * . * Add unittest for target type checking. * . * . * [Debug] try with numpy version 1.14.5 * [Debug] Check if numpy version 1.14.6 raises error. * Check target type at the beginning of the fitting process. * . * Fixed minor error in uniitest * . * Add unittest for target type checking. * . * . * [Debug] Check if numpy version 1.14.6 raises error. * Fix numpy version to 1.14.5 * Add comment to Mock in test_type_of_target * Fix line length in example_parallel.py * Fix minor error * FIX classifier returning prediction larger than 1 * Remove comments * ADD unittest for ensemble_selection.predict() * minor FIX * ADD assertion in predict_proba to check probabilities sum up to 1. * REVERT changes in autosklearn/ensemble_builder.py * simplify ensemble prediction method * Modify assertion statement * ADD case check in ensemble_selection.predict() * Fix minor error in pred_probs verficiation. * Modify unittest for ensemble_selection.predict() * FIX flake8 errors * FIX flake8 error * ADD Ignore assertion for multilabel, check probabilities lie between [0, 1]. * Debug flake8 error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running autosklearn, ensembles will not be built if (1) ensemble_size is set to 0, or (2) if ensemble_builder process fails due to time limit. This causes refit, predict, and predict_proba to fail, and causes fit to fail if ensemble_size is not set to zero. This PR adds ValueError for such situations, along with other minor changes.