Skip to content

Conversation

@mstreuhofer
Copy link
Contributor

Instead of writing to /tmp/autosklearn_{tmp,output}_* use os.gettempdir() to follow the wishing of the responsible system administrator :)

@mfeurer
Copy link
Contributor

mfeurer commented Jul 30, 2018

Thanks a lot for your PR. Currently, travis-ci is broken and I will check once its up again. In the meantime, could you please redirect your PR to the development branch?

@mstreuhofer mstreuhofer changed the base branch from master to development July 30, 2018 17:23
@mfeurer mfeurer closed this Aug 1, 2018
@mfeurer mfeurer reopened this Aug 1, 2018
@codecov-io
Copy link

codecov-io commented Aug 1, 2018

Codecov Report

Merging #521 into development will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #521      +/-   ##
===============================================
- Coverage        78.63%   78.55%   -0.08%     
===============================================
  Files              130      130              
  Lines            10110    10110              
===============================================
- Hits              7950     7942       -8     
- Misses            2160     2168       +8
Impacted Files Coverage Δ
autosklearn/util/backend.py 79.12% <ø> (ø) ⬆️
...e/components/feature_preprocessing/select_rates.py 81.53% <0%> (-4.62%) ⬇️
..._preprocessing/select_percentile_classification.py 86.2% <0%> (-3.45%) ⬇️
...ipeline/components/regression/gradient_boosting.py 95.18% <0%> (-1.21%) ⬇️
autosklearn/automl.py 81.11% <0%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c30343...d346fd4. Read the comment docs.

@mfeurer mfeurer merged commit 6832382 into automl:development Aug 1, 2018
@mfeurer
Copy link
Contributor

mfeurer commented Aug 1, 2018

Thanks a lot!

@mstreuhofer mstreuhofer deleted the gettempdir branch August 1, 2018 20:14
mfeurer pushed a commit that referenced this pull request Nov 9, 2018
* Extending Autosklearn. First commit.

* Add regression example

* CI: upper bound numpy version due to travis failures

* CI: upper bound numpy version due to travis failures

* use tempfile.gettempdir() (#521)

* use tempfile.gettempdir()

* follow quality review coding standards

* Remove a colon from README.md (#527)

* fixing warnings on non-tuple sequence for indexing (#526)

* fix string formatting (#540)

* FIX removing models wrt wrong metric in ensemble (#522)

* Add examples for extending auto-sklearn.

* .

* Change datasets used in examples from digits to breast_cancer.

* First commit

* Fixing codacy errors

* Fixing bug

* [Debug] try different numpy version

* [Debug] Try with latest numpy version

* Set numpy version to 1.14.5

* First commit

* Fixing bug

* Modify flake8_diff.sh

* Extending Autosklearn. First commit.

* Add regression example

* Add examples for extending auto-sklearn.

* .

* Fixing codacy errors

* Change example (#553)

* Change datasets used in examples from digits to breast_cancer.

* [Debug] try different numpy version

* [Debug] Try with latest numpy version

* Set numpy version to 1.14.5

* Fix line length in exanple_parallel.py

* [WIP]Add argument for custom logger configuration. (#505)

* Add argument for custom logger configuration. First commit, work in progress.

* Minor changes.

* Modify suggested changes [WIP]

* .

* .

* .

* .

* Fix minor details

* Fix travis not recognizing example_config.yaml

* .

* .

* .

* .

* .

* Change datasets used in examples from digits to breast_cancer.

* Fix codacy error

* Revert codacy error fixing

* [Debug] check if numpy causes error

* [Debug] experimenting with numpy

* [Debug] try to manually install libgcc

* [Debug] libgcc

* [Debug] libgcc

* [Debug] libgcc

* [Debug] libgcc

* [Debug].

* [Debug].

* [Debug] .

* [Debug].

* [Debug].

* [Debug] used older numpy version

* [Debug] numpy

* [Debug] try numpy version 1.14.6

* [Debug] try different numpy version

* [Debug] Try with latest numpy version

* Set numpy version to 1.14.5

* Add argument for custom logger configuration. First commit, work in progress.

* Minor changes.

* Modify suggested changes [WIP]

* .

* .

* .

* .

* Fix minor details

* Fix travis not recognizing example_config.yaml

* .

* .

* .

* .

* .

* Fix codacy error

* Revert codacy error fixing

* [Debug] experimenting with numpy

* [Debug] try to manually install libgcc

* [Debug] libgcc

* [Debug] libgcc

* [Debug] libgcc

* [Debug] libgcc

* [Debug].

* [Debug].

* [Debug] .

* [Debug].

* [Debug].

* [Debug] used older numpy version

* [Debug] try numpy version 1.14.6

* Delete libgcc_check.sh used for debugging.

* Fix numpy version and remove blank lines

* Fix line length in example_parallel.py

* Fix minor error

* FIX #566: sort ensemble correctly (#567)

* Fix Line length in example_parallel.py

* Fix line length in example_parallel.py

* Fix minor error

* Fix codacy error "parameters differ from overriden 'fit' method"

* Check target type at the beginning of the fitting process. (#506)

* Check target type at the beginning of the fitting process.

* .

* Fixed minor error in uniitest

* .

* Add unittest for target type checking.

* .

* .

* Change datasets used in examples from digits to breast_cancer.

* [Debug] try with numpy version 1.14.5

* [Debug] Check if numpy version 1.14.6 raises error.

* [Debug] try different numpy version

* [Debug] Try with latest numpy version

* Set numpy version to 1.14.5

* Check target type at the beginning of the fitting process.

* .

* Fixed minor error in uniitest

* .

* Add unittest for target type checking.

* .

* .

* [Debug] Check if numpy version 1.14.6 raises error.

* Fix numpy version to 1.14.5

* Add comment to Mock in test_type_of_target

* Fix line length in example_parallel.py

* Fix minor error

* Update test_automl.py

* Add python 3.7to Travis, change python_requirement in setup.py.

* Add solver hyperparameter in MLP classifier example, increase runtime of classifier in example_extend_preprocessing.py

* Change all occurences of master to development in flake8_diff.sh

* numpy requirement is now >=1.9.0<=1.14.5

* Fix requirement inequality mistake

* change initial numpy version to 1.14.5.

* Deploy using travis instead of circle

* FIX error in travis.yml caused by stashing

* Test that deploy works.

* Debugging. Set local_dir to doc/development.

* Done Testing. Finalize the PR.

* Delete circle_install.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants