Skip to content

Commit

Permalink
Remove repacking of R from pkg to dmg
Browse files Browse the repository at this point in the history
The R.munki.recipe previously would encapsulate the downloaded pkg file
into a dmg file without making any other alterations. However, the
source for the dmg file was %RECIPE_CACHE_DIR%/downloads and this
directory often contains not only the current pkg file, but also
old pkg files from previous versions of R. When multiple pkg files are
present, they all end up in the dmg file and makepkginfo gets rather
confused about what version of R is contained in the dmg.

I have removed the pkg to dmg conversion from R.munki.recipe, which
solves the above problem.
  • Loading branch information
William Holtz committed Jul 12, 2018
1 parent deec188 commit 6eeca70
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions R/R.munki.recipe
Expand Up @@ -36,22 +36,11 @@
<string>com.github.homebysix.download.R</string>
<key>Process</key>
<array>
<dict>
<key>Arguments</key>
<dict>
<key>dmg_path</key>
<string>%RECIPE_CACHE_DIR%/%NAME%-%version%.dmg</string>
<key>dmg_root</key>
<string>%RECIPE_CACHE_DIR%/downloads</string>
</dict>
<key>Processor</key>
<string>DmgCreator</string>
</dict>
<dict>
<key>Arguments</key>
<dict>
<key>pkg_path</key>
<string>%dmg_path%</string>
<string>%pathname%</string>
<key>repo_subdirectory</key>
<string>%MUNKI_REPO_SUBDIR%</string>
</dict>
Expand Down

0 comments on commit 6eeca70

Please sign in to comment.