New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-line textDocument/hover #224

Closed
MaskRay opened this Issue Dec 22, 2017 · 3 comments

Comments

4 participants
@MaskRay
Contributor

MaskRay commented Dec 22, 2017

Currently textDocument/hover is implemented via

    @neovim.function("LanguageClient_textDocument_hover")
    @deco_args
    def textDocument_hover(self, uri: str, languageId: str,
........
        echo(info)

# state.py
def echo(message: str) -> None:
    """Echo message."""
    message = escape(message)
    execute_command("echo '{}'".format(message))

For multi-line macro/struct/class declaration and comment support (see cquery-project/cquery#29 for cquery's ongoing support), this UI may be infeasible. We might need to provide an alternative UI (e.g. preview window)

@YaLTeR

This comment has been minimized.

Show comment
Hide comment
@YaLTeR

YaLTeR Dec 23, 2017

Contributor

Maybe it's possible to display the info in a "popup" similar to autocomplete suggestions?

EDIT: this is kinda related to #196

Contributor

YaLTeR commented Dec 23, 2017

Maybe it's possible to display the info in a "popup" similar to autocomplete suggestions?

EDIT: this is kinda related to #196

@stellarhoof

This comment has been minimized.

Show comment
Hide comment
@stellarhoof

stellarhoof Dec 25, 2017

Also, don't use echomsg if possible. It pollutes the messages history.

stellarhoof commented Dec 25, 2017

Also, don't use echomsg if possible. It pollutes the messages history.

@prabirshrestha

This comment has been minimized.

Show comment
Hide comment
@prabirshrestha

prabirshrestha Jan 9, 2018

vim-lsp supports multiline hover. Feel free to port this related commits.

prabirshrestha commented Jan 9, 2018

vim-lsp supports multiline hover. Feel free to port this related commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment