From df3c30ef7398abe1b6f7cfa775c9163c835beb96 Mon Sep 17 00:00:00 2001 From: serenajiang Date: Thu, 9 Jul 2020 11:25:35 -0700 Subject: [PATCH] fix(csv upload): hive params typo (#10273) * fix(csv upload): fix :params typo * fix tests --- superset/db_engine_specs/hive.py | 4 ++-- tests/db_engine_specs/hive_tests.py | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/superset/db_engine_specs/hive.py b/superset/db_engine_specs/hive.py index bb2c43c83d60..4cafaaf2b20e 100644 --- a/superset/db_engine_specs/hive.py +++ b/superset/db_engine_specs/hive.py @@ -140,11 +140,11 @@ def get_create_table_stmt( # pylint: disable=too-many-arguments } if header_line_count is not None and header_line_count >= 0: header_line_count += 1 - tblproperties.append("'skip.header.line.count'=':header_line_count'") + tblproperties.append("'skip.header.line.count'=:header_line_count") params["header_line_count"] = str(header_line_count) if null_values: # hive only supports 1 value for the null format - tblproperties.append("'serialization.null.format'=':null_value'") + tblproperties.append("'serialization.null.format'=:null_value") params["null_value"] = null_values[0] if tblproperties: diff --git a/tests/db_engine_specs/hive_tests.py b/tests/db_engine_specs/hive_tests.py index b272bbb61852..73004a9f3ab7 100644 --- a/tests/db_engine_specs/hive_tests.py +++ b/tests/db_engine_specs/hive_tests.py @@ -181,7 +181,7 @@ def test_get_create_table_stmt() -> None: """CREATE TABLE employee ( eid int, name String, salary String, destination String ) ROW FORMAT DELIMITED FIELDS TERMINATED BY :delim STORED AS TEXTFILE LOCATION :location - tblproperties ('skip.header.line.count'=':header_line_count', 'serialization.null.format'=':null_value')""", + tblproperties ('skip.header.line.count'=:header_line_count, 'serialization.null.format'=:null_value)""", { "delim": ",", "location": "s3a://directory/table", @@ -195,7 +195,7 @@ def test_get_create_table_stmt() -> None: """CREATE TABLE employee ( eid int, name String, salary String, destination String ) ROW FORMAT DELIMITED FIELDS TERMINATED BY :delim STORED AS TEXTFILE LOCATION :location - tblproperties ('skip.header.line.count'=':header_line_count', 'serialization.null.format'=':null_value')""", + tblproperties ('skip.header.line.count'=:header_line_count, 'serialization.null.format'=:null_value)""", { "delim": ",", "location": "s3a://directory/table", @@ -209,7 +209,7 @@ def test_get_create_table_stmt() -> None: """CREATE TABLE employee ( eid int, name String, salary String, destination String ) ROW FORMAT DELIMITED FIELDS TERMINATED BY :delim STORED AS TEXTFILE LOCATION :location - tblproperties ('skip.header.line.count'=':header_line_count', 'serialization.null.format'=':null_value')""", + tblproperties ('skip.header.line.count'=:header_line_count, 'serialization.null.format'=:null_value)""", { "delim": ",", "location": "s3a://directory/table", @@ -231,6 +231,6 @@ def test_get_create_table_stmt() -> None: """CREATE TABLE employee ( eid int, name String, salary String, destination String ) ROW FORMAT DELIMITED FIELDS TERMINATED BY :delim STORED AS TEXTFILE LOCATION :location - tblproperties ('skip.header.line.count'=':header_line_count')""", + tblproperties ('skip.header.line.count'=:header_line_count)""", {"delim": ",", "location": "s3a://directory/table", "header_line_count": "101"}, )