diff --git a/api/admin/client.go b/api/admin/client.go index 21055d66d59..ba00eb2a21f 100644 --- a/api/admin/client.go +++ b/api/admin/client.go @@ -13,7 +13,7 @@ import ( "github.com/ava-labs/avalanchego/utils/rpc" ) -var _ Client = &client{} +var _ Client = (*client)(nil) // Client interface for the Avalanche Platform Info API Endpoint type Client interface { diff --git a/api/auth/auth.go b/api/auth/auth.go index 3b10674a62d..6a38c3362b2 100644 --- a/api/auth/auth.go +++ b/api/auth/auth.go @@ -53,7 +53,7 @@ var ( errNoEndpoints = errors.New("must name at least one endpoint") errTooManyEndpoints = fmt.Errorf("can only name at most %d endpoints", maxEndpoints) - _ Auth = &auth{} + _ Auth = (*auth)(nil) ) type Auth interface { diff --git a/api/health/client.go b/api/health/client.go index 45046ae02f1..59e37f95ce9 100644 --- a/api/health/client.go +++ b/api/health/client.go @@ -10,7 +10,7 @@ import ( "github.com/ava-labs/avalanchego/utils/rpc" ) -var _ Client = &client{} +var _ Client = (*client)(nil) // Client interface for Avalanche Health API Endpoint type Client interface { diff --git a/api/health/health.go b/api/health/health.go index 712fcd55092..32759085fee 100644 --- a/api/health/health.go +++ b/api/health/health.go @@ -13,7 +13,7 @@ import ( "github.com/ava-labs/avalanchego/utils/logging" ) -var _ Health = &health{} +var _ Health = (*health)(nil) // Health defines the full health service interface for registering, reporting // and refreshing health checks. diff --git a/api/info/client.go b/api/info/client.go index 40403fd753f..1a071b115ad 100644 --- a/api/info/client.go +++ b/api/info/client.go @@ -11,7 +11,7 @@ import ( "github.com/ava-labs/avalanchego/vms/platformvm/signer" ) -var _ Client = &client{} +var _ Client = (*client)(nil) // Client interface for an Info API Client type Client interface { diff --git a/api/ipcs/client.go b/api/ipcs/client.go index 14b62062405..a317e022559 100644 --- a/api/ipcs/client.go +++ b/api/ipcs/client.go @@ -11,7 +11,7 @@ import ( "github.com/ava-labs/avalanchego/utils/rpc" ) -var _ Client = &client{} +var _ Client = (*client)(nil) // Client interface for interacting with the IPCS endpoint type Client interface { diff --git a/api/keystore/blockchain_keystore.go b/api/keystore/blockchain_keystore.go index 03f0bccf2af..843b168ea77 100644 --- a/api/keystore/blockchain_keystore.go +++ b/api/keystore/blockchain_keystore.go @@ -12,7 +12,7 @@ import ( "github.com/ava-labs/avalanchego/utils/logging" ) -var _ BlockchainKeystore = &blockchainKeystore{} +var _ BlockchainKeystore = (*blockchainKeystore)(nil) type BlockchainKeystore interface { // Get a database that is able to read and write unencrypted values from the diff --git a/api/keystore/client.go b/api/keystore/client.go index d2ff912d6a0..a586f6f28bc 100644 --- a/api/keystore/client.go +++ b/api/keystore/client.go @@ -11,7 +11,7 @@ import ( "github.com/ava-labs/avalanchego/utils/rpc" ) -var _ Client = &client{} +var _ Client = (*client)(nil) // Client interface for Avalanche Keystore API Endpoint type Client interface { diff --git a/api/keystore/gkeystore/keystore_client.go b/api/keystore/gkeystore/keystore_client.go index 7902b73e072..b8e52225122 100644 --- a/api/keystore/gkeystore/keystore_client.go +++ b/api/keystore/gkeystore/keystore_client.go @@ -16,7 +16,7 @@ import ( rpcdbpb "github.com/ava-labs/avalanchego/proto/pb/rpcdb" ) -var _ keystore.BlockchainKeystore = &Client{} +var _ keystore.BlockchainKeystore = (*Client)(nil) // Client is a snow.Keystore that talks over RPC. type Client struct { diff --git a/api/keystore/gkeystore/keystore_server.go b/api/keystore/gkeystore/keystore_server.go index 66e214e6299..629e80a36c4 100644 --- a/api/keystore/gkeystore/keystore_server.go +++ b/api/keystore/gkeystore/keystore_server.go @@ -17,7 +17,7 @@ import ( rpcdbpb "github.com/ava-labs/avalanchego/proto/pb/rpcdb" ) -var _ keystorepb.KeystoreServer = &Server{} +var _ keystorepb.KeystoreServer = (*Server)(nil) // Server is a snow.Keystore that is managed over RPC. type Server struct { diff --git a/api/keystore/keystore.go b/api/keystore/keystore.go index dbdc6425629..ea8c871848b 100644 --- a/api/keystore/keystore.go +++ b/api/keystore/keystore.go @@ -34,7 +34,7 @@ var ( usersPrefix = []byte("users") bcsPrefix = []byte("bcs") - _ Keystore = &keystore{} + _ Keystore = (*keystore)(nil) ) type Keystore interface { diff --git a/api/metrics/multi_gatherer.go b/api/metrics/multi_gatherer.go index a9c9c58ee77..3ca8fb2fdb6 100644 --- a/api/metrics/multi_gatherer.go +++ b/api/metrics/multi_gatherer.go @@ -17,7 +17,7 @@ import ( var ( errDuplicatedPrefix = errors.New("duplicated prefix") - _ MultiGatherer = &multiGatherer{} + _ MultiGatherer = (*multiGatherer)(nil) ) // MultiGatherer extends the Gatherer interface by allowing additional gatherers diff --git a/api/metrics/optional_gatherer.go b/api/metrics/optional_gatherer.go index 2355257a8cb..4cb5d6f5bbf 100644 --- a/api/metrics/optional_gatherer.go +++ b/api/metrics/optional_gatherer.go @@ -15,7 +15,7 @@ import ( var ( errDuplicatedRegister = errors.New("duplicated register") - _ OptionalGatherer = &optionalGatherer{} + _ OptionalGatherer = (*optionalGatherer)(nil) ) // OptionalGatherer extends the Gatherer interface by allowing the optional diff --git a/api/server/server.go b/api/server/server.go index fb697c573dc..d7e17a2cfbe 100644 --- a/api/server/server.go +++ b/api/server/server.go @@ -38,7 +38,7 @@ var ( errUnknownLockOption = errors.New("invalid lock options") _ PathAdder = readPathAdder{} - _ Server = &server{} + _ Server = (*server)(nil) ) type PathAdder interface { diff --git a/app/plugin/plugin.go b/app/plugin/plugin.go index 3706169b479..15ab9bc4830 100644 --- a/app/plugin/plugin.go +++ b/app/plugin/plugin.go @@ -29,8 +29,8 @@ var ( Name: &appPlugin{}, } - _ plugin.Plugin = &appPlugin{} - _ plugin.GRPCPlugin = &appPlugin{} + _ plugin.Plugin = (*appPlugin)(nil) + _ plugin.GRPCPlugin = (*appPlugin)(nil) ) type appPlugin struct { diff --git a/app/process/process.go b/app/process/process.go index ee78d20fc2c..8da3dd6a791 100644 --- a/app/process/process.go +++ b/app/process/process.go @@ -31,7 +31,7 @@ var ( stakingPortName = fmt.Sprintf("%s-staking", constants.AppName) httpPortName = fmt.Sprintf("%s-http", constants.AppName) - _ app.App = &process{} + _ app.App = (*process)(nil) ) // process is a wrapper around a node that runs in this process diff --git a/cache/lru_cache.go b/cache/lru_cache.go index 460da6d2707..b186df86440 100644 --- a/cache/lru_cache.go +++ b/cache/lru_cache.go @@ -10,7 +10,7 @@ import ( const minCacheSize = 32 -var _ Cacher = &LRU{} +var _ Cacher = (*LRU)(nil) type entry struct { Key interface{} diff --git a/cache/metercacher/cache.go b/cache/metercacher/cache.go index c8b809c323e..7a8b7106651 100644 --- a/cache/metercacher/cache.go +++ b/cache/metercacher/cache.go @@ -10,7 +10,7 @@ import ( "github.com/ava-labs/avalanchego/utils/timer/mockable" ) -var _ cache.Cacher = &Cache{} +var _ cache.Cacher = (*Cache)(nil) type Cache struct { metrics diff --git a/cache/unique_cache.go b/cache/unique_cache.go index 59a26ffe865..a825a6e8f68 100644 --- a/cache/unique_cache.go +++ b/cache/unique_cache.go @@ -8,7 +8,7 @@ import ( "sync" ) -var _ Deduplicator = &EvictableLRU{} +var _ Deduplicator = (*EvictableLRU)(nil) // EvictableLRU is an LRU cache that notifies the objects when they are evicted. type EvictableLRU struct { diff --git a/chains/atomic/gsharedmemory/shared_memory_client.go b/chains/atomic/gsharedmemory/shared_memory_client.go index 40e419fa959..5d37a22f434 100644 --- a/chains/atomic/gsharedmemory/shared_memory_client.go +++ b/chains/atomic/gsharedmemory/shared_memory_client.go @@ -24,7 +24,7 @@ const ( baseElementSize = 8 // bytes ) -var _ atomic.SharedMemory = &Client{} +var _ atomic.SharedMemory = (*Client)(nil) // Client is atomic.SharedMemory that talks over RPC. type Client struct { diff --git a/chains/atomic/gsharedmemory/shared_memory_server.go b/chains/atomic/gsharedmemory/shared_memory_server.go index 0725e7e6c6f..0bb72bdd891 100644 --- a/chains/atomic/gsharedmemory/shared_memory_server.go +++ b/chains/atomic/gsharedmemory/shared_memory_server.go @@ -14,7 +14,7 @@ import ( sharedmemorypb "github.com/ava-labs/avalanchego/proto/pb/sharedmemory" ) -var _ sharedmemorypb.SharedMemoryServer = &Server{} +var _ sharedmemorypb.SharedMemoryServer = (*Server)(nil) // Server is shared memory that is managed over RPC. type Server struct { diff --git a/chains/atomic/shared_memory.go b/chains/atomic/shared_memory.go index e77f8c10440..e4c3d24c6c1 100644 --- a/chains/atomic/shared_memory.go +++ b/chains/atomic/shared_memory.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/ids" ) -var _ SharedMemory = &sharedMemory{} +var _ SharedMemory = (*sharedMemory)(nil) type Requests struct { RemoveRequests [][]byte `serialize:"true"` diff --git a/chains/manager.go b/chains/manager.go index 92d99163b06..c2cf153ee02 100644 --- a/chains/manager.go +++ b/chains/manager.go @@ -72,7 +72,7 @@ var ( errCreatePlatformVM = errors.New("attempted to create a chain running the PlatformVM") errNotBootstrapped = errors.New("chains not bootstrapped") - _ Manager = &manager{} + _ Manager = (*manager)(nil) ) // Manager manages the chains running on this node. diff --git a/chains/mock_manager.go b/chains/mock_manager.go index 4e2c3c3ad00..24ab1285668 100644 --- a/chains/mock_manager.go +++ b/chains/mock_manager.go @@ -8,7 +8,7 @@ import ( "github.com/ava-labs/avalanchego/snow/networking/router" ) -var _ Manager = MockManager{} +var _ Manager = (*MockManager)(nil) // MockManager implements Manager but does nothing. Always returns nil error. // To be used only in tests diff --git a/chains/subnet.go b/chains/subnet.go index 2299448f5db..ba4db1ccc50 100644 --- a/chains/subnet.go +++ b/chains/subnet.go @@ -12,7 +12,7 @@ import ( "github.com/ava-labs/avalanchego/snow/networking/sender" ) -var _ Subnet = &subnet{} +var _ Subnet = (*subnet)(nil) // Subnet keeps track of the currently bootstrapping chains in a subnet. If no // chains in the subnet are currently bootstrapping, the subnet is considered diff --git a/codec/hierarchycodec/codec.go b/codec/hierarchycodec/codec.go index 481cd6bbbe5..69c3443e5e3 100644 --- a/codec/hierarchycodec/codec.go +++ b/codec/hierarchycodec/codec.go @@ -19,10 +19,10 @@ const ( ) var ( - _ Codec = &hierarchyCodec{} - _ codec.Codec = &hierarchyCodec{} - _ codec.Registry = &hierarchyCodec{} - _ codec.GeneralCodec = &hierarchyCodec{} + _ Codec = (*hierarchyCodec)(nil) + _ codec.Codec = (*hierarchyCodec)(nil) + _ codec.Registry = (*hierarchyCodec)(nil) + _ codec.GeneralCodec = (*hierarchyCodec)(nil) ) // Codec marshals and unmarshals diff --git a/codec/linearcodec/codec.go b/codec/linearcodec/codec.go index 1a94c78b14d..14aca2e4e2a 100644 --- a/codec/linearcodec/codec.go +++ b/codec/linearcodec/codec.go @@ -19,10 +19,10 @@ const ( ) var ( - _ Codec = &linearCodec{} - _ codec.Codec = &linearCodec{} - _ codec.Registry = &linearCodec{} - _ codec.GeneralCodec = &linearCodec{} + _ Codec = (*linearCodec)(nil) + _ codec.Codec = (*linearCodec)(nil) + _ codec.Registry = (*linearCodec)(nil) + _ codec.GeneralCodec = (*linearCodec)(nil) ) // Codec marshals and unmarshals diff --git a/codec/manager.go b/codec/manager.go index e9a91323565..536a508610d 100644 --- a/codec/manager.go +++ b/codec/manager.go @@ -31,7 +31,7 @@ var ( errDuplicatedVersion = errors.New("duplicated codec version") ) -var _ Manager = &manager{} +var _ Manager = (*manager)(nil) // Manager describes the functionality for managing codec versions. type Manager interface { diff --git a/codec/reflectcodec/struct_fielder.go b/codec/reflectcodec/struct_fielder.go index 49e5d860910..c4e0f05d1ff 100644 --- a/codec/reflectcodec/struct_fielder.go +++ b/codec/reflectcodec/struct_fielder.go @@ -18,7 +18,7 @@ const ( TagValue = "true" ) -var _ StructFielder = &structFielder{} +var _ StructFielder = (*structFielder)(nil) type FieldDesc struct { Index int diff --git a/codec/reflectcodec/type_codec.go b/codec/reflectcodec/type_codec.go index 710060aa6cc..704433197bf 100644 --- a/codec/reflectcodec/type_codec.go +++ b/codec/reflectcodec/type_codec.go @@ -27,7 +27,7 @@ var ( errExtraSpace = errors.New("trailing buffer space") ) -var _ codec.Codec = &genericCodec{} +var _ codec.Codec = (*genericCodec)(nil) type TypeCodec interface { // UnpackPrefix unpacks the prefix of an interface from the given packer. diff --git a/codec/test_codec.go b/codec/test_codec.go index f0a40c63a24..a8224b6f521 100644 --- a/codec/test_codec.go +++ b/codec/test_codec.go @@ -49,8 +49,8 @@ var MultipleTagsTests = []func(c GeneralCodec, t testing.TB){ // for the sake of testing var ( - _ Foo = &MyInnerStruct{} - _ Foo = &MyInnerStruct2{} + _ Foo = (*MyInnerStruct)(nil) + _ Foo = (*MyInnerStruct2)(nil) ) type Foo interface { diff --git a/database/corruptabledb/db.go b/database/corruptabledb/db.go index d8f04024fb9..b2439496d0c 100644 --- a/database/corruptabledb/db.go +++ b/database/corruptabledb/db.go @@ -11,8 +11,8 @@ import ( ) var ( - _ database.Database = &Database{} - _ database.Batch = &batch{} + _ database.Database = (*Database)(nil) + _ database.Batch = (*batch)(nil) ) // CorruptableDB is a wrapper around Database diff --git a/database/encdb/db.go b/database/encdb/db.go index d0db1ae1826..41596b08778 100644 --- a/database/encdb/db.go +++ b/database/encdb/db.go @@ -23,9 +23,9 @@ const ( ) var ( - _ database.Database = &Database{} - _ database.Batch = &batch{} - _ database.Iterator = &iterator{} + _ database.Database = (*Database)(nil) + _ database.Batch = (*batch)(nil) + _ database.Iterator = (*iterator)(nil) ) // Database encrypts all values that are provided diff --git a/database/leveldb/db.go b/database/leveldb/db.go index 7433abf7748..d8f49903d84 100644 --- a/database/leveldb/db.go +++ b/database/leveldb/db.go @@ -63,9 +63,9 @@ const ( ) var ( - _ database.Database = &Database{} - _ database.Batch = &batch{} - _ database.Iterator = &iter{} + _ database.Database = (*Database)(nil) + _ database.Batch = (*batch)(nil) + _ database.Iterator = (*iter)(nil) ) // Database is a persistent key-value store. Apart from basic data storage diff --git a/database/linkeddb/linkeddb.go b/database/linkeddb/linkeddb.go index 2879527b6b3..5e5f0112f24 100644 --- a/database/linkeddb/linkeddb.go +++ b/database/linkeddb/linkeddb.go @@ -18,8 +18,8 @@ const ( var ( headKey = []byte{0x01} - _ LinkedDB = &linkedDB{} - _ database.Iterator = &iterator{} + _ LinkedDB = (*linkedDB)(nil) + _ database.Iterator = (*iterator)(nil) ) // LinkedDB provides a key value interface while allowing iteration. diff --git a/database/manager/manager.go b/database/manager/manager.go index c2459052b43..f7696daaee6 100644 --- a/database/manager/manager.go +++ b/database/manager/manager.go @@ -29,7 +29,7 @@ var ( errNoDBs = errors.New("no dbs given") ) -var _ Manager = &manager{} +var _ Manager = (*manager)(nil) type Manager interface { // Current returns the database with the current database version. diff --git a/database/memdb/db.go b/database/memdb/db.go index 62ed14412b0..d6521efb497 100644 --- a/database/memdb/db.go +++ b/database/memdb/db.go @@ -22,9 +22,9 @@ const ( ) var ( - _ database.Database = &Database{} - _ database.Batch = &batch{} - _ database.Iterator = &iterator{} + _ database.Database = (*Database)(nil) + _ database.Batch = (*batch)(nil) + _ database.Iterator = (*iterator)(nil) ) // Database is an ephemeral key-value store that implements the Database diff --git a/database/meterdb/db.go b/database/meterdb/db.go index f3d7d74e005..6bb5feef2a3 100644 --- a/database/meterdb/db.go +++ b/database/meterdb/db.go @@ -11,9 +11,9 @@ import ( ) var ( - _ database.Database = &Database{} - _ database.Batch = &batch{} - _ database.Iterator = &iterator{} + _ database.Database = (*Database)(nil) + _ database.Batch = (*batch)(nil) + _ database.Iterator = (*iterator)(nil) ) // Database tracks the amount of time each operation takes and how many bytes diff --git a/database/mockdb/db.go b/database/mockdb/db.go index 17ce1bb7e12..c10f6e0971a 100644 --- a/database/mockdb/db.go +++ b/database/mockdb/db.go @@ -12,7 +12,7 @@ import ( var ( errNoFunction = errors.New("user didn't specify what value(s) return") - _ database.Database = &Database{} + _ database.Database = (*Database)(nil) ) // Database is a mock database meant to be used in tests. diff --git a/database/nodb/db.go b/database/nodb/db.go index 24d71e83492..360f2e2b356 100644 --- a/database/nodb/db.go +++ b/database/nodb/db.go @@ -8,9 +8,9 @@ import ( ) var ( - _ database.Database = &Database{} - _ database.Batch = &Batch{} - _ database.Iterator = &Iterator{} + _ database.Database = (*Database)(nil) + _ database.Batch = (*Batch)(nil) + _ database.Iterator = (*Iterator)(nil) ) // Database is a lightning fast key value store with probabilistic operations. diff --git a/database/prefixdb/db.go b/database/prefixdb/db.go index 65f9fa8cf5f..8b2bce31555 100644 --- a/database/prefixdb/db.go +++ b/database/prefixdb/db.go @@ -17,9 +17,9 @@ const ( ) var ( - _ database.Database = &Database{} - _ database.Batch = &batch{} - _ database.Iterator = &iterator{} + _ database.Database = (*Database)(nil) + _ database.Batch = (*batch)(nil) + _ database.Iterator = (*iterator)(nil) ) // Database partitions a database into a sub-database by prefixing all keys with diff --git a/database/rpcdb/db_client.go b/database/rpcdb/db_client.go index f49380acc88..75abe087643 100644 --- a/database/rpcdb/db_client.go +++ b/database/rpcdb/db_client.go @@ -28,9 +28,9 @@ const ( ) var ( - _ database.Database = &DatabaseClient{} - _ database.Batch = &batch{} - _ database.Iterator = &iterator{} + _ database.Database = (*DatabaseClient)(nil) + _ database.Batch = (*batch)(nil) + _ database.Iterator = (*iterator)(nil) ) // DatabaseClient is an implementation of database that talks over RPC. diff --git a/database/versiondb/db.go b/database/versiondb/db.go index a9f5a3a3982..a208f23cea6 100644 --- a/database/versiondb/db.go +++ b/database/versiondb/db.go @@ -19,10 +19,10 @@ const ( ) var ( - _ database.Database = &Database{} - _ Commitable = &Database{} - _ database.Batch = &batch{} - _ database.Iterator = &iterator{} + _ database.Database = (*Database)(nil) + _ Commitable = (*Database)(nil) + _ database.Batch = (*batch)(nil) + _ database.Iterator = (*iterator)(nil) ) // Commitable defines the interface that specifies that something may be diff --git a/ids/galiasreader/alias_reader_client.go b/ids/galiasreader/alias_reader_client.go index 0f175557c45..280da371445 100644 --- a/ids/galiasreader/alias_reader_client.go +++ b/ids/galiasreader/alias_reader_client.go @@ -11,7 +11,7 @@ import ( aliasreaderpb "github.com/ava-labs/avalanchego/proto/pb/aliasreader" ) -var _ ids.AliaserReader = &Client{} +var _ ids.AliaserReader = (*Client)(nil) // Client implements alias lookups that talk over RPC. type Client struct { diff --git a/ids/galiasreader/alias_reader_server.go b/ids/galiasreader/alias_reader_server.go index 0bce392f7eb..f5269944dd6 100644 --- a/ids/galiasreader/alias_reader_server.go +++ b/ids/galiasreader/alias_reader_server.go @@ -11,7 +11,7 @@ import ( aliasreaderpb "github.com/ava-labs/avalanchego/proto/pb/aliasreader" ) -var _ aliasreaderpb.AliasReaderServer = &Server{} +var _ aliasreaderpb.AliasReaderServer = (*Server)(nil) // Server enables alias lookups over RPC. type Server struct { diff --git a/indexer/client.go b/indexer/client.go index af9e8438b4f..cc7b48adfc6 100644 --- a/indexer/client.go +++ b/indexer/client.go @@ -13,7 +13,7 @@ import ( "github.com/ava-labs/avalanchego/utils/rpc" ) -var _ Client = &client{} +var _ Client = (*client)(nil) // Client interface for Avalanche Indexer API Endpoint type Client interface { diff --git a/indexer/index.go b/indexer/index.go index 3b658390683..a1036d47b75 100644 --- a/indexer/index.go +++ b/indexer/index.go @@ -37,7 +37,7 @@ var ( errNoneAccepted = errors.New("no containers have been accepted") errNumToFetchZero = fmt.Errorf("numToFetch must be in [1,%d]", MaxFetchedByRange) - _ Index = &index{} + _ Index = (*index)(nil) ) // Index indexes containers in their order of acceptance diff --git a/indexer/indexer.go b/indexer/indexer.go index ad15e5b1332..7a2f2f0ba53 100644 --- a/indexer/indexer.go +++ b/indexer/indexer.go @@ -52,7 +52,7 @@ var ( previouslyIndexedPrefix = byte(0x05) hasRunKey = []byte{0x07} - _ Indexer = &indexer{} + _ Indexer = (*indexer)(nil) ) // Config for an indexer diff --git a/indexer/indexer_test.go b/indexer/indexer_test.go index eb4422e9e84..75700644960 100644 --- a/indexer/indexer_test.go +++ b/indexer/indexer_test.go @@ -31,7 +31,7 @@ import ( smblockmocks "github.com/ava-labs/avalanchego/snow/engine/snowman/block/mocks" ) -var _ server.PathAdder = &apiServerMock{} +var _ server.PathAdder = (*apiServerMock)(nil) type apiServerMock struct { timesCalled int diff --git a/ipcs/eventsocket.go b/ipcs/eventsocket.go index 0892b7d3a0a..a4c0a3f27d0 100644 --- a/ipcs/eventsocket.go +++ b/ipcs/eventsocket.go @@ -15,7 +15,7 @@ import ( "github.com/ava-labs/avalanchego/utils/wrappers" ) -var _ snow.Acceptor = &EventSockets{} +var _ snow.Acceptor = (*EventSockets)(nil) // EventSockets is a set of named eventSockets type EventSockets struct { diff --git a/message/creator.go b/message/creator.go index f5659134869..3db3809cc2e 100644 --- a/message/creator.go +++ b/message/creator.go @@ -12,7 +12,7 @@ import ( "github.com/ava-labs/avalanchego/utils/constants" ) -var _ Creator = &creator{} +var _ Creator = (*creator)(nil) type Creator interface { OutboundMsgBuilder diff --git a/message/inbound_msg_builder.go b/message/inbound_msg_builder.go index 06c307b9ca7..7c164becae2 100644 --- a/message/inbound_msg_builder.go +++ b/message/inbound_msg_builder.go @@ -10,7 +10,7 @@ import ( "github.com/ava-labs/avalanchego/proto/pb/p2p" ) -var _ InboundMsgBuilder = &inMsgBuilder{} +var _ InboundMsgBuilder = (*inMsgBuilder)(nil) type InboundMsgBuilder interface { SetTime(t time.Time) // useful in UTs diff --git a/message/internal_msg_builder.go b/message/internal_msg_builder.go index 037d96afa94..3bfa5cd471b 100644 --- a/message/internal_msg_builder.go +++ b/message/internal_msg_builder.go @@ -15,7 +15,7 @@ import ( var ( _ InternalMsgBuilder = internalMsgBuilder{} - _ InboundMessage = &internalMessage{} + _ InboundMessage = (*internalMessage)(nil) ) type InternalMsgBuilder interface { diff --git a/message/messages.go b/message/messages.go index 362d5af5f12..f15b98387a5 100644 --- a/message/messages.go +++ b/message/messages.go @@ -25,8 +25,8 @@ import ( ) var ( - _ InboundMessage = &inboundExternalMessage{} - _ OutboundMessage = &outboundMessage{} + _ InboundMessage = (*inboundExternalMessage)(nil) + _ OutboundMessage = (*outboundMessage)(nil) errUnknownMessageTypeForOp = errors.New("unknown message type for Op") errUnexpectedCompressedOp = errors.New("unexpected compressed Op") diff --git a/message/outbound_msg_builder_proto.go b/message/outbound_msg_builder_proto.go index ec7c35a1159..fbefc07475e 100644 --- a/message/outbound_msg_builder_proto.go +++ b/message/outbound_msg_builder_proto.go @@ -12,7 +12,7 @@ import ( p2ppb "github.com/ava-labs/avalanchego/proto/pb/p2p" ) -var _ OutboundMsgBuilder = &outMsgBuilder{} +var _ OutboundMsgBuilder = (*outMsgBuilder)(nil) type outMsgBuilder struct { compress bool // set to "true" if compression is enabled diff --git a/nat/no_router.go b/nat/no_router.go index 32a089dd88a..f29c73d3b88 100644 --- a/nat/no_router.go +++ b/nat/no_router.go @@ -12,7 +12,7 @@ import ( var ( errNoRouterCantMapPorts = errors.New("can't map ports without a known router") errFetchingIP = errors.New("getting outbound IP failed") - _ Router = &noRouter{} + _ Router = (*noRouter)(nil) ) const googleDNSServer = "8.8.8.8:80" diff --git a/nat/pmp.go b/nat/pmp.go index 57df17b790b..92a069d2fde 100644 --- a/nat/pmp.go +++ b/nat/pmp.go @@ -18,7 +18,7 @@ var ( errInvalidLifetime = errors.New("invalid mapping duration range") pmpClientTimeout = 500 * time.Millisecond - _ Router = &pmpRouter{} + _ Router = (*pmpRouter)(nil) ) // pmpRouter adapts the NAT-PMP protocol implementation so it conforms to the diff --git a/nat/upnp.go b/nat/upnp.go index 93fcf034aa9..5e65be46f4f 100644 --- a/nat/upnp.go +++ b/nat/upnp.go @@ -18,7 +18,7 @@ const ( soapRequestTimeout = 10 * time.Second ) -var _ Router = &upnpRouter{} +var _ Router = (*upnpRouter)(nil) // upnpClient is the interface used by goupnp for their client implementations type upnpClient interface { diff --git a/network/conn_test.go b/network/conn_test.go index ad97c7590bf..5175aafd6e6 100644 --- a/network/conn_test.go +++ b/network/conn_test.go @@ -7,7 +7,7 @@ import ( "net" ) -var _ net.Conn = &testConn{} +var _ net.Conn = (*testConn)(nil) type testConn struct { net.Conn diff --git a/network/dialer/dialer.go b/network/dialer/dialer.go index 358d18525af..85bfdc6c6e6 100644 --- a/network/dialer/dialer.go +++ b/network/dialer/dialer.go @@ -16,7 +16,7 @@ import ( "github.com/ava-labs/avalanchego/utils/logging" ) -var _ Dialer = &dialer{} +var _ Dialer = (*dialer)(nil) // Dialer attempts to create a connection with the provided IP/port pair type Dialer interface { diff --git a/network/dialer_test.go b/network/dialer_test.go index f3ca1c008a6..89975e87640 100644 --- a/network/dialer_test.go +++ b/network/dialer_test.go @@ -15,7 +15,7 @@ import ( var ( errRefused = errors.New("connection refused") - _ dialer.Dialer = &testDialer{} + _ dialer.Dialer = (*testDialer)(nil) ) type testDialer struct { diff --git a/network/handler_test.go b/network/handler_test.go index 5879edc5107..2c9698b8aff 100644 --- a/network/handler_test.go +++ b/network/handler_test.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/version" ) -var _ router.ExternalHandler = &testHandler{} +var _ router.ExternalHandler = (*testHandler)(nil) type testHandler struct { router.InboundHandler diff --git a/network/listener_test.go b/network/listener_test.go index 1b8b78d957c..69b7c43001b 100644 --- a/network/listener_test.go +++ b/network/listener_test.go @@ -13,7 +13,7 @@ import ( var ( errClosed = errors.New("closed") - _ net.Listener = &testListener{} + _ net.Listener = (*testListener)(nil) ) type testListener struct { diff --git a/network/network.go b/network/network.go index f1ec1b22d20..9f69f75c55d 100644 --- a/network/network.go +++ b/network/network.go @@ -44,8 +44,8 @@ const ( ) var ( - _ sender.ExternalSender = &network{} - _ Network = &network{} + _ sender.ExternalSender = (*network)(nil) + _ Network = (*network)(nil) errNoPrimaryValidators = errors.New("no default subnet validators") ) diff --git a/network/peer/message_queue.go b/network/peer/message_queue.go index 9b3690e135a..201c74fb047 100644 --- a/network/peer/message_queue.go +++ b/network/peer/message_queue.go @@ -19,8 +19,8 @@ import ( const initialQueueSize = 64 var ( - _ MessageQueue = &throttledMessageQueue{} - _ MessageQueue = &blockingMessageQueue{} + _ MessageQueue = (*throttledMessageQueue)(nil) + _ MessageQueue = (*blockingMessageQueue)(nil) ) type SendFailedCallback interface { diff --git a/network/peer/peer.go b/network/peer/peer.go index b24c64faf03..9ee96dddf1b 100644 --- a/network/peer/peer.go +++ b/network/peer/peer.go @@ -30,7 +30,7 @@ import ( var ( errClosed = errors.New("closed") - _ Peer = &peer{} + _ Peer = (*peer)(nil) ) // Peer encapsulates all of the functionality required to send and receive diff --git a/network/peer/set.go b/network/peer/set.go index c3c3904e02c..5722c709a67 100644 --- a/network/peer/set.go +++ b/network/peer/set.go @@ -8,7 +8,7 @@ import ( "github.com/ava-labs/avalanchego/utils/sampler" ) -var _ Set = &set{} +var _ Set = (*set)(nil) func NoPrecondition(Peer) bool { return true } diff --git a/network/peer/test_network.go b/network/peer/test_network.go index c55b1f0089f..12ec29da9f4 100644 --- a/network/peer/test_network.go +++ b/network/peer/test_network.go @@ -13,7 +13,7 @@ import ( "github.com/ava-labs/avalanchego/version" ) -var _ Network = &testNetwork{} +var _ Network = (*testNetwork)(nil) // testNetwork is a network definition for a TestPeer type testNetwork struct { diff --git a/network/peer/upgrader.go b/network/peer/upgrader.go index 3428e58726e..360f311fae5 100644 --- a/network/peer/upgrader.go +++ b/network/peer/upgrader.go @@ -15,8 +15,8 @@ import ( var ( errNoCert = errors.New("tls handshake finished with no peer certificate") - _ Upgrader = &tlsServerUpgrader{} - _ Upgrader = &tlsClientUpgrader{} + _ Upgrader = (*tlsServerUpgrader)(nil) + _ Upgrader = (*tlsClientUpgrader)(nil) ) type Upgrader interface { diff --git a/network/throttling/bandwidth_throttler.go b/network/throttling/bandwidth_throttler.go index f7d2dfa8022..ff0da45c070 100644 --- a/network/throttling/bandwidth_throttler.go +++ b/network/throttling/bandwidth_throttler.go @@ -20,7 +20,7 @@ import ( "github.com/ava-labs/avalanchego/utils/wrappers" ) -var _ bandwidthThrottler = &bandwidthThrottlerImpl{} +var _ bandwidthThrottler = (*bandwidthThrottlerImpl)(nil) // Returns a bandwidth throttler that uses a token bucket // model, where each token is 1 byte, to rate-limit bandwidth usage. diff --git a/network/throttling/dial_throttler.go b/network/throttling/dial_throttler.go index 7740fca598e..5a83ab3e240 100644 --- a/network/throttling/dial_throttler.go +++ b/network/throttling/dial_throttler.go @@ -10,8 +10,8 @@ import ( ) var ( - _ DialThrottler = &dialThrottler{} - _ DialThrottler = &noDialThrottler{} + _ DialThrottler = (*dialThrottler)(nil) + _ DialThrottler = (*noDialThrottler)(nil) ) type DialThrottler interface { diff --git a/network/throttling/inbound_conn_throttler.go b/network/throttling/inbound_conn_throttler.go index ec8decc1945..671430477aa 100644 --- a/network/throttling/inbound_conn_throttler.go +++ b/network/throttling/inbound_conn_throttler.go @@ -10,7 +10,7 @@ import ( "golang.org/x/time/rate" ) -var _ net.Listener = &throttledListener{} +var _ net.Listener = (*throttledListener)(nil) // Wraps [listener] and returns a net.Listener that will accept at most // [maxConnsPerSec] connections per second. diff --git a/network/throttling/inbound_conn_throttler_test.go b/network/throttling/inbound_conn_throttler_test.go index e3d7b2d7d35..a98ae0952bb 100644 --- a/network/throttling/inbound_conn_throttler_test.go +++ b/network/throttling/inbound_conn_throttler_test.go @@ -10,7 +10,7 @@ import ( "github.com/stretchr/testify/require" ) -var _ net.Listener = &MockListener{} +var _ net.Listener = (*MockListener)(nil) type MockListener struct { t *testing.T diff --git a/network/throttling/inbound_conn_upgrade_throttler.go b/network/throttling/inbound_conn_upgrade_throttler.go index 2150eb83f5e..28d345614f0 100644 --- a/network/throttling/inbound_conn_upgrade_throttler.go +++ b/network/throttling/inbound_conn_upgrade_throttler.go @@ -13,8 +13,8 @@ import ( ) var ( - _ InboundConnUpgradeThrottler = &inboundConnUpgradeThrottler{} - _ InboundConnUpgradeThrottler = &noInboundConnUpgradeThrottler{} + _ InboundConnUpgradeThrottler = (*inboundConnUpgradeThrottler)(nil) + _ InboundConnUpgradeThrottler = (*noInboundConnUpgradeThrottler)(nil) ) // InboundConnUpgradeThrottler returns whether we should upgrade an inbound connection from IP [ipStr]. diff --git a/network/throttling/inbound_msg_throttler.go b/network/throttling/inbound_msg_throttler.go index fded1b3a755..3b4a793df57 100644 --- a/network/throttling/inbound_msg_throttler.go +++ b/network/throttling/inbound_msg_throttler.go @@ -15,7 +15,7 @@ import ( "github.com/ava-labs/avalanchego/utils/logging" ) -var _ InboundMsgThrottler = &inboundMsgThrottler{} +var _ InboundMsgThrottler = (*inboundMsgThrottler)(nil) // InboundMsgThrottler rate-limits inbound messages from the network. type InboundMsgThrottler interface { diff --git a/network/throttling/inbound_resource_throttler.go b/network/throttling/inbound_resource_throttler.go index 4d9c9abcab2..d20374c8fc0 100644 --- a/network/throttling/inbound_resource_throttler.go +++ b/network/throttling/inbound_resource_throttler.go @@ -21,7 +21,7 @@ import ( const epsilon = time.Millisecond var ( - _ SystemThrottler = &systemThrottler{} + _ SystemThrottler = (*systemThrottler)(nil) _ SystemThrottler = noSystemThrottler{} ) diff --git a/network/throttling/no_inbound_msg_throttler.go b/network/throttling/no_inbound_msg_throttler.go index 046b2d24fba..167c85565a1 100644 --- a/network/throttling/no_inbound_msg_throttler.go +++ b/network/throttling/no_inbound_msg_throttler.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/ids" ) -var _ InboundMsgThrottler = &noInboundMsgThrottler{} +var _ InboundMsgThrottler = (*noInboundMsgThrottler)(nil) // Returns an InboundMsgThrottler where Acquire() always returns immediately. func NewNoInboundThrottler() InboundMsgThrottler { diff --git a/network/throttling/outbound_msg_throttler.go b/network/throttling/outbound_msg_throttler.go index 6d8c21aa67e..d6bc3de7b44 100644 --- a/network/throttling/outbound_msg_throttler.go +++ b/network/throttling/outbound_msg_throttler.go @@ -15,8 +15,8 @@ import ( ) var ( - _ OutboundMsgThrottler = &outboundMsgThrottler{} - _ OutboundMsgThrottler = &noOutboundMsgThrottler{} + _ OutboundMsgThrottler = (*outboundMsgThrottler)(nil) + _ OutboundMsgThrottler = (*noOutboundMsgThrottler)(nil) ) // Rate-limits outgoing messages diff --git a/pubsub/connection.go b/pubsub/connection.go index a3e71859aef..3ba6edc2bf1 100644 --- a/pubsub/connection.go +++ b/pubsub/connection.go @@ -22,7 +22,7 @@ var ( ErrAddressLimit = errors.New("address limit exceeded") ErrInvalidFilterParam = errors.New("invalid bloom filter params") ErrInvalidCommand = errors.New("invalid command") - _ Filter = &connection{} + _ Filter = (*connection)(nil) ) type Filter interface { diff --git a/snow/acceptor.go b/snow/acceptor.go index 54dbc20b64a..13b39d9c60d 100644 --- a/snow/acceptor.go +++ b/snow/acceptor.go @@ -15,10 +15,10 @@ import ( var ( _ Acceptor = noOpAcceptor{} - _ Acceptor = &AcceptorTracker{} + _ Acceptor = (*AcceptorTracker)(nil) _ Acceptor = acceptorWrapper{} - _ AcceptorGroup = &acceptorGroup{} + _ AcceptorGroup = (*acceptorGroup)(nil) ) // Acceptor is implemented when a struct is monitoring if a message is accepted diff --git a/snow/choices/test_decidable.go b/snow/choices/test_decidable.go index 5c2b276b3a7..b962d98078b 100644 --- a/snow/choices/test_decidable.go +++ b/snow/choices/test_decidable.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/ids" ) -var _ Decidable = &TestDecidable{} +var _ Decidable = (*TestDecidable)(nil) // TestDecidable is a test Decidable type TestDecidable struct { diff --git a/snow/consensus/avalanche/poll/early_term_no_traversal.go b/snow/consensus/avalanche/poll/early_term_no_traversal.go index 70962f77cd6..e0b27d9fa14 100644 --- a/snow/consensus/avalanche/poll/early_term_no_traversal.go +++ b/snow/consensus/avalanche/poll/early_term_no_traversal.go @@ -10,8 +10,8 @@ import ( ) var ( - _ Factory = &earlyTermNoTraversalFactory{} - _ Poll = &earlyTermNoTraversalPoll{} + _ Factory = (*earlyTermNoTraversalFactory)(nil) + _ Poll = (*earlyTermNoTraversalPoll)(nil) ) type earlyTermNoTraversalFactory struct { diff --git a/snow/consensus/avalanche/poll/no_early_term.go b/snow/consensus/avalanche/poll/no_early_term.go index 1d859866402..459928ff276 100644 --- a/snow/consensus/avalanche/poll/no_early_term.go +++ b/snow/consensus/avalanche/poll/no_early_term.go @@ -10,8 +10,8 @@ import ( ) var ( - _ Factory = &noEarlyTermFactory{} - _ Poll = &noEarlyTermPoll{} + _ Factory = (*noEarlyTermFactory)(nil) + _ Poll = (*noEarlyTermPoll)(nil) ) type noEarlyTermFactory struct{} diff --git a/snow/consensus/avalanche/poll/set.go b/snow/consensus/avalanche/poll/set.go index 9d9d70874c1..1f35e3c78bf 100644 --- a/snow/consensus/avalanche/poll/set.go +++ b/snow/consensus/avalanche/poll/set.go @@ -19,8 +19,8 @@ import ( ) var ( - _ Set = &set{} - _ Poll = &poll{} + _ Set = (*set)(nil) + _ Poll = (*poll)(nil) ) type pollHolder interface { diff --git a/snow/consensus/avalanche/test_vertex.go b/snow/consensus/avalanche/test_vertex.go index 4390798ac14..d48baf9ff5c 100644 --- a/snow/consensus/avalanche/test_vertex.go +++ b/snow/consensus/avalanche/test_vertex.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/snow/consensus/snowstorm" ) -var _ Vertex = &TestVertex{} +var _ Vertex = (*TestVertex)(nil) // TestVertex is a useful test vertex type TestVertex struct { diff --git a/snow/consensus/avalanche/topological.go b/snow/consensus/avalanche/topological.go index cf77b9f7ca0..4f7c003e367 100644 --- a/snow/consensus/avalanche/topological.go +++ b/snow/consensus/avalanche/topological.go @@ -22,8 +22,8 @@ const minMapSize = 16 var ( errNoLeaves = errors.New("couldn't pop a leaf from leaf set") - _ Factory = &TopologicalFactory{} - _ Consensus = &Topological{} + _ Factory = (*TopologicalFactory)(nil) + _ Consensus = (*Topological)(nil) ) // TopologicalFactory implements Factory by returning a topological struct diff --git a/snow/consensus/avalanche/transaction_vertex.go b/snow/consensus/avalanche/transaction_vertex.go index 0f35e9724e2..8a99fee4121 100644 --- a/snow/consensus/avalanche/transaction_vertex.go +++ b/snow/consensus/avalanche/transaction_vertex.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/snow/consensus/snowstorm" ) -var _ snowstorm.Tx = &transactionVertex{} +var _ snowstorm.Tx = (*transactionVertex)(nil) // newTransactionVertex returns a new transactionVertex initialized with a // processing status. diff --git a/snow/consensus/metrics/height.go b/snow/consensus/metrics/height.go index 93a98b8d398..5671ff7f16c 100644 --- a/snow/consensus/metrics/height.go +++ b/snow/consensus/metrics/height.go @@ -7,7 +7,7 @@ import ( "github.com/prometheus/client_golang/prometheus" ) -var _ Height = &height{} +var _ Height = (*height)(nil) // Height reports the last accepted height type Height interface { diff --git a/snow/consensus/metrics/latency.go b/snow/consensus/metrics/latency.go index 599ccf3316f..2f594f80c81 100644 --- a/snow/consensus/metrics/latency.go +++ b/snow/consensus/metrics/latency.go @@ -19,7 +19,7 @@ import ( "github.com/ava-labs/avalanchego/utils/wrappers" ) -var _ Latency = &latency{} +var _ Latency = (*latency)(nil) type Latency interface { // Issued marks the item as having been issued. diff --git a/snow/consensus/metrics/polls.go b/snow/consensus/metrics/polls.go index aff848e9101..e21bb7f0dd5 100644 --- a/snow/consensus/metrics/polls.go +++ b/snow/consensus/metrics/polls.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/utils/wrappers" ) -var _ Polls = &polls{} +var _ Polls = (*polls)(nil) // Polls reports commonly used consensus poll metrics. type Polls interface { diff --git a/snow/consensus/metrics/timestamp.go b/snow/consensus/metrics/timestamp.go index aff6728dbc7..ff2596b017a 100644 --- a/snow/consensus/metrics/timestamp.go +++ b/snow/consensus/metrics/timestamp.go @@ -9,7 +9,7 @@ import ( "github.com/prometheus/client_golang/prometheus" ) -var _ Timestamp = ×tamp{} +var _ Timestamp = (*timestamp)(nil) // Timestamp reports the last accepted block time, // to track it in unix seconds. diff --git a/snow/consensus/snowball/binary_slush.go b/snow/consensus/snowball/binary_slush.go index 8428c929707..21a21853002 100644 --- a/snow/consensus/snowball/binary_slush.go +++ b/snow/consensus/snowball/binary_slush.go @@ -7,7 +7,7 @@ import ( "fmt" ) -var _ BinarySlush = &binarySlush{} +var _ BinarySlush = (*binarySlush)(nil) // binarySlush is the implementation of a binary slush instance type binarySlush struct { diff --git a/snow/consensus/snowball/binary_snowball.go b/snow/consensus/snowball/binary_snowball.go index 349398b0c3c..300921de4e5 100644 --- a/snow/consensus/snowball/binary_snowball.go +++ b/snow/consensus/snowball/binary_snowball.go @@ -7,7 +7,7 @@ import ( "fmt" ) -var _ BinarySnowball = &binarySnowball{} +var _ BinarySnowball = (*binarySnowball)(nil) // binarySnowball is the implementation of a binary snowball instance type binarySnowball struct { diff --git a/snow/consensus/snowball/binary_snowflake.go b/snow/consensus/snowball/binary_snowflake.go index f11b5584b96..b6f200df568 100644 --- a/snow/consensus/snowball/binary_snowflake.go +++ b/snow/consensus/snowball/binary_snowflake.go @@ -7,7 +7,7 @@ import ( "fmt" ) -var _ BinarySnowflake = &binarySnowflake{} +var _ BinarySnowflake = (*binarySnowflake)(nil) // binarySnowflake is the implementation of a binary snowflake instance type binarySnowflake struct { diff --git a/snow/consensus/snowball/consensus_test.go b/snow/consensus/snowball/consensus_test.go index 83ae2abd1d3..03cec4c787e 100644 --- a/snow/consensus/snowball/consensus_test.go +++ b/snow/consensus/snowball/consensus_test.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/ids" ) -var _ Consensus = &Byzantine{} +var _ Consensus = (*Byzantine)(nil) // Byzantine is a naive implementation of a multi-choice snowball instance type Byzantine struct { diff --git a/snow/consensus/snowball/flat.go b/snow/consensus/snowball/flat.go index 42ce8685533..d8d5db9c2e3 100644 --- a/snow/consensus/snowball/flat.go +++ b/snow/consensus/snowball/flat.go @@ -8,8 +8,8 @@ import ( ) var ( - _ Factory = &FlatFactory{} - _ Consensus = &Flat{} + _ Factory = (*FlatFactory)(nil) + _ Consensus = (*Flat)(nil) ) // FlatFactory implements Factory by returning a flat struct diff --git a/snow/consensus/snowball/nnary_slush.go b/snow/consensus/snowball/nnary_slush.go index 0b67afba209..b42e43145ed 100644 --- a/snow/consensus/snowball/nnary_slush.go +++ b/snow/consensus/snowball/nnary_slush.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/ids" ) -var _ NnarySlush = &nnarySlush{} +var _ NnarySlush = (*nnarySlush)(nil) // nnarySlush is the implementation of a slush instance with an unbounded number // of choices diff --git a/snow/consensus/snowball/nnary_snowball.go b/snow/consensus/snowball/nnary_snowball.go index fdbcc32a512..3cca6d676cc 100644 --- a/snow/consensus/snowball/nnary_snowball.go +++ b/snow/consensus/snowball/nnary_snowball.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/ids" ) -var _ NnarySnowball = &nnarySnowball{} +var _ NnarySnowball = (*nnarySnowball)(nil) // nnarySnowball is a naive implementation of a multi-color snowball instance type nnarySnowball struct { diff --git a/snow/consensus/snowball/nnary_snowflake.go b/snow/consensus/snowball/nnary_snowflake.go index 44e712e3a11..df811ecabe0 100644 --- a/snow/consensus/snowball/nnary_snowflake.go +++ b/snow/consensus/snowball/nnary_snowflake.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/ids" ) -var _ NnarySnowflake = &nnarySnowflake{} +var _ NnarySnowflake = (*nnarySnowflake)(nil) // nnarySnowflake is the implementation of a snowflake instance with an // unbounded number of choices diff --git a/snow/consensus/snowball/tree.go b/snow/consensus/snowball/tree.go index 92c08e4015a..b197120694b 100644 --- a/snow/consensus/snowball/tree.go +++ b/snow/consensus/snowball/tree.go @@ -11,10 +11,10 @@ import ( ) var ( - _ Factory = &TreeFactory{} - _ Consensus = &Tree{} - _ node = &unaryNode{} - _ node = &binaryNode{} + _ Factory = (*TreeFactory)(nil) + _ Consensus = (*Tree)(nil) + _ node = (*unaryNode)(nil) + _ node = (*binaryNode)(nil) ) // TreeFactory implements Factory by returning a tree struct diff --git a/snow/consensus/snowball/unary_snowball.go b/snow/consensus/snowball/unary_snowball.go index e4cfdb68bfe..28397d50be9 100644 --- a/snow/consensus/snowball/unary_snowball.go +++ b/snow/consensus/snowball/unary_snowball.go @@ -7,7 +7,7 @@ import ( "fmt" ) -var _ UnarySnowball = &unarySnowball{} +var _ UnarySnowball = (*unarySnowball)(nil) // unarySnowball is the implementation of a unary snowball instance type unarySnowball struct { diff --git a/snow/consensus/snowball/unary_snowflake.go b/snow/consensus/snowball/unary_snowflake.go index 519a6d96a33..8bc7f806e42 100644 --- a/snow/consensus/snowball/unary_snowflake.go +++ b/snow/consensus/snowball/unary_snowflake.go @@ -7,7 +7,7 @@ import ( "fmt" ) -var _ UnarySnowflake = &unarySnowflake{} +var _ UnarySnowflake = (*unarySnowflake)(nil) // unarySnowflake is the implementation of a unary snowflake instance type unarySnowflake struct { diff --git a/snow/consensus/snowman/test_block.go b/snow/consensus/snowman/test_block.go index 241688b54cf..e1db34f22f7 100644 --- a/snow/consensus/snowman/test_block.go +++ b/snow/consensus/snowman/test_block.go @@ -11,7 +11,7 @@ import ( "github.com/ava-labs/avalanchego/snow/choices" ) -var _ Block = &TestBlock{} +var _ Block = (*TestBlock)(nil) // TestBlock is a useful test block type TestBlock struct { diff --git a/snow/consensus/snowman/topological.go b/snow/consensus/snowman/topological.go index e30ba14f17b..17c23183185 100644 --- a/snow/consensus/snowman/topological.go +++ b/snow/consensus/snowman/topological.go @@ -21,8 +21,8 @@ import ( var ( errDuplicateAdd = errors.New("duplicate block add") - _ Factory = &TopologicalFactory{} - _ Consensus = &Topological{} + _ Factory = (*TopologicalFactory)(nil) + _ Consensus = (*Topological)(nil) ) // TopologicalFactory implements Factory by returning a topological struct diff --git a/snow/consensus/snowstorm/acceptor.go b/snow/consensus/snowstorm/acceptor.go index 6221588b091..b26d8301cde 100644 --- a/snow/consensus/snowstorm/acceptor.go +++ b/snow/consensus/snowstorm/acceptor.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/utils/wrappers" ) -var _ events.Blockable = &acceptor{} +var _ events.Blockable = (*acceptor)(nil) type acceptor struct { g *Directed diff --git a/snow/consensus/snowstorm/directed.go b/snow/consensus/snowstorm/directed.go index 764e26756ad..6148d7a8cc6 100644 --- a/snow/consensus/snowstorm/directed.go +++ b/snow/consensus/snowstorm/directed.go @@ -21,8 +21,8 @@ import ( ) var ( - _ Factory = &DirectedFactory{} - _ Consensus = &Directed{} + _ Factory = (*DirectedFactory)(nil) + _ Consensus = (*Directed)(nil) ) // DirectedFactory implements Factory by returning a directed struct diff --git a/snow/consensus/snowstorm/rejector.go b/snow/consensus/snowstorm/rejector.go index 99dc0379578..11049226f7e 100644 --- a/snow/consensus/snowstorm/rejector.go +++ b/snow/consensus/snowstorm/rejector.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/utils/wrappers" ) -var _ events.Blockable = &rejector{} +var _ events.Blockable = (*rejector)(nil) type rejector struct { g *Directed diff --git a/snow/consensus/snowstorm/test_tx.go b/snow/consensus/snowstorm/test_tx.go index a62d99e5739..1803b6796f3 100644 --- a/snow/consensus/snowstorm/test_tx.go +++ b/snow/consensus/snowstorm/test_tx.go @@ -8,7 +8,7 @@ import ( "github.com/ava-labs/avalanchego/snow/choices" ) -var _ Tx = &TestTx{} +var _ Tx = (*TestTx)(nil) // TestTx is a useful test tx type TestTx struct { diff --git a/snow/engine/avalanche/bootstrap/bootstrapper.go b/snow/engine/avalanche/bootstrap/bootstrapper.go index 65c2bb8adef..3cf82c9d171 100644 --- a/snow/engine/avalanche/bootstrap/bootstrapper.go +++ b/snow/engine/avalanche/bootstrap/bootstrapper.go @@ -34,7 +34,7 @@ const ( ) var ( - _ common.BootstrapableEngine = &bootstrapper{} + _ common.BootstrapableEngine = (*bootstrapper)(nil) errUnexpectedTimeout = errors.New("unexpected timeout fired") ) diff --git a/snow/engine/avalanche/getter/getter.go b/snow/engine/avalanche/getter/getter.go index 8b04fb3cc84..0ce5db7d704 100644 --- a/snow/engine/avalanche/getter/getter.go +++ b/snow/engine/avalanche/getter/getter.go @@ -21,7 +21,7 @@ import ( ) // Get requests are always served, regardless node state (bootstrapping or normal operations). -var _ common.AllGetsServer = &getter{} +var _ common.AllGetsServer = (*getter)(nil) func New(storage vertex.Storage, commonCfg common.Config) (common.AllGetsServer, error) { gh := &getter{ diff --git a/snow/engine/avalanche/state/serializer.go b/snow/engine/avalanche/state/serializer.go index 8e902ca6b9a..04b52d429f8 100644 --- a/snow/engine/avalanche/state/serializer.go +++ b/snow/engine/avalanche/state/serializer.go @@ -31,7 +31,7 @@ var ( errWrongChainID = errors.New("wrong ChainID in vertex") ) -var _ vertex.Manager = &Serializer{} +var _ vertex.Manager = (*Serializer)(nil) // Serializer manages the state of multiple vertices type Serializer struct { diff --git a/snow/engine/avalanche/state/unique_vertex.go b/snow/engine/avalanche/state/unique_vertex.go index 791a9df7703..c0c8fe338ca 100644 --- a/snow/engine/avalanche/state/unique_vertex.go +++ b/snow/engine/avalanche/state/unique_vertex.go @@ -20,8 +20,8 @@ import ( ) var ( - _ cache.Evictable = &uniqueVertex{} - _ avalanche.Vertex = &uniqueVertex{} + _ cache.Evictable = (*uniqueVertex)(nil) + _ avalanche.Vertex = (*uniqueVertex)(nil) ) // uniqueVertex acts as a cache for vertices in the database. diff --git a/snow/engine/avalanche/test_engine.go b/snow/engine/avalanche/test_engine.go index 19e9dd07efd..0b8b4cf752f 100644 --- a/snow/engine/avalanche/test_engine.go +++ b/snow/engine/avalanche/test_engine.go @@ -12,7 +12,7 @@ import ( ) var ( - _ Engine = &EngineTest{} + _ Engine = (*EngineTest)(nil) errGetVtx = errors.New("unexpectedly called GetVtx") ) diff --git a/snow/engine/avalanche/transitive.go b/snow/engine/avalanche/transitive.go index d14f359b734..39396c61e3d 100644 --- a/snow/engine/avalanche/transitive.go +++ b/snow/engine/avalanche/transitive.go @@ -22,7 +22,7 @@ import ( "github.com/ava-labs/avalanchego/version" ) -var _ Engine = &Transitive{} +var _ Engine = (*Transitive)(nil) func New(config Config) (Engine, error) { return newTransitive(config) diff --git a/snow/engine/avalanche/vertex/heap.go b/snow/engine/avalanche/vertex/heap.go index 4dbf4f669e9..fe4c2574c4a 100644 --- a/snow/engine/avalanche/vertex/heap.go +++ b/snow/engine/avalanche/vertex/heap.go @@ -11,8 +11,8 @@ import ( ) var ( - _ Heap = &maxHeightVertexHeap{} - _ heap.Interface = &priorityQueue{} + _ Heap = (*maxHeightVertexHeap)(nil) + _ heap.Interface = (*priorityQueue)(nil) ) type priorityQueue []avalanche.Vertex diff --git a/snow/engine/avalanche/vertex/test_builder.go b/snow/engine/avalanche/vertex/test_builder.go index 25ff4ce58a5..88135f28c5a 100644 --- a/snow/engine/avalanche/vertex/test_builder.go +++ b/snow/engine/avalanche/vertex/test_builder.go @@ -15,7 +15,7 @@ import ( var ( errBuild = errors.New("unexpectedly called Build") - _ Builder = &TestBuilder{} + _ Builder = (*TestBuilder)(nil) ) type TestBuilder struct { diff --git a/snow/engine/avalanche/vertex/test_manager.go b/snow/engine/avalanche/vertex/test_manager.go index 6d5fe33cb0c..618d7b27df4 100644 --- a/snow/engine/avalanche/vertex/test_manager.go +++ b/snow/engine/avalanche/vertex/test_manager.go @@ -5,7 +5,7 @@ package vertex import "testing" -var _ Manager = &TestManager{} +var _ Manager = (*TestManager)(nil) type TestManager struct { TestBuilder diff --git a/snow/engine/avalanche/vertex/test_parser.go b/snow/engine/avalanche/vertex/test_parser.go index c7b97896a17..3015e40c9f3 100644 --- a/snow/engine/avalanche/vertex/test_parser.go +++ b/snow/engine/avalanche/vertex/test_parser.go @@ -13,7 +13,7 @@ import ( var ( errParse = errors.New("unexpectedly called Parse") - _ Parser = &TestParser{} + _ Parser = (*TestParser)(nil) ) type TestParser struct { diff --git a/snow/engine/avalanche/vertex/test_storage.go b/snow/engine/avalanche/vertex/test_storage.go index 2ed40c5329c..501ffd53a6e 100644 --- a/snow/engine/avalanche/vertex/test_storage.go +++ b/snow/engine/avalanche/vertex/test_storage.go @@ -16,7 +16,7 @@ var ( errEdge = errors.New("unexpectedly called Edge") errStopVertexAccepted = errors.New("unexpectedly called StopVertexAccepted") - _ Storage = &TestStorage{} + _ Storage = (*TestStorage)(nil) ) type TestStorage struct { diff --git a/snow/engine/avalanche/vertex/test_vm.go b/snow/engine/avalanche/vertex/test_vm.go index 17ef7cf63d9..1eced2abc08 100644 --- a/snow/engine/avalanche/vertex/test_vm.go +++ b/snow/engine/avalanche/vertex/test_vm.go @@ -14,7 +14,7 @@ import ( var ( errPending = errors.New("unexpectedly called Pending") - _ DAGVM = &TestVM{} + _ DAGVM = (*TestVM)(nil) ) type TestVM struct { diff --git a/snow/engine/common/appsender/appsender_client.go b/snow/engine/common/appsender/appsender_client.go index 303e0d7c296..e382e155bbc 100644 --- a/snow/engine/common/appsender/appsender_client.go +++ b/snow/engine/common/appsender/appsender_client.go @@ -12,7 +12,7 @@ import ( appsenderpb "github.com/ava-labs/avalanchego/proto/pb/appsender" ) -var _ common.AppSender = &Client{} +var _ common.AppSender = (*Client)(nil) type Client struct { client appsenderpb.AppSenderClient diff --git a/snow/engine/common/appsender/appsender_server.go b/snow/engine/common/appsender/appsender_server.go index 4e61ea532c3..5fea3db22b4 100644 --- a/snow/engine/common/appsender/appsender_server.go +++ b/snow/engine/common/appsender/appsender_server.go @@ -14,7 +14,7 @@ import ( appsenderpb "github.com/ava-labs/avalanchego/proto/pb/appsender" ) -var _ appsenderpb.AppSenderServer = &Server{} +var _ appsenderpb.AppSenderServer = (*Server)(nil) type Server struct { appsenderpb.UnsafeAppSenderServer diff --git a/snow/engine/common/bootstrapper.go b/snow/engine/common/bootstrapper.go index 57363e9e836..8d8b9cda7d4 100644 --- a/snow/engine/common/bootstrapper.go +++ b/snow/engine/common/bootstrapper.go @@ -27,7 +27,7 @@ const ( MaxOutstandingBroadcastRequests = 50 ) -var _ Bootstrapper = &bootstrapper{} +var _ Bootstrapper = (*bootstrapper)(nil) type Bootstrapper interface { AcceptedFrontierHandler diff --git a/snow/engine/common/halter.go b/snow/engine/common/halter.go index f67eb3c7102..3c8582f9490 100644 --- a/snow/engine/common/halter.go +++ b/snow/engine/common/halter.go @@ -7,7 +7,7 @@ import ( "sync/atomic" ) -var _ Haltable = &Halter{} +var _ Haltable = (*Halter)(nil) type Haltable interface { Halt() diff --git a/snow/engine/common/no_ops_handlers.go b/snow/engine/common/no_ops_handlers.go index 20a1a5a03a0..1c58e2afd83 100644 --- a/snow/engine/common/no_ops_handlers.go +++ b/snow/engine/common/no_ops_handlers.go @@ -15,15 +15,15 @@ import ( ) var ( - _ StateSummaryFrontierHandler = &noOpStateSummaryFrontierHandler{} - _ AcceptedStateSummaryHandler = &noOpAcceptedStateSummaryHandler{} - _ AcceptedFrontierHandler = &noOpAcceptedFrontierHandler{} - _ AcceptedHandler = &noOpAcceptedHandler{} - _ AncestorsHandler = &noOpAncestorsHandler{} - _ PutHandler = &noOpPutHandler{} - _ QueryHandler = &noOpQueryHandler{} - _ ChitsHandler = &noOpChitsHandler{} - _ AppHandler = &noOpAppHandler{} + _ StateSummaryFrontierHandler = (*noOpStateSummaryFrontierHandler)(nil) + _ AcceptedStateSummaryHandler = (*noOpAcceptedStateSummaryHandler)(nil) + _ AcceptedFrontierHandler = (*noOpAcceptedFrontierHandler)(nil) + _ AcceptedHandler = (*noOpAcceptedHandler)(nil) + _ AncestorsHandler = (*noOpAncestorsHandler)(nil) + _ PutHandler = (*noOpPutHandler)(nil) + _ QueryHandler = (*noOpQueryHandler)(nil) + _ ChitsHandler = (*noOpChitsHandler)(nil) + _ AppHandler = (*noOpAppHandler)(nil) ) type noOpStateSummaryFrontierHandler struct { diff --git a/snow/engine/common/test_bootstrapable.go b/snow/engine/common/test_bootstrapable.go index 9be078eb198..494eaa1326c 100644 --- a/snow/engine/common/test_bootstrapable.go +++ b/snow/engine/common/test_bootstrapable.go @@ -11,7 +11,7 @@ import ( ) var ( - _ Bootstrapable = &BootstrapableTest{} + _ Bootstrapable = (*BootstrapableTest)(nil) errForceAccepted = errors.New("unexpectedly called ForceAccepted") errClear = errors.New("unexpectedly called Clear") diff --git a/snow/engine/common/test_bootstrapper.go b/snow/engine/common/test_bootstrapper.go index 79b7fb90e5c..c66226afe4d 100644 --- a/snow/engine/common/test_bootstrapper.go +++ b/snow/engine/common/test_bootstrapper.go @@ -4,8 +4,8 @@ package common var ( - _ Engine = &BootstrapperTest{} - _ Bootstrapable = &BootstrapperTest{} + _ Engine = (*BootstrapperTest)(nil) + _ Bootstrapable = (*BootstrapperTest)(nil) ) // EngineTest is a test engine diff --git a/snow/engine/common/test_engine.go b/snow/engine/common/test_engine.go index 774f339b64e..e9727b68f47 100644 --- a/snow/engine/common/test_engine.go +++ b/snow/engine/common/test_engine.go @@ -41,7 +41,7 @@ var ( errChits = errors.New("unexpectedly called Chits") errStart = errors.New("unexpectedly called Start") - _ Engine = &EngineTest{} + _ Engine = (*EngineTest)(nil) ) // EngineTest is a test engine diff --git a/snow/engine/common/test_sender.go b/snow/engine/common/test_sender.go index 704f79e3e42..8b08d2106cb 100644 --- a/snow/engine/common/test_sender.go +++ b/snow/engine/common/test_sender.go @@ -12,7 +12,7 @@ import ( ) var ( - _ Sender = &SenderTest{} + _ Sender = (*SenderTest)(nil) errAccept = errors.New("unexpectedly called Accept") errSendAppRequest = errors.New("unexpectedly called SendAppRequest") diff --git a/snow/engine/common/test_timer.go b/snow/engine/common/test_timer.go index 9d307f5f699..707db7b4646 100644 --- a/snow/engine/common/test_timer.go +++ b/snow/engine/common/test_timer.go @@ -8,7 +8,7 @@ import ( "time" ) -var _ Timer = &TimerTest{} +var _ Timer = (*TimerTest)(nil) // TimerTest is a test timer type TimerTest struct { diff --git a/snow/engine/common/test_vm.go b/snow/engine/common/test_vm.go index 187b320fb30..e0ee3fa5614 100644 --- a/snow/engine/common/test_vm.go +++ b/snow/engine/common/test_vm.go @@ -33,7 +33,7 @@ var ( errCrossChainAppResponse = errors.New("unexpectedly called CrossChainAppResponse") errCrossChainAppRequestFailed = errors.New("unexpectedly called CrossChainAppRequestFailed") - _ VM = &TestVM{} + _ VM = (*TestVM)(nil) ) // TestVM is a test vm diff --git a/snow/engine/common/tracker/peers.go b/snow/engine/common/tracker/peers.go index 07f636c9325..d0a97eddb57 100644 --- a/snow/engine/common/tracker/peers.go +++ b/snow/engine/common/tracker/peers.go @@ -11,7 +11,7 @@ import ( "github.com/ava-labs/avalanchego/version" ) -var _ Peers = &peers{} +var _ Peers = (*peers)(nil) type Peers interface { validators.SetCallbackListener diff --git a/snow/engine/common/tracker/startup.go b/snow/engine/common/tracker/startup.go index 66891219673..d3d95800ab6 100644 --- a/snow/engine/common/tracker/startup.go +++ b/snow/engine/common/tracker/startup.go @@ -10,7 +10,7 @@ import ( "github.com/ava-labs/avalanchego/version" ) -var _ Startup = &startup{} +var _ Startup = (*startup)(nil) type Startup interface { Peers diff --git a/snow/engine/snowman/block/test_batched_vm.go b/snow/engine/snowman/block/test_batched_vm.go index dca36b3763d..af396ef01bf 100644 --- a/snow/engine/snowman/block/test_batched_vm.go +++ b/snow/engine/snowman/block/test_batched_vm.go @@ -16,7 +16,7 @@ var ( errGetAncestor = errors.New("unexpectedly called GetAncestor") errBatchedParseBlock = errors.New("unexpectedly called BatchedParseBlock") - _ BatchedChainVM = &TestBatchedVM{} + _ BatchedChainVM = (*TestBatchedVM)(nil) ) // TestBatchedVM is a BatchedVM that is useful for testing. diff --git a/snow/engine/snowman/block/test_height_indexed_vm.go b/snow/engine/snowman/block/test_height_indexed_vm.go index f2d8996d4ad..3f5738c7bdf 100644 --- a/snow/engine/snowman/block/test_height_indexed_vm.go +++ b/snow/engine/snowman/block/test_height_indexed_vm.go @@ -14,7 +14,7 @@ var ( errVerifyHeightIndex = errors.New("unexpectedly called VerifyHeightIndex") errGetBlockIDAtHeight = errors.New("unexpectedly called GetBlockIDAtHeight") - _ HeightIndexedChainVM = &TestHeightIndexedVM{} + _ HeightIndexedChainVM = (*TestHeightIndexedVM)(nil) ) // TestBatchedVM is a BatchedVM that is useful for testing. diff --git a/snow/engine/snowman/block/test_state_summary.go b/snow/engine/snowman/block/test_state_summary.go index 139fb39040a..3bb34aef359 100644 --- a/snow/engine/snowman/block/test_state_summary.go +++ b/snow/engine/snowman/block/test_state_summary.go @@ -11,7 +11,7 @@ import ( ) var ( - _ StateSummary = &TestStateSummary{} + _ StateSummary = (*TestStateSummary)(nil) errAccept = errors.New("unexpectedly called Accept") ) diff --git a/snow/engine/snowman/block/test_state_syncable_vm.go b/snow/engine/snowman/block/test_state_syncable_vm.go index bec3ebc8e26..9b2bd17d5c2 100644 --- a/snow/engine/snowman/block/test_state_syncable_vm.go +++ b/snow/engine/snowman/block/test_state_syncable_vm.go @@ -9,7 +9,7 @@ import ( ) var ( - _ StateSyncableVM = &TestStateSyncableVM{} + _ StateSyncableVM = (*TestStateSyncableVM)(nil) errStateSyncEnabled = errors.New("unexpectedly called StateSyncEnabled") errStateSyncGetOngoingSummary = errors.New("unexpectedly called StateSyncGetOngoingSummary") diff --git a/snow/engine/snowman/block/test_vm.go b/snow/engine/snowman/block/test_vm.go index 6e0f38771ed..3e4f9da54d2 100644 --- a/snow/engine/snowman/block/test_vm.go +++ b/snow/engine/snowman/block/test_vm.go @@ -17,7 +17,7 @@ var ( errGetBlock = errors.New("unexpectedly called GetBlock") errLastAccepted = errors.New("unexpectedly called LastAccepted") - _ ChainVM = &TestVM{} + _ ChainVM = (*TestVM)(nil) ) // TestVM is a ChainVM that is useful for testing. diff --git a/snow/engine/snowman/bootstrap/bootstrapper.go b/snow/engine/snowman/bootstrap/bootstrapper.go index a661791433c..49c3c880b1b 100644 --- a/snow/engine/snowman/bootstrap/bootstrapper.go +++ b/snow/engine/snowman/bootstrap/bootstrapper.go @@ -25,7 +25,7 @@ import ( const bootstrappingDelay = 10 * time.Second var ( - _ common.BootstrapableEngine = &bootstrapper{} + _ common.BootstrapableEngine = (*bootstrapper)(nil) errUnexpectedTimeout = errors.New("unexpected timeout fired") ) diff --git a/snow/engine/snowman/getter/getter.go b/snow/engine/snowman/getter/getter.go index c35ddae0d10..ac2e8f3cdb1 100644 --- a/snow/engine/snowman/getter/getter.go +++ b/snow/engine/snowman/getter/getter.go @@ -16,7 +16,7 @@ import ( ) // Get requests are always served, regardless node state (bootstrapping or normal operations). -var _ common.AllGetsServer = &getter{} +var _ common.AllGetsServer = (*getter)(nil) func New( vm block.ChainVM, diff --git a/snow/engine/snowman/syncer/state_syncer.go b/snow/engine/snowman/syncer/state_syncer.go index 11e890aefa4..64ba67ad781 100644 --- a/snow/engine/snowman/syncer/state_syncer.go +++ b/snow/engine/snowman/syncer/state_syncer.go @@ -21,7 +21,7 @@ import ( "github.com/ava-labs/avalanchego/version" ) -var _ common.StateSyncer = &stateSyncer{} +var _ common.StateSyncer = (*stateSyncer)(nil) // summary content as received from network, along with accumulated weight. type weightedSummary struct { diff --git a/snow/engine/snowman/test_engine.go b/snow/engine/snowman/test_engine.go index d90e7ee742c..0c3dbd28b76 100644 --- a/snow/engine/snowman/test_engine.go +++ b/snow/engine/snowman/test_engine.go @@ -12,7 +12,7 @@ import ( ) var ( - _ Engine = &EngineTest{} + _ Engine = (*EngineTest)(nil) errGetBlock = errors.New("unexpectedly called GetBlock") ) diff --git a/snow/engine/snowman/transitive.go b/snow/engine/snowman/transitive.go index d7b816e282b..c9b025f4c5a 100644 --- a/snow/engine/snowman/transitive.go +++ b/snow/engine/snowman/transitive.go @@ -24,7 +24,7 @@ import ( const nonVerifiedCacheSize = 128 -var _ Engine = &Transitive{} +var _ Engine = (*Transitive)(nil) func New(config Config) (Engine, error) { return newTransitive(config) diff --git a/snow/networking/benchlist/benchlist.go b/snow/networking/benchlist/benchlist.go index 6e5197e6c8e..4a9cafd7155 100644 --- a/snow/networking/benchlist/benchlist.go +++ b/snow/networking/benchlist/benchlist.go @@ -23,7 +23,7 @@ import ( safemath "github.com/ava-labs/avalanchego/utils/math" ) -var _ heap.Interface = &benchedQueue{} +var _ heap.Interface = (*benchedQueue)(nil) // If a peer consistently does not respond to queries, it will // increase latencies on the network whenever that peer is polled. diff --git a/snow/networking/benchlist/manager.go b/snow/networking/benchlist/manager.go index 614c77943a3..061280a8399 100644 --- a/snow/networking/benchlist/manager.go +++ b/snow/networking/benchlist/manager.go @@ -17,7 +17,7 @@ import ( var ( errUnknownValidators = errors.New("unknown validator set for provided chain") - _ Manager = &manager{} + _ Manager = (*manager)(nil) ) // Manager provides an interface for a benchlist to register whether diff --git a/snow/networking/handler/handler.go b/snow/networking/handler/handler.go index 2ca04f2d22a..55d75003baf 100644 --- a/snow/networking/handler/handler.go +++ b/snow/networking/handler/handler.go @@ -30,7 +30,7 @@ const ( numDispatchersToClose = 3 ) -var _ Handler = &handler{} +var _ Handler = (*handler)(nil) type Handler interface { common.Timer diff --git a/snow/networking/handler/message_queue.go b/snow/networking/handler/message_queue.go index 38f416887c9..8a19b323134 100644 --- a/snow/networking/handler/message_queue.go +++ b/snow/networking/handler/message_queue.go @@ -18,7 +18,7 @@ import ( "github.com/ava-labs/avalanchego/utils/timer/mockable" ) -var _ MessageQueue = &messageQueue{} +var _ MessageQueue = (*messageQueue)(nil) type MessageQueue interface { // Add a message. diff --git a/snow/networking/router/chain_router.go b/snow/networking/router/chain_router.go index 8cf1a7635aa..9ffa48d444a 100644 --- a/snow/networking/router/chain_router.go +++ b/snow/networking/router/chain_router.go @@ -29,8 +29,8 @@ import ( var ( errUnknownChain = errors.New("received message for unknown chain") - _ Router = &ChainRouter{} - _ benchlist.Benchable = &ChainRouter{} + _ Router = (*ChainRouter)(nil) + _ benchlist.Benchable = (*ChainRouter)(nil) ) type requestEntry struct { diff --git a/snow/networking/sender/sender.go b/snow/networking/sender/sender.go index 42ad0ede57b..75414e1f13a 100644 --- a/snow/networking/sender/sender.go +++ b/snow/networking/sender/sender.go @@ -19,7 +19,7 @@ import ( "github.com/ava-labs/avalanchego/utils/constants" ) -var _ common.Sender = &sender{} +var _ common.Sender = (*sender)(nil) type GossipConfig struct { AcceptedFrontierValidatorSize uint `json:"gossipAcceptedFrontierValidatorSize" yaml:"gossipAcceptedFrontierValidatorSize"` diff --git a/snow/networking/timeout/manager.go b/snow/networking/timeout/manager.go index 63d3bef6447..0ce32e57b3b 100644 --- a/snow/networking/timeout/manager.go +++ b/snow/networking/timeout/manager.go @@ -16,7 +16,7 @@ import ( "github.com/ava-labs/avalanchego/utils/timer" ) -var _ Manager = &manager{} +var _ Manager = (*manager)(nil) // Manages timeouts for requests sent to peers. type Manager interface { diff --git a/snow/networking/tracker/resource_tracker.go b/snow/networking/tracker/resource_tracker.go index b6758c4ddca..a4fae5d13f0 100644 --- a/snow/networking/tracker/resource_tracker.go +++ b/snow/networking/tracker/resource_tracker.go @@ -19,7 +19,7 @@ import ( const epsilon = 1e-9 -var _ ResourceTracker = &resourceTracker{} +var _ ResourceTracker = (*resourceTracker)(nil) type Tracker interface { // Returns the current usage for the given node. diff --git a/snow/networking/tracker/targeter.go b/snow/networking/tracker/targeter.go index e9c863ef95e..380717f4bed 100644 --- a/snow/networking/tracker/targeter.go +++ b/snow/networking/tracker/targeter.go @@ -10,7 +10,7 @@ import ( "github.com/ava-labs/avalanchego/snow/validators" ) -var _ Targeter = &targeter{} +var _ Targeter = (*targeter)(nil) type Targeter interface { // Returns the target usage of the given node. diff --git a/snow/networking/worker/pool.go b/snow/networking/worker/pool.go index 8617fd4c00f..b4cc13e7ad5 100644 --- a/snow/networking/worker/pool.go +++ b/snow/networking/worker/pool.go @@ -7,7 +7,7 @@ import ( "sync" ) -var _ Pool = &pool{} +var _ Pool = (*pool)(nil) type Request func() diff --git a/snow/uptime/locked_calculator.go b/snow/uptime/locked_calculator.go index 0dd353faa5d..ff2ae0ef37a 100644 --- a/snow/uptime/locked_calculator.go +++ b/snow/uptime/locked_calculator.go @@ -15,7 +15,7 @@ import ( var ( errNotReady = errors.New("should not be called") - _ LockedCalculator = &lockedCalculator{} + _ LockedCalculator = (*lockedCalculator)(nil) ) type LockedCalculator interface { diff --git a/snow/uptime/manager.go b/snow/uptime/manager.go index 2aa694f4bbd..4bde2684348 100644 --- a/snow/uptime/manager.go +++ b/snow/uptime/manager.go @@ -11,7 +11,7 @@ import ( "github.com/ava-labs/avalanchego/utils/timer/mockable" ) -var _ TestManager = &manager{} +var _ TestManager = (*manager)(nil) type Manager interface { Tracker diff --git a/snow/uptime/test_state.go b/snow/uptime/test_state.go index 32a6da41101..93af5d9a005 100644 --- a/snow/uptime/test_state.go +++ b/snow/uptime/test_state.go @@ -10,7 +10,7 @@ import ( "github.com/ava-labs/avalanchego/ids" ) -var _ State = &TestState{} +var _ State = (*TestState)(nil) type uptime struct { upDuration time.Duration diff --git a/snow/validators/manager.go b/snow/validators/manager.go index 45e91006722..c372ccc995b 100644 --- a/snow/validators/manager.go +++ b/snow/validators/manager.go @@ -11,7 +11,7 @@ import ( "github.com/ava-labs/avalanchego/ids" ) -var _ Manager = &manager{} +var _ Manager = (*manager)(nil) // Manager holds the validator set of each subnet type Manager interface { diff --git a/snow/validators/set.go b/snow/validators/set.go index ab6a3bcc4e6..ea6be506a78 100644 --- a/snow/validators/set.go +++ b/snow/validators/set.go @@ -26,7 +26,7 @@ const ( capacityReductionFactor = 2 ) -var _ Set = &set{} +var _ Set = (*set)(nil) // Set of validators that can be sampled type Set interface { diff --git a/snow/validators/set_test.go b/snow/validators/set_test.go index fccad4ec1f0..ff36a154301 100644 --- a/snow/validators/set_test.go +++ b/snow/validators/set_test.go @@ -256,7 +256,7 @@ func TestSamplerMasked(t *testing.T) { } } -var _ SetCallbackListener = &callbackListener{} +var _ SetCallbackListener = (*callbackListener)(nil) type callbackListener struct { t *testing.T diff --git a/snow/validators/state.go b/snow/validators/state.go index 52c12cf1ed7..08d91486a46 100644 --- a/snow/validators/state.go +++ b/snow/validators/state.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/ids" ) -var _ State = &lockedState{} +var _ State = (*lockedState)(nil) // State allows the lookup of validator sets on specified subnets at the // requested P-chain height. diff --git a/snow/validators/test_state.go b/snow/validators/test_state.go index d070f10c683..2a02d265f1d 100644 --- a/snow/validators/test_state.go +++ b/snow/validators/test_state.go @@ -16,7 +16,7 @@ var ( errGetValidatorSet = errors.New("unexpectedly called GetValidatorSet") ) -var _ State = &TestState{} +var _ State = (*TestState)(nil) type TestState struct { T *testing.T diff --git a/snow/validators/validator.go b/snow/validators/validator.go index 4d638440b26..81b483a49b5 100644 --- a/snow/validators/validator.go +++ b/snow/validators/validator.go @@ -11,7 +11,7 @@ import ( safemath "github.com/ava-labs/avalanchego/utils/math" ) -var _ Validator = &validator{} +var _ Validator = (*validator)(nil) // Validator is the minimal description of someone that can be sampled. type Validator interface { diff --git a/utils/beacon/beacon.go b/utils/beacon/beacon.go index ecaaa61358e..a599025b4a8 100644 --- a/utils/beacon/beacon.go +++ b/utils/beacon/beacon.go @@ -8,7 +8,7 @@ import ( "github.com/ava-labs/avalanchego/utils/ips" ) -var _ Beacon = &beacon{} +var _ Beacon = (*beacon)(nil) type Beacon interface { ID() ids.NodeID diff --git a/utils/beacon/set.go b/utils/beacon/set.go index 305c2d52374..6cacd71dd3a 100644 --- a/utils/beacon/set.go +++ b/utils/beacon/set.go @@ -12,7 +12,7 @@ import ( ) var ( - _ Set = &set{} + _ Set = (*set)(nil) errDuplicateID = errors.New("duplicated ID") errDuplicateIP = errors.New("duplicated IP") diff --git a/utils/buffer/unbounded_blocking_deque.go b/utils/buffer/unbounded_blocking_deque.go index 92a43e1e2de..49b70eb567d 100644 --- a/utils/buffer/unbounded_blocking_deque.go +++ b/utils/buffer/unbounded_blocking_deque.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/utils" ) -var _ BlockingDeque[int] = &unboundedBlockingDeque[int]{} +var _ BlockingDeque[int] = (*unboundedBlockingDeque[int])(nil) type BlockingDeque[T any] interface { Deque[T] diff --git a/utils/compression/gzip_compressor.go b/utils/compression/gzip_compressor.go index 63b806c5eb1..f74975e30e1 100644 --- a/utils/compression/gzip_compressor.go +++ b/utils/compression/gzip_compressor.go @@ -16,7 +16,7 @@ import ( ) var ( - _ Compressor = &gzipCompressor{} + _ Compressor = (*gzipCompressor)(nil) ErrInvalidMaxSizeGzipCompressor = errors.New("invalid gzip compressor max size") ) diff --git a/utils/compression/no_compressor.go b/utils/compression/no_compressor.go index 795380b4861..290afd4edeb 100644 --- a/utils/compression/no_compressor.go +++ b/utils/compression/no_compressor.go @@ -3,7 +3,7 @@ package compression -var _ Compressor = &noCompressor{} +var _ Compressor = (*noCompressor)(nil) type noCompressor struct{} diff --git a/utils/crypto/ed25519.go b/utils/crypto/ed25519.go index 5b3458d7493..d59f904c091 100644 --- a/utils/crypto/ed25519.go +++ b/utils/crypto/ed25519.go @@ -18,9 +18,9 @@ var ( ) var ( - _ Factory = &FactoryED25519{} - _ PublicKey = &PublicKeyED25519{} - _ PrivateKey = &PrivateKeyED25519{} + _ Factory = (*FactoryED25519)(nil) + _ PublicKey = (*PublicKeyED25519)(nil) + _ PrivateKey = (*PrivateKeyED25519)(nil) ) type FactoryED25519 struct{} diff --git a/utils/crypto/keychain/keychain.go b/utils/crypto/keychain/keychain.go index dd2bb01dd4d..eb4c0318409 100644 --- a/utils/crypto/keychain/keychain.go +++ b/utils/crypto/keychain/keychain.go @@ -13,8 +13,8 @@ import ( ) var ( - _ Keychain = &ledgerKeychain{} - _ Signer = &ledgerSigner{} + _ Keychain = (*ledgerKeychain)(nil) + _ Signer = (*ledgerSigner)(nil) ErrInvalidNumAddrsToDerive = errors.New("number of addresses to derive should be greater than 0") ErrInvalidNumAddrsDerived = errors.New("incorrect number of ledger derived addresses") diff --git a/utils/crypto/rsa.go b/utils/crypto/rsa.go index cd085fcbda3..26ecb524c0b 100644 --- a/utils/crypto/rsa.go +++ b/utils/crypto/rsa.go @@ -17,9 +17,9 @@ import ( var ( errWrongKeyType = errors.New("wrong key type") - _ Factory = &FactoryRSA{} - _ PublicKey = &PublicKeyRSA{} - _ PrivateKey = &PrivateKeyRSA{} + _ Factory = (*FactoryRSA)(nil) + _ PublicKey = (*PublicKeyRSA)(nil) + _ PrivateKey = (*PrivateKeyRSA)(nil) ) const rsaSize = 3072 diff --git a/utils/crypto/rsapss.go b/utils/crypto/rsapss.go index d0ae67be7b1..566b05ce16d 100644 --- a/utils/crypto/rsapss.go +++ b/utils/crypto/rsapss.go @@ -14,9 +14,9 @@ import ( ) var ( - _ Factory = &FactoryRSAPSS{} - _ PublicKey = &PublicKeyRSAPSS{} - _ PrivateKey = &PrivateKeyRSAPSS{} + _ Factory = (*FactoryRSAPSS)(nil) + _ PublicKey = (*PublicKeyRSAPSS)(nil) + _ PrivateKey = (*PrivateKeyRSAPSS)(nil) ) const rsaPSSSize = 3072 diff --git a/utils/crypto/secp256k1r.go b/utils/crypto/secp256k1r.go index 7296b0b1bdc..0eb341521a5 100644 --- a/utils/crypto/secp256k1r.go +++ b/utils/crypto/secp256k1r.go @@ -54,9 +54,9 @@ var ( errMissingKeyPrefix = fmt.Errorf("private key missing %s prefix", PrivateKeyPrefix) errInvalidPrivateKeyLength = fmt.Errorf("private key has unexpected length, expected %d", SECP256K1RSKLen) - _ RecoverableFactory = &FactorySECP256K1R{} - _ PublicKey = &PublicKeySECP256K1R{} - _ PrivateKey = &PrivateKeySECP256K1R{} + _ RecoverableFactory = (*FactorySECP256K1R)(nil) + _ PublicKey = (*PublicKeySECP256K1R)(nil) + _ PrivateKey = (*PrivateKeySECP256K1R)(nil) ) type FactorySECP256K1R struct{ Cache cache.LRU } diff --git a/utils/dynamicip/ifconfig_resolver.go b/utils/dynamicip/ifconfig_resolver.go index 6e2e929d384..ec176be00ee 100644 --- a/utils/dynamicip/ifconfig_resolver.go +++ b/utils/dynamicip/ifconfig_resolver.go @@ -11,7 +11,7 @@ import ( "strings" ) -var _ Resolver = &ifConfigResolver{} +var _ Resolver = (*ifConfigResolver)(nil) // ifConfigResolver resolves our public IP using ifconfig's format. type ifConfigResolver struct { diff --git a/utils/dynamicip/opendns_resolver.go b/utils/dynamicip/opendns_resolver.go index 3ba0d9b822d..c0844f727e1 100644 --- a/utils/dynamicip/opendns_resolver.go +++ b/utils/dynamicip/opendns_resolver.go @@ -18,7 +18,7 @@ const ( var ( errOpenDNSNoIP = errors.New("openDNS returned no ip") - _ Resolver = &openDNSResolver{} + _ Resolver = (*openDNSResolver)(nil) ) // IFConfigResolves resolves our public IP using openDNS diff --git a/utils/dynamicip/updater.go b/utils/dynamicip/updater.go index 67aa7479126..ced1ec5e313 100644 --- a/utils/dynamicip/updater.go +++ b/utils/dynamicip/updater.go @@ -12,7 +12,7 @@ import ( "github.com/ava-labs/avalanchego/utils/logging" ) -var _ Updater = &updater{} +var _ Updater = (*updater)(nil) // Updater periodically updates this node's public IP. // Dispatch() and Stop() should only be called once. diff --git a/utils/dynamicip/updater_test.go b/utils/dynamicip/updater_test.go index 2f39947b97c..fcd12a258cd 100644 --- a/utils/dynamicip/updater_test.go +++ b/utils/dynamicip/updater_test.go @@ -15,7 +15,7 @@ import ( "github.com/ava-labs/avalanchego/utils/logging" ) -var _ Resolver = &mockResolver{} +var _ Resolver = (*mockResolver)(nil) type mockResolver struct { onResolve func() (net.IP, error) diff --git a/utils/hashing/consistent/ring.go b/utils/hashing/consistent/ring.go index 8f5e32e5599..18252269614 100644 --- a/utils/hashing/consistent/ring.go +++ b/utils/hashing/consistent/ring.go @@ -12,8 +12,8 @@ import ( ) var ( - _ Ring = &hashRing{} - _ btree.Item = &ringItem{} + _ Ring = (*hashRing)(nil) + _ btree.Item = (*ringItem)(nil) errEmptyRing = errors.New("ring doesn't have any members") ) diff --git a/utils/hashing/consistent/ring_test.go b/utils/hashing/consistent/ring_test.go index af84680a4d7..e0610b2c487 100644 --- a/utils/hashing/consistent/ring_test.go +++ b/utils/hashing/consistent/ring_test.go @@ -14,7 +14,7 @@ import ( ) var ( - _ Hashable = &testKey{} + _ Hashable = (*testKey)(nil) // nodes node1 = testKey{key: "node-1", hash: 1} diff --git a/utils/ips/dynamic_ip_port.go b/utils/ips/dynamic_ip_port.go index 6b3a47601b2..950dd5aeb2f 100644 --- a/utils/ips/dynamic_ip_port.go +++ b/utils/ips/dynamic_ip_port.go @@ -9,7 +9,7 @@ import ( "sync" ) -var _ DynamicIPPort = &dynamicIPPort{} +var _ DynamicIPPort = (*dynamicIPPort)(nil) // An IPPort that can change. // Safe for use by multiple goroutines. diff --git a/utils/linkedhashmap/iterator.go b/utils/linkedhashmap/iterator.go index 661e236a009..028acceed26 100644 --- a/utils/linkedhashmap/iterator.go +++ b/utils/linkedhashmap/iterator.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/utils" ) -var _ Iter[int, struct{}] = &iterator[int, struct{}]{} +var _ Iter[int, struct{}] = (*iterator[int, struct{}])(nil) // Iterates over the keys and values in a LinkedHashmap // from oldest to newest elements. diff --git a/utils/linkedhashmap/linkedhashmap.go b/utils/linkedhashmap/linkedhashmap.go index 213d61d56e1..8f8836d3838 100644 --- a/utils/linkedhashmap/linkedhashmap.go +++ b/utils/linkedhashmap/linkedhashmap.go @@ -10,7 +10,7 @@ import ( "github.com/ava-labs/avalanchego/utils" ) -var _ LinkedHashmap[int, struct{}] = &linkedHashmap[int, struct{}]{} +var _ LinkedHashmap[int, struct{}] = (*linkedHashmap[int, struct{}])(nil) // Hashmap provides an O(1) mapping from a comparable key to any value. // Comparable is defined by https://golang.org/ref/spec#Comparison_operators. diff --git a/utils/logging/factory.go b/utils/logging/factory.go index f4421239c91..d237332ada4 100644 --- a/utils/logging/factory.go +++ b/utils/logging/factory.go @@ -15,7 +15,7 @@ import ( "gopkg.in/natefinch/lumberjack.v2" ) -var _ Factory = &factory{} +var _ Factory = (*factory)(nil) // Factory creates new instances of different types of Logger type Factory interface { diff --git a/utils/logging/log.go b/utils/logging/log.go index 8975cd13cc1..71571b55b55 100644 --- a/utils/logging/log.go +++ b/utils/logging/log.go @@ -10,7 +10,7 @@ import ( "go.uber.org/zap/zapcore" ) -var _ Logger = &log{} +var _ Logger = (*log)(nil) type log struct { wrappedCores []WrappedCore diff --git a/utils/math/averager_heap.go b/utils/math/averager_heap.go index d90936ea9d4..25e788b3508 100644 --- a/utils/math/averager_heap.go +++ b/utils/math/averager_heap.go @@ -11,7 +11,7 @@ import ( var ( _ AveragerHeap = averagerHeap{} - _ heap.Interface = &averagerHeapBackend{} + _ heap.Interface = (*averagerHeapBackend)(nil) ) // AveragerHeap maintains a heap of the averagers. diff --git a/utils/math/meter/continuous_meter.go b/utils/math/meter/continuous_meter.go index 1c60ea735e4..1fc312b2565 100644 --- a/utils/math/meter/continuous_meter.go +++ b/utils/math/meter/continuous_meter.go @@ -11,8 +11,8 @@ import ( var ( convertEToBase2 = math.Log(2) - _ Factory = &ContinuousFactory{} - _ Meter = &continuousMeter{} + _ Factory = (*ContinuousFactory)(nil) + _ Meter = (*continuousMeter)(nil) ) // ContinuousFactory implements the Factory interface by returning a continuous diff --git a/utils/resource/usage.go b/utils/resource/usage.go index d4806b9032e..6703c79aa6b 100644 --- a/utils/resource/usage.go +++ b/utils/resource/usage.go @@ -16,7 +16,7 @@ import ( var ( lnHalf = math.Log(.5) - _ Manager = &manager{} + _ Manager = (*manager)(nil) ) type CPUUser interface { diff --git a/utils/rpc/requester.go b/utils/rpc/requester.go index 290b4226656..26a5f62fff3 100644 --- a/utils/rpc/requester.go +++ b/utils/rpc/requester.go @@ -8,7 +8,7 @@ import ( "net/url" ) -var _ EndpointRequester = &avalancheEndpointRequester{} +var _ EndpointRequester = (*avalancheEndpointRequester)(nil) type EndpointRequester interface { SendRequest(ctx context.Context, method string, params interface{}, reply interface{}, options ...Option) error diff --git a/utils/sampler/uniform_best.go b/utils/sampler/uniform_best.go index 0492610ca5d..52e99d2652b 100644 --- a/utils/sampler/uniform_best.go +++ b/utils/sampler/uniform_best.go @@ -14,7 +14,7 @@ import ( var ( errNoValidUniformSamplers = errors.New("no valid uniform samplers found") - _ Uniform = &uniformBest{} + _ Uniform = (*uniformBest)(nil) ) // Sampling is performed by using another implementation of the Uniform diff --git a/utils/sampler/weighted_array.go b/utils/sampler/weighted_array.go index e6c59d26047..f475c82aa3e 100644 --- a/utils/sampler/weighted_array.go +++ b/utils/sampler/weighted_array.go @@ -9,7 +9,7 @@ import ( safemath "github.com/ava-labs/avalanchego/utils/math" ) -var _ Weighted = &weightedArray{} +var _ Weighted = (*weightedArray)(nil) type weightedArrayElement struct { cumulativeWeight uint64 diff --git a/utils/sampler/weighted_best.go b/utils/sampler/weighted_best.go index b7ba016eb1c..91686badae3 100644 --- a/utils/sampler/weighted_best.go +++ b/utils/sampler/weighted_best.go @@ -16,7 +16,7 @@ import ( var ( errNoValidWeightedSamplers = errors.New("no valid weighted samplers found") - _ Weighted = &weightedBest{} + _ Weighted = (*weightedBest)(nil) ) // Sampling is performed by using another implementation of the Weighted diff --git a/utils/sampler/weighted_heap.go b/utils/sampler/weighted_heap.go index 7154eef300c..bb77d472ade 100644 --- a/utils/sampler/weighted_heap.go +++ b/utils/sampler/weighted_heap.go @@ -9,7 +9,7 @@ import ( safemath "github.com/ava-labs/avalanchego/utils/math" ) -var _ Weighted = &weightedHeap{} +var _ Weighted = (*weightedHeap)(nil) type weightedHeapElement struct { weight uint64 diff --git a/utils/sampler/weighted_linear.go b/utils/sampler/weighted_linear.go index 7e5221a6c59..a8232735cec 100644 --- a/utils/sampler/weighted_linear.go +++ b/utils/sampler/weighted_linear.go @@ -9,7 +9,7 @@ import ( safemath "github.com/ava-labs/avalanchego/utils/math" ) -var _ Weighted = &weightedLinear{} +var _ Weighted = (*weightedLinear)(nil) type weightedLinearElement struct { cumulativeWeight uint64 diff --git a/utils/sampler/weighted_uniform.go b/utils/sampler/weighted_uniform.go index 0fcfc3c861f..9585125b8b1 100644 --- a/utils/sampler/weighted_uniform.go +++ b/utils/sampler/weighted_uniform.go @@ -13,7 +13,7 @@ import ( var ( errWeightsTooLarge = errors.New("total weight is too large") - _ Weighted = &weightedUniform{} + _ Weighted = (*weightedUniform)(nil) ) // Sampling is performed by indexing into the array to find the correct index. diff --git a/utils/timer/adaptive_timeout_manager.go b/utils/timer/adaptive_timeout_manager.go index 2fac830e055..998a724e10c 100644 --- a/utils/timer/adaptive_timeout_manager.go +++ b/utils/timer/adaptive_timeout_manager.go @@ -22,8 +22,8 @@ import ( var ( errNonPositiveHalflife = errors.New("timeout halflife must be positive") - _ heap.Interface = &timeoutQueue{} - _ AdaptiveTimeoutManager = &adaptiveTimeoutManager{} + _ heap.Interface = (*timeoutQueue)(nil) + _ AdaptiveTimeoutManager = (*adaptiveTimeoutManager)(nil) ) type adaptiveTimeout struct { diff --git a/utils/window/window.go b/utils/window/window.go index 7a091dbc2b6..211ad1ba065 100644 --- a/utils/window/window.go +++ b/utils/window/window.go @@ -12,7 +12,7 @@ import ( "github.com/ava-labs/avalanchego/utils/timer/mockable" ) -var _ Window[struct{}] = &window[struct{}]{} +var _ Window[struct{}] = (*window[struct{}])(nil) // Window is an interface which represents a sliding window of elements. type Window[T any] interface { diff --git a/utils/wrappers/errors.go b/utils/wrappers/errors.go index 2484f55da0e..8e2d8ffa25b 100644 --- a/utils/wrappers/errors.go +++ b/utils/wrappers/errors.go @@ -7,7 +7,7 @@ import ( "strings" ) -var _ error = &aggregate{} +var _ error = (*aggregate)(nil) type Errs struct{ Err error } diff --git a/version/application.go b/version/application.go index fcc051e9f7a..45a4c16edb0 100644 --- a/version/application.go +++ b/version/application.go @@ -12,7 +12,7 @@ import ( var ( errDifferentMajor = errors.New("different major version") - _ fmt.Stringer = &Semantic{} + _ fmt.Stringer = (*Semantic)(nil) ) type Application struct { diff --git a/version/compatibility.go b/version/compatibility.go index b1b86e74ab1..2da6bb05308 100644 --- a/version/compatibility.go +++ b/version/compatibility.go @@ -13,7 +13,7 @@ import ( var ( errIncompatible = errors.New("peers version is incompatible") - _ Compatibility = &compatibility{} + _ Compatibility = (*compatibility)(nil) ) // Compatibility a utility for checking the compatibility of peer versions diff --git a/version/version.go b/version/version.go index 68d4b6774c9..0f489475918 100644 --- a/version/version.go +++ b/version/version.go @@ -16,7 +16,7 @@ var ( Patch: 0, } - _ fmt.Stringer = &Semantic{} + _ fmt.Stringer = (*Semantic)(nil) ) type Semantic struct { diff --git a/vms/avm/client.go b/vms/avm/client.go index 6a6aaf3b286..887ad9e4c66 100644 --- a/vms/avm/client.go +++ b/vms/avm/client.go @@ -20,7 +20,7 @@ import ( cjson "github.com/ava-labs/avalanchego/utils/json" ) -var _ Client = &client{} +var _ Client = (*client)(nil) // Client for interacting with an AVM (X-Chain) instance type Client interface { diff --git a/vms/avm/factory.go b/vms/avm/factory.go index 9c4e888bccc..7a70613e43a 100644 --- a/vms/avm/factory.go +++ b/vms/avm/factory.go @@ -8,7 +8,7 @@ import ( "github.com/ava-labs/avalanchego/vms" ) -var _ vms.Factory = &Factory{} +var _ vms.Factory = (*Factory)(nil) type Factory struct { TxFee uint64 diff --git a/vms/avm/fxs/fx.go b/vms/avm/fxs/fx.go index 7db0ab8c0c3..c7ca745518c 100644 --- a/vms/avm/fxs/fx.go +++ b/vms/avm/fxs/fx.go @@ -14,9 +14,9 @@ import ( ) var ( - _ Fx = &secp256k1fx.Fx{} - _ Fx = &nftfx.Fx{} - _ Fx = &propertyfx.Fx{} + _ Fx = (*secp256k1fx.Fx)(nil) + _ Fx = (*nftfx.Fx)(nil) + _ Fx = (*propertyfx.Fx)(nil) ) type ParsedFx struct { diff --git a/vms/avm/pubsub_filterer.go b/vms/avm/pubsub_filterer.go index bbe64529dc5..38cd19529f2 100644 --- a/vms/avm/pubsub_filterer.go +++ b/vms/avm/pubsub_filterer.go @@ -10,7 +10,7 @@ import ( "github.com/ava-labs/avalanchego/vms/components/avax" ) -var _ pubsub.Filterer = &filterer{} +var _ pubsub.Filterer = (*filterer)(nil) type filterer struct { tx *txs.Tx diff --git a/vms/avm/states/state.go b/vms/avm/states/state.go index 6c4ae7461f6..8064765c47c 100644 --- a/vms/avm/states/state.go +++ b/vms/avm/states/state.go @@ -18,7 +18,7 @@ var ( singletonPrefix = []byte("singleton") txPrefix = []byte("tx") - _ State = &state{} + _ State = (*state)(nil) ) // State persistently maintains a set of UTXOs, transaction, statuses, and diff --git a/vms/avm/states/tx_state.go b/vms/avm/states/tx_state.go index ca0c48ff5c2..45b8bd61ec9 100644 --- a/vms/avm/states/tx_state.go +++ b/vms/avm/states/tx_state.go @@ -15,7 +15,7 @@ import ( const txCacheSize = 8192 -var _ TxState = &txState{} +var _ TxState = (*txState)(nil) // TxState is a thin wrapper around a database to provide, caching, // serialization, and de-serialization of transactions. diff --git a/vms/avm/static_client.go b/vms/avm/static_client.go index a7a69e636b7..9297722e2b7 100644 --- a/vms/avm/static_client.go +++ b/vms/avm/static_client.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/utils/rpc" ) -var _ StaticClient = &staticClient{} +var _ StaticClient = (*staticClient)(nil) // StaticClient for interacting with the AVM static api type StaticClient interface { diff --git a/vms/avm/static_service.go b/vms/avm/static_service.go index 040dff34160..eb9957b5a28 100644 --- a/vms/avm/static_service.go +++ b/vms/avm/static_service.go @@ -26,23 +26,23 @@ import ( var ( errUnknownAssetType = errors.New("unknown asset type") - _ avax.TransferableIn = &secp256k1fx.TransferInput{} - _ verify.State = &secp256k1fx.MintOutput{} - _ avax.TransferableOut = &secp256k1fx.TransferOutput{} - _ fxs.FxOperation = &secp256k1fx.MintOperation{} - _ verify.Verifiable = &secp256k1fx.Credential{} - - _ verify.State = &nftfx.MintOutput{} - _ verify.State = &nftfx.TransferOutput{} - _ fxs.FxOperation = &nftfx.MintOperation{} - _ fxs.FxOperation = &nftfx.TransferOperation{} - _ verify.Verifiable = &nftfx.Credential{} - - _ verify.State = &propertyfx.MintOutput{} - _ verify.State = &propertyfx.OwnedOutput{} - _ fxs.FxOperation = &propertyfx.MintOperation{} - _ fxs.FxOperation = &propertyfx.BurnOperation{} - _ verify.Verifiable = &propertyfx.Credential{} + _ avax.TransferableIn = (*secp256k1fx.TransferInput)(nil) + _ verify.State = (*secp256k1fx.MintOutput)(nil) + _ avax.TransferableOut = (*secp256k1fx.TransferOutput)(nil) + _ fxs.FxOperation = (*secp256k1fx.MintOperation)(nil) + _ verify.Verifiable = (*secp256k1fx.Credential)(nil) + + _ verify.State = (*nftfx.MintOutput)(nil) + _ verify.State = (*nftfx.TransferOutput)(nil) + _ fxs.FxOperation = (*nftfx.MintOperation)(nil) + _ fxs.FxOperation = (*nftfx.TransferOperation)(nil) + _ verify.Verifiable = (*nftfx.Credential)(nil) + + _ verify.State = (*propertyfx.MintOutput)(nil) + _ verify.State = (*propertyfx.OwnedOutput)(nil) + _ fxs.FxOperation = (*propertyfx.MintOperation)(nil) + _ fxs.FxOperation = (*propertyfx.BurnOperation)(nil) + _ verify.Verifiable = (*propertyfx.Credential)(nil) ) // StaticService defines the base service for the asset vm diff --git a/vms/avm/tx_execute.go b/vms/avm/tx_execute.go index 1e84b14777f..18db66ab024 100644 --- a/vms/avm/tx_execute.go +++ b/vms/avm/tx_execute.go @@ -11,7 +11,7 @@ import ( "github.com/ava-labs/avalanchego/vms/components/avax" ) -var _ txs.Visitor = &executeTx{} +var _ txs.Visitor = (*executeTx)(nil) type executeTx struct { tx *txs.Tx diff --git a/vms/avm/tx_init.go b/vms/avm/tx_init.go index b0d023fef0c..abc1d650846 100644 --- a/vms/avm/tx_init.go +++ b/vms/avm/tx_init.go @@ -11,7 +11,7 @@ import ( "github.com/ava-labs/avalanchego/vms/avm/txs" ) -var _ txs.Visitor = &txInit{} +var _ txs.Visitor = (*txInit)(nil) // Init initializes FxID where required type txInit struct { diff --git a/vms/avm/tx_semantic_verify.go b/vms/avm/tx_semantic_verify.go index a3933a9e2e9..9198c3aa3e7 100644 --- a/vms/avm/tx_semantic_verify.go +++ b/vms/avm/tx_semantic_verify.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/vms/components/verify" ) -var _ txs.Visitor = &txSemanticVerify{} +var _ txs.Visitor = (*txSemanticVerify)(nil) // SemanticVerify that this transaction is well-formed. type txSemanticVerify struct { diff --git a/vms/avm/txs/base_tx.go b/vms/avm/txs/base_tx.go index 450962a4414..38050d548cf 100644 --- a/vms/avm/txs/base_tx.go +++ b/vms/avm/txs/base_tx.go @@ -12,8 +12,8 @@ import ( ) var ( - _ UnsignedTx = &BaseTx{} - _ secp256k1fx.UnsignedTx = &BaseTx{} + _ UnsignedTx = (*BaseTx)(nil) + _ secp256k1fx.UnsignedTx = (*BaseTx)(nil) ) // BaseTx is the basis of all transactions. diff --git a/vms/avm/txs/codec.go b/vms/avm/txs/codec.go index 63f0973829c..4ac49929126 100644 --- a/vms/avm/txs/codec.go +++ b/vms/avm/txs/codec.go @@ -14,8 +14,8 @@ import ( ) var ( - _ codec.Registry = &codecRegistry{} - _ secp256k1fx.VM = &fxVM{} + _ codec.Registry = (*codecRegistry)(nil) + _ secp256k1fx.VM = (*fxVM)(nil) ) type codecRegistry struct { diff --git a/vms/avm/txs/create_asset_tx.go b/vms/avm/txs/create_asset_tx.go index ebeebb9795f..fe7fafa6507 100644 --- a/vms/avm/txs/create_asset_tx.go +++ b/vms/avm/txs/create_asset_tx.go @@ -36,8 +36,8 @@ var ( errUnexpectedWhitespace = errors.New("unexpected whitespace provided") errDenominationTooLarge = errors.New("denomination is too large") - _ UnsignedTx = &CreateAssetTx{} - _ secp256k1fx.UnsignedTx = &CreateAssetTx{} + _ UnsignedTx = (*CreateAssetTx)(nil) + _ secp256k1fx.UnsignedTx = (*CreateAssetTx)(nil) ) // CreateAssetTx is a transaction that creates a new asset. diff --git a/vms/avm/txs/export_tx.go b/vms/avm/txs/export_tx.go index 5d9014fe70b..1eb8cda063d 100644 --- a/vms/avm/txs/export_tx.go +++ b/vms/avm/txs/export_tx.go @@ -16,8 +16,8 @@ import ( var ( errNoExportOutputs = errors.New("no export outputs") - _ UnsignedTx = &ExportTx{} - _ secp256k1fx.UnsignedTx = &ExportTx{} + _ UnsignedTx = (*ExportTx)(nil) + _ secp256k1fx.UnsignedTx = (*ExportTx)(nil) ) // ExportTx is a transaction that exports an asset to another blockchain. diff --git a/vms/avm/txs/import_tx.go b/vms/avm/txs/import_tx.go index efdc892b4f8..d967ea54101 100644 --- a/vms/avm/txs/import_tx.go +++ b/vms/avm/txs/import_tx.go @@ -16,8 +16,8 @@ import ( var ( errNoImportInputs = errors.New("no import inputs") - _ UnsignedTx = &ImportTx{} - _ secp256k1fx.UnsignedTx = &ImportTx{} + _ UnsignedTx = (*ImportTx)(nil) + _ secp256k1fx.UnsignedTx = (*ImportTx)(nil) ) // ImportTx is a transaction that imports an asset from another blockchain. diff --git a/vms/avm/txs/operation_tx.go b/vms/avm/txs/operation_tx.go index 45239661829..8d90a191286 100644 --- a/vms/avm/txs/operation_tx.go +++ b/vms/avm/txs/operation_tx.go @@ -18,8 +18,8 @@ var ( errNoOperations = errors.New("an operationTx must have at least one operation") errDoubleSpend = errors.New("inputs attempt to double spend an input") - _ UnsignedTx = &OperationTx{} - _ secp256k1fx.UnsignedTx = &OperationTx{} + _ UnsignedTx = (*OperationTx)(nil) + _ secp256k1fx.UnsignedTx = (*OperationTx)(nil) ) // OperationTx is a transaction with no credentials. diff --git a/vms/avm/txs/parser.go b/vms/avm/txs/parser.go index b070250b4c7..4268cd7a14e 100644 --- a/vms/avm/txs/parser.go +++ b/vms/avm/txs/parser.go @@ -19,7 +19,7 @@ import ( const CodecVersion = 0 -var _ Parser = &parser{} +var _ Parser = (*parser)(nil) type Parser interface { Codec() codec.Manager diff --git a/vms/avm/txs/visitor.go b/vms/avm/txs/visitor.go index 6a11c745f34..953ef704413 100644 --- a/vms/avm/txs/visitor.go +++ b/vms/avm/txs/visitor.go @@ -5,7 +5,7 @@ package txs import "github.com/ava-labs/avalanchego/vms/components/avax" -var _ Visitor = &utxoGetter{} +var _ Visitor = (*utxoGetter)(nil) // Allow vm to execute custom logic against the underlying transaction types. type Visitor interface { diff --git a/vms/avm/unique_tx.go b/vms/avm/unique_tx.go index a11eb6bb9b7..4a3f71afa2d 100644 --- a/vms/avm/unique_tx.go +++ b/vms/avm/unique_tx.go @@ -25,8 +25,8 @@ var ( ) var ( - _ snowstorm.Tx = &UniqueTx{} - _ cache.Evictable = &UniqueTx{} + _ snowstorm.Tx = (*UniqueTx)(nil) + _ cache.Evictable = (*UniqueTx)(nil) ) // UniqueTx provides a de-duplication service for txs. This only provides a diff --git a/vms/avm/vm.go b/vms/avm/vm.go index 820ea4d3dca..e6d1444f1cc 100644 --- a/vms/avm/vm.go +++ b/vms/avm/vm.go @@ -61,7 +61,7 @@ var ( errBootstrapping = errors.New("chain is currently bootstrapping") errInsufficientFunds = errors.New("insufficient funds") - _ vertex.DAGVM = &VM{} + _ vertex.DAGVM = (*VM)(nil) ) type VM struct { diff --git a/vms/avm/wallet_client.go b/vms/avm/wallet_client.go index 1f65bc0b66d..fc9f5845849 100644 --- a/vms/avm/wallet_client.go +++ b/vms/avm/wallet_client.go @@ -15,7 +15,7 @@ import ( "github.com/ava-labs/avalanchego/utils/rpc" ) -var _ WalletClient = &client{} +var _ WalletClient = (*client)(nil) // interface of an AVM wallet client for interacting with avm managed wallet on [chain] type WalletClient interface { diff --git a/vms/components/avax/addresses.go b/vms/components/avax/addresses.go index db1f97b01a3..f1ec9147938 100644 --- a/vms/components/avax/addresses.go +++ b/vms/components/avax/addresses.go @@ -12,7 +12,7 @@ import ( "github.com/ava-labs/avalanchego/utils/formatting/address" ) -var _ AddressManager = &addressManager{} +var _ AddressManager = (*addressManager)(nil) type AddressManager interface { // ParseLocalAddress takes in an address for this chain and produces the ID diff --git a/vms/components/avax/asset.go b/vms/components/avax/asset.go index 975c1e3cbd9..0d94b3f349e 100644 --- a/vms/components/avax/asset.go +++ b/vms/components/avax/asset.go @@ -14,7 +14,7 @@ var ( errNilAssetID = errors.New("nil asset ID is not valid") errEmptyAssetID = errors.New("empty asset ID is not valid") - _ verify.Verifiable = &Asset{} + _ verify.Verifiable = (*Asset)(nil) ) type Asset struct { diff --git a/vms/components/avax/atomic_utxos.go b/vms/components/avax/atomic_utxos.go index b129360649d..69447090f48 100644 --- a/vms/components/avax/atomic_utxos.go +++ b/vms/components/avax/atomic_utxos.go @@ -11,7 +11,7 @@ import ( "github.com/ava-labs/avalanchego/ids" ) -var _ AtomicUTXOManager = &atomicUTXOManager{} +var _ AtomicUTXOManager = (*atomicUTXOManager)(nil) type AtomicUTXOManager interface { // GetAtomicUTXOs returns exported UTXOs such that at least one of the diff --git a/vms/components/avax/metadata.go b/vms/components/avax/metadata.go index 6dcb9db3c10..c4af7d7d44c 100644 --- a/vms/components/avax/metadata.go +++ b/vms/components/avax/metadata.go @@ -15,7 +15,7 @@ var ( errNilMetadata = errors.New("nil metadata is not valid") errMetadataNotInitialize = errors.New("metadata was never initialized and is not valid") - _ verify.Verifiable = &Metadata{} + _ verify.Verifiable = (*Metadata)(nil) ) // TODO: Delete this once the downstream dependencies have been updated. diff --git a/vms/components/avax/singleton_state.go b/vms/components/avax/singleton_state.go index 36113089d15..62d069c95d6 100644 --- a/vms/components/avax/singleton_state.go +++ b/vms/components/avax/singleton_state.go @@ -13,7 +13,7 @@ const ( var ( isInitializedKey = []byte{IsInitializedKey} - _ SingletonState = &singletonState{} + _ SingletonState = (*singletonState)(nil) ) // SingletonState is a thin wrapper around a database to provide, caching, diff --git a/vms/components/avax/transferables.go b/vms/components/avax/transferables.go index 1ae440302b5..a7db20e5603 100644 --- a/vms/components/avax/transferables.go +++ b/vms/components/avax/transferables.go @@ -25,8 +25,8 @@ var ( errNilTransferableFxInput = errors.New("nil transferable feature extension input is not valid") errInputsNotSortedUnique = errors.New("inputs not sorted and unique") - _ verify.Verifiable = &TransferableOutput{} - _ verify.Verifiable = &TransferableInput{} + _ verify.Verifiable = (*TransferableOutput)(nil) + _ verify.Verifiable = (*TransferableInput)(nil) ) // Amounter is a data structure that has an amount of something associated with it diff --git a/vms/components/avax/utxo.go b/vms/components/avax/utxo.go index 6e1c90d18ad..bb73a162341 100644 --- a/vms/components/avax/utxo.go +++ b/vms/components/avax/utxo.go @@ -13,7 +13,7 @@ var ( errNilUTXO = errors.New("nil utxo is not valid") errEmptyUTXO = errors.New("empty utxo is not valid") - _ verify.Verifiable = &UTXO{} + _ verify.Verifiable = (*UTXO)(nil) ) type UTXO struct { diff --git a/vms/components/avax/utxo_id.go b/vms/components/avax/utxo_id.go index b39177f7985..fb0f9a552ea 100644 --- a/vms/components/avax/utxo_id.go +++ b/vms/components/avax/utxo_id.go @@ -17,7 +17,7 @@ import ( var ( errNilUTXOID = errors.New("nil utxo ID is not valid") - _ verify.Verifiable = &UTXOID{} + _ verify.Verifiable = (*UTXOID)(nil) ) type UTXOID struct { diff --git a/vms/components/chain/state_test.go b/vms/components/chain/state_test.go index c665d782de2..843c3ef71a6 100644 --- a/vms/components/chain/state_test.go +++ b/vms/components/chain/state_test.go @@ -20,7 +20,7 @@ import ( "github.com/ava-labs/avalanchego/utils/hashing" ) -var _ Block = &TestBlock{} +var _ Block = (*TestBlock)(nil) type TestBlock struct { *snowman.TestBlock diff --git a/vms/components/index/index.go b/vms/components/index/index.go index eceeddebec4..9b8dc0006fb 100644 --- a/vms/components/index/index.go +++ b/vms/components/index/index.go @@ -27,8 +27,8 @@ var ( errIndexingRequiredFromGenesis = errors.New("running would create incomplete index. Allow incomplete indices or re-sync from genesis with indexing enabled") errCausesIncompleteIndex = errors.New("running would create incomplete index. Allow incomplete indices or enable indexing") - _ AddressTxsIndexer = &indexer{} - _ AddressTxsIndexer = &noIndexer{} + _ AddressTxsIndexer = (*indexer)(nil) + _ AddressTxsIndexer = (*noIndexer)(nil) ) // AddressTxsIndexer maintains information about which transactions changed diff --git a/vms/components/keystore/user.go b/vms/components/keystore/user.go index 9224cf89572..d71fef0d378 100644 --- a/vms/components/keystore/user.go +++ b/vms/components/keystore/user.go @@ -25,7 +25,7 @@ var ( errMaxAddresses = fmt.Errorf("keystore user has reached its limit of %d addresses", maxKeystoreAddresses) - _ User = &user{} + _ User = (*user)(nil) ) type User interface { diff --git a/vms/components/state/state.go b/vms/components/state/state.go index cb927a8bc29..f0723ef109b 100644 --- a/vms/components/state/state.go +++ b/vms/components/state/state.go @@ -20,7 +20,7 @@ const cacheSize = 1000 var ( errWrongType = errors.New("value in the database was the wrong type") - _ State = &state{} + _ State = (*state)(nil) ) // State is a key-value store where every value is associated with a "type ID". diff --git a/vms/manager.go b/vms/manager.go index d11dd2cbfc5..8743b9d81b9 100644 --- a/vms/manager.go +++ b/vms/manager.go @@ -15,7 +15,7 @@ import ( var ( ErrNotFound = errors.New("not found") - _ Manager = &manager{} + _ Manager = (*manager)(nil) ) // A Factory creates new instances of a VM diff --git a/vms/metervm/block.go b/vms/metervm/block.go index ade13ca82f0..14e8ef289ea 100644 --- a/vms/metervm/block.go +++ b/vms/metervm/block.go @@ -6,8 +6,8 @@ package metervm import "github.com/ava-labs/avalanchego/snow/consensus/snowman" var ( - _ snowman.Block = &meterBlock{} - _ snowman.OracleBlock = &meterBlock{} + _ snowman.Block = (*meterBlock)(nil) + _ snowman.OracleBlock = (*meterBlock)(nil) ) type meterBlock struct { diff --git a/vms/metervm/block_vm.go b/vms/metervm/block_vm.go index 102e543781a..b0894f3b73a 100644 --- a/vms/metervm/block_vm.go +++ b/vms/metervm/block_vm.go @@ -17,10 +17,10 @@ import ( ) var ( - _ block.ChainVM = &blockVM{} - _ block.BatchedChainVM = &blockVM{} - _ block.HeightIndexedChainVM = &blockVM{} - _ block.StateSyncableVM = &blockVM{} + _ block.ChainVM = (*blockVM)(nil) + _ block.BatchedChainVM = (*blockVM)(nil) + _ block.HeightIndexedChainVM = (*blockVM)(nil) + _ block.StateSyncableVM = (*blockVM)(nil) ) type blockVM struct { diff --git a/vms/metervm/vertex_vm.go b/vms/metervm/vertex_vm.go index 59995e1edfb..7ab08355a59 100644 --- a/vms/metervm/vertex_vm.go +++ b/vms/metervm/vertex_vm.go @@ -17,8 +17,8 @@ import ( ) var ( - _ vertex.DAGVM = &vertexVM{} - _ snowstorm.Tx = &meterTx{} + _ vertex.DAGVM = (*vertexVM)(nil) + _ snowstorm.Tx = (*meterTx)(nil) ) func NewVertexVM(vm vertex.DAGVM) vertex.DAGVM { diff --git a/vms/nftfx/factory.go b/vms/nftfx/factory.go index ddcd585b922..ab54adcd459 100644 --- a/vms/nftfx/factory.go +++ b/vms/nftfx/factory.go @@ -10,7 +10,7 @@ import ( ) var ( - _ vms.Factory = &Factory{} + _ vms.Factory = (*Factory)(nil) // ID that this Fx uses when labeled ID = ids.ID{'n', 'f', 't', 'f', 'x'} diff --git a/vms/nftfx/transfer_output.go b/vms/nftfx/transfer_output.go index a4adb5ed817..d84f009e931 100644 --- a/vms/nftfx/transfer_output.go +++ b/vms/nftfx/transfer_output.go @@ -22,7 +22,7 @@ const ( var ( errNilTransferOutput = errors.New("nil transfer output") errPayloadTooLarge = errors.New("payload too large") - _ verify.State = &TransferOutput{} + _ verify.State = (*TransferOutput)(nil) ) type TransferOutput struct { diff --git a/vms/platformvm/api/static_client.go b/vms/platformvm/api/static_client.go index a4ed2445da4..945c39ac7ad 100644 --- a/vms/platformvm/api/static_client.go +++ b/vms/platformvm/api/static_client.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/utils/rpc" ) -var _ StaticClient = &staticClient{} +var _ StaticClient = (*staticClient)(nil) // StaticClient for interacting with the platformvm static api type StaticClient interface { diff --git a/vms/platformvm/blocks/abort_block.go b/vms/platformvm/blocks/abort_block.go index d0e2152a0ab..c1580eefbf5 100644 --- a/vms/platformvm/blocks/abort_block.go +++ b/vms/platformvm/blocks/abort_block.go @@ -12,8 +12,8 @@ import ( ) var ( - _ BanffBlock = &BanffAbortBlock{} - _ Block = &ApricotAbortBlock{} + _ BanffBlock = (*BanffAbortBlock)(nil) + _ Block = (*ApricotAbortBlock)(nil) ) type BanffAbortBlock struct { diff --git a/vms/platformvm/blocks/atomic_block.go b/vms/platformvm/blocks/atomic_block.go index 5ac8389b534..84bc6b71ebd 100644 --- a/vms/platformvm/blocks/atomic_block.go +++ b/vms/platformvm/blocks/atomic_block.go @@ -11,7 +11,7 @@ import ( "github.com/ava-labs/avalanchego/vms/platformvm/txs" ) -var _ Block = &ApricotAtomicBlock{} +var _ Block = (*ApricotAtomicBlock)(nil) // ApricotAtomicBlock being accepted results in the atomic transaction contained // in the block to be accepted and committed to the chain. diff --git a/vms/platformvm/blocks/builder/builder.go b/vms/platformvm/blocks/builder/builder.go index e713ad93a90..7f045e5dae4 100644 --- a/vms/platformvm/blocks/builder/builder.go +++ b/vms/platformvm/blocks/builder/builder.go @@ -31,7 +31,7 @@ import ( const targetBlockSize = 128 * units.KiB var ( - _ Builder = &builder{} + _ Builder = (*builder)(nil) errEndOfTime = errors.New("program time is suspiciously far in the future") errNoPendingBlocks = errors.New("no pending blocks") diff --git a/vms/platformvm/blocks/builder/network.go b/vms/platformvm/blocks/builder/network.go index e2af327e019..b81deb61dcb 100644 --- a/vms/platformvm/blocks/builder/network.go +++ b/vms/platformvm/blocks/builder/network.go @@ -25,7 +25,7 @@ const ( recentCacheSize = 512 ) -var _ Network = &network{} +var _ Network = (*network)(nil) type Network interface { common.AppHandler diff --git a/vms/platformvm/blocks/commit_block.go b/vms/platformvm/blocks/commit_block.go index 543af466d46..8bcf1d8fb58 100644 --- a/vms/platformvm/blocks/commit_block.go +++ b/vms/platformvm/blocks/commit_block.go @@ -12,8 +12,8 @@ import ( ) var ( - _ BanffBlock = &BanffCommitBlock{} - _ Block = &ApricotCommitBlock{} + _ BanffBlock = (*BanffCommitBlock)(nil) + _ Block = (*ApricotCommitBlock)(nil) ) type BanffCommitBlock struct { diff --git a/vms/platformvm/blocks/executor/acceptor.go b/vms/platformvm/blocks/executor/acceptor.go index 65a82954a5a..34f7700877a 100644 --- a/vms/platformvm/blocks/executor/acceptor.go +++ b/vms/platformvm/blocks/executor/acceptor.go @@ -17,7 +17,7 @@ import ( "github.com/ava-labs/avalanchego/vms/platformvm/state" ) -var _ blocks.Visitor = &acceptor{} +var _ blocks.Visitor = (*acceptor)(nil) // acceptor handles the logic for accepting a block. // All errors returned by this struct are fatal and should result in the chain diff --git a/vms/platformvm/blocks/executor/block.go b/vms/platformvm/blocks/executor/block.go index b87131cab56..7880d731888 100644 --- a/vms/platformvm/blocks/executor/block.go +++ b/vms/platformvm/blocks/executor/block.go @@ -16,8 +16,8 @@ import ( ) var ( - _ snowman.Block = &Block{} - _ snowman.OracleBlock = &Block{} + _ snowman.Block = (*Block)(nil) + _ snowman.OracleBlock = (*Block)(nil) ) // Exported for testing in platformvm package. diff --git a/vms/platformvm/blocks/executor/helpers_test.go b/vms/platformvm/blocks/executor/helpers_test.go index d5913039296..f6538e1d737 100644 --- a/vms/platformvm/blocks/executor/helpers_test.go +++ b/vms/platformvm/blocks/executor/helpers_test.go @@ -66,7 +66,7 @@ const ( ) var ( - _ mempool.BlockTimer = &environment{} + _ mempool.BlockTimer = (*environment)(nil) defaultMinStakingDuration = 24 * time.Hour defaultMaxStakingDuration = 365 * 24 * time.Hour diff --git a/vms/platformvm/blocks/executor/manager.go b/vms/platformvm/blocks/executor/manager.go index c180276364f..343671ce0f8 100644 --- a/vms/platformvm/blocks/executor/manager.go +++ b/vms/platformvm/blocks/executor/manager.go @@ -14,7 +14,7 @@ import ( "github.com/ava-labs/avalanchego/vms/platformvm/txs/mempool" ) -var _ Manager = &manager{} +var _ Manager = (*manager)(nil) type Manager interface { state.Versions diff --git a/vms/platformvm/blocks/executor/options.go b/vms/platformvm/blocks/executor/options.go index e455a7b7116..8495020d638 100644 --- a/vms/platformvm/blocks/executor/options.go +++ b/vms/platformvm/blocks/executor/options.go @@ -10,7 +10,7 @@ import ( "github.com/ava-labs/avalanchego/vms/platformvm/blocks" ) -var _ blocks.Visitor = &verifier{} +var _ blocks.Visitor = (*verifier)(nil) // options supports build new option blocks type options struct { diff --git a/vms/platformvm/blocks/executor/rejector.go b/vms/platformvm/blocks/executor/rejector.go index 5fbdac2cc9e..c5461136580 100644 --- a/vms/platformvm/blocks/executor/rejector.go +++ b/vms/platformvm/blocks/executor/rejector.go @@ -10,7 +10,7 @@ import ( "github.com/ava-labs/avalanchego/vms/platformvm/blocks" ) -var _ blocks.Visitor = &rejector{} +var _ blocks.Visitor = (*rejector)(nil) // rejector handles the logic for rejecting a block. // All errors returned by this struct are fatal and should result in the chain diff --git a/vms/platformvm/blocks/executor/verifier.go b/vms/platformvm/blocks/executor/verifier.go index b58deef5142..394aa78deec 100644 --- a/vms/platformvm/blocks/executor/verifier.go +++ b/vms/platformvm/blocks/executor/verifier.go @@ -17,7 +17,7 @@ import ( ) var ( - _ blocks.Visitor = &verifier{} + _ blocks.Visitor = (*verifier)(nil) errApricotBlockIssuedAfterFork = errors.New("apricot block issued after fork") errBanffProposalBlockWithMultipleTransactions = errors.New("BanffProposalBlock contains multiple transactions") diff --git a/vms/platformvm/blocks/proposal_block.go b/vms/platformvm/blocks/proposal_block.go index 7c05254c4ea..cde1c74c32d 100644 --- a/vms/platformvm/blocks/proposal_block.go +++ b/vms/platformvm/blocks/proposal_block.go @@ -13,8 +13,8 @@ import ( ) var ( - _ BanffBlock = &BanffProposalBlock{} - _ Block = &ApricotProposalBlock{} + _ BanffBlock = (*BanffProposalBlock)(nil) + _ Block = (*ApricotProposalBlock)(nil) ) type BanffProposalBlock struct { diff --git a/vms/platformvm/blocks/standard_block.go b/vms/platformvm/blocks/standard_block.go index e7e8e88f37d..34815c51cbc 100644 --- a/vms/platformvm/blocks/standard_block.go +++ b/vms/platformvm/blocks/standard_block.go @@ -13,8 +13,8 @@ import ( ) var ( - _ BanffBlock = &BanffStandardBlock{} - _ Block = &ApricotStandardBlock{} + _ BanffBlock = (*BanffStandardBlock)(nil) + _ Block = (*ApricotStandardBlock)(nil) ) type BanffStandardBlock struct { diff --git a/vms/platformvm/client.go b/vms/platformvm/client.go index acda578263a..f1e1dc7e4ed 100644 --- a/vms/platformvm/client.go +++ b/vms/platformvm/client.go @@ -20,7 +20,7 @@ import ( platformapi "github.com/ava-labs/avalanchego/vms/platformvm/api" ) -var _ Client = &client{} +var _ Client = (*client)(nil) // Client interface for interacting with the P Chain endpoint type Client interface { diff --git a/vms/platformvm/factory.go b/vms/platformvm/factory.go index 045c93a43e9..8993d6be3fb 100644 --- a/vms/platformvm/factory.go +++ b/vms/platformvm/factory.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/vms/platformvm/config" ) -var _ vms.Factory = &Factory{} +var _ vms.Factory = (*Factory)(nil) // Factory can create new instances of the Platform Chain type Factory struct { diff --git a/vms/platformvm/fx/fx.go b/vms/platformvm/fx/fx.go index d2f15ad035f..0d726019f64 100644 --- a/vms/platformvm/fx/fx.go +++ b/vms/platformvm/fx/fx.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/vms/secp256k1fx" ) -var _ Fx = &secp256k1fx.Fx{} +var _ Fx = (*secp256k1fx.Fx)(nil) // Fx is the interface a feature extension must implement to support the // Platform Chain. diff --git a/vms/platformvm/message/message.go b/vms/platformvm/message/message.go index 121a61d51e0..7565cf47a75 100644 --- a/vms/platformvm/message/message.go +++ b/vms/platformvm/message/message.go @@ -10,7 +10,7 @@ import ( ) var ( - _ Message = &Tx{} + _ Message = (*Tx)(nil) errUnexpectedCodecVersion = errors.New("unexpected codec version") ) diff --git a/vms/platformvm/metrics/block_metrics.go b/vms/platformvm/metrics/block_metrics.go index 1a10267bf57..31e8d77986b 100644 --- a/vms/platformvm/metrics/block_metrics.go +++ b/vms/platformvm/metrics/block_metrics.go @@ -12,7 +12,7 @@ import ( "github.com/ava-labs/avalanchego/vms/platformvm/blocks" ) -var _ blocks.Visitor = &blockMetrics{} +var _ blocks.Visitor = (*blockMetrics)(nil) type blockMetrics struct { txMetrics *txMetrics diff --git a/vms/platformvm/metrics/metrics.go b/vms/platformvm/metrics/metrics.go index 18cc253d3e2..f3e47175068 100644 --- a/vms/platformvm/metrics/metrics.go +++ b/vms/platformvm/metrics/metrics.go @@ -14,7 +14,7 @@ import ( "github.com/ava-labs/avalanchego/vms/platformvm/blocks" ) -var _ Metrics = &metrics{} +var _ Metrics = (*metrics)(nil) type Metrics interface { metric.APIInterceptor diff --git a/vms/platformvm/metrics/tx_metrics.go b/vms/platformvm/metrics/tx_metrics.go index a47757e8780..962eb407a88 100644 --- a/vms/platformvm/metrics/tx_metrics.go +++ b/vms/platformvm/metrics/tx_metrics.go @@ -12,7 +12,7 @@ import ( "github.com/ava-labs/avalanchego/vms/platformvm/txs" ) -var _ txs.Visitor = &txMetrics{} +var _ txs.Visitor = (*txMetrics)(nil) type txMetrics struct { numAddDelegatorTxs, diff --git a/vms/platformvm/reward/calculator.go b/vms/platformvm/reward/calculator.go index 00d2f07293e..9f75c98a7f1 100644 --- a/vms/platformvm/reward/calculator.go +++ b/vms/platformvm/reward/calculator.go @@ -8,7 +8,7 @@ import ( "time" ) -var _ Calculator = &calculator{} +var _ Calculator = (*calculator)(nil) type Calculator interface { Calculate(stakedDuration time.Duration, stakedAmount, currentSupply uint64) uint64 diff --git a/vms/platformvm/signer/empty.go b/vms/platformvm/signer/empty.go index 4e2eba8a644..51b28ad765d 100644 --- a/vms/platformvm/signer/empty.go +++ b/vms/platformvm/signer/empty.go @@ -7,7 +7,7 @@ import ( "github.com/ava-labs/avalanchego/utils/crypto/bls" ) -var _ Signer = &Empty{} +var _ Signer = (*Empty)(nil) type Empty struct{} diff --git a/vms/platformvm/signer/proof_of_possession.go b/vms/platformvm/signer/proof_of_possession.go index 0297c753303..b8b3fde26b1 100644 --- a/vms/platformvm/signer/proof_of_possession.go +++ b/vms/platformvm/signer/proof_of_possession.go @@ -12,7 +12,7 @@ import ( ) var ( - _ Signer = &ProofOfPossession{} + _ Signer = (*ProofOfPossession)(nil) errInvalidProofOfPossession = errors.New("invalid proof of possession") ) diff --git a/vms/platformvm/state/diff.go b/vms/platformvm/state/diff.go index f3475168069..7d873c27cb8 100644 --- a/vms/platformvm/state/diff.go +++ b/vms/platformvm/state/diff.go @@ -16,7 +16,7 @@ import ( ) var ( - _ Diff = &diff{} + _ Diff = (*diff)(nil) ErrMissingParentState = errors.New("missing parent state") ) diff --git a/vms/platformvm/state/masked_iterator.go b/vms/platformvm/state/masked_iterator.go index c8bd4c19a74..5d30ed8ec57 100644 --- a/vms/platformvm/state/masked_iterator.go +++ b/vms/platformvm/state/masked_iterator.go @@ -7,7 +7,7 @@ import ( "github.com/ava-labs/avalanchego/ids" ) -var _ StakerIterator = &maskedIterator{} +var _ StakerIterator = (*maskedIterator)(nil) type maskedIterator struct { parentIterator StakerIterator diff --git a/vms/platformvm/state/merged_iterator.go b/vms/platformvm/state/merged_iterator.go index 4f128fa7a57..c741e74aefa 100644 --- a/vms/platformvm/state/merged_iterator.go +++ b/vms/platformvm/state/merged_iterator.go @@ -8,8 +8,8 @@ import ( ) var ( - _ StakerIterator = &mergedIterator{} - _ heap.Interface = &mergedIterator{} + _ StakerIterator = (*mergedIterator)(nil) + _ heap.Interface = (*mergedIterator)(nil) ) type mergedIterator struct { diff --git a/vms/platformvm/state/slice_iterator_test.go b/vms/platformvm/state/slice_iterator_test.go index 8dbf4ed34bd..a5839b71163 100644 --- a/vms/platformvm/state/slice_iterator_test.go +++ b/vms/platformvm/state/slice_iterator_test.go @@ -3,7 +3,7 @@ package state -var _ StakerIterator = &sliceIterator{} +var _ StakerIterator = (*sliceIterator)(nil) type sliceIterator struct { index int diff --git a/vms/platformvm/state/staker.go b/vms/platformvm/state/staker.go index afc19bb0eb1..301ac338c8f 100644 --- a/vms/platformvm/state/staker.go +++ b/vms/platformvm/state/staker.go @@ -13,7 +13,7 @@ import ( "github.com/ava-labs/avalanchego/vms/platformvm/txs" ) -var _ btree.Item = &Staker{} +var _ btree.Item = (*Staker)(nil) // StakerIterator defines an interface for iterating over a set of stakers. type StakerIterator interface { diff --git a/vms/platformvm/state/staker_diff_iterator.go b/vms/platformvm/state/staker_diff_iterator.go index d3691ef9792..c518c7d8528 100644 --- a/vms/platformvm/state/staker_diff_iterator.go +++ b/vms/platformvm/state/staker_diff_iterator.go @@ -10,9 +10,9 @@ import ( ) var ( - _ StakerDiffIterator = &stakerDiffIterator{} - _ StakerIterator = &mutableStakerIterator{} - _ heap.Interface = &mutableStakerIterator{} + _ StakerDiffIterator = (*stakerDiffIterator)(nil) + _ StakerIterator = (*mutableStakerIterator)(nil) + _ heap.Interface = (*mutableStakerIterator)(nil) ) // StakerDiffIterator is an iterator that iterates over the events that will be diff --git a/vms/platformvm/state/state.go b/vms/platformvm/state/state.go index 12634ad51ff..4623829e861 100644 --- a/vms/platformvm/state/state.go +++ b/vms/platformvm/state/state.go @@ -47,7 +47,7 @@ const ( ) var ( - _ State = &state{} + _ State = (*state)(nil) ErrDelegatorSubset = errors.New("delegator's time range must be a subset of the validator's time range") diff --git a/vms/platformvm/state/tree_iterator.go b/vms/platformvm/state/tree_iterator.go index 315cd62c9e3..b700bc894f0 100644 --- a/vms/platformvm/state/tree_iterator.go +++ b/vms/platformvm/state/tree_iterator.go @@ -11,7 +11,7 @@ import ( const defaultTreeDegree = 2 -var _ StakerIterator = &treeIterator{} +var _ StakerIterator = (*treeIterator)(nil) type treeIterator struct { current *Staker diff --git a/vms/platformvm/txs/add_delegator_tx.go b/vms/platformvm/txs/add_delegator_tx.go index ae206a8fc23..711ffcf3bc2 100644 --- a/vms/platformvm/txs/add_delegator_tx.go +++ b/vms/platformvm/txs/add_delegator_tx.go @@ -20,7 +20,7 @@ import ( ) var ( - _ DelegatorTx = &AddDelegatorTx{} + _ DelegatorTx = (*AddDelegatorTx)(nil) errDelegatorWeightMismatch = errors.New("delegator weight is not equal to total stake weight") ) diff --git a/vms/platformvm/txs/add_permissionless_delegator_tx.go b/vms/platformvm/txs/add_permissionless_delegator_tx.go index eadd23ee7df..ac6789d518f 100644 --- a/vms/platformvm/txs/add_permissionless_delegator_tx.go +++ b/vms/platformvm/txs/add_permissionless_delegator_tx.go @@ -18,7 +18,7 @@ import ( "github.com/ava-labs/avalanchego/vms/secp256k1fx" ) -var _ DelegatorTx = &AddPermissionlessDelegatorTx{} +var _ DelegatorTx = (*AddPermissionlessDelegatorTx)(nil) // AddPermissionlessDelegatorTx is an unsigned addPermissionlessDelegatorTx type AddPermissionlessDelegatorTx struct { diff --git a/vms/platformvm/txs/add_permissionless_validator_tx.go b/vms/platformvm/txs/add_permissionless_validator_tx.go index 33fb6396e2a..7c62f8b8026 100644 --- a/vms/platformvm/txs/add_permissionless_validator_tx.go +++ b/vms/platformvm/txs/add_permissionless_validator_tx.go @@ -22,7 +22,7 @@ import ( ) var ( - _ ValidatorTx = &AddPermissionlessValidatorTx{} + _ ValidatorTx = (*AddPermissionlessValidatorTx)(nil) errEmptyNodeID = errors.New("validator nodeID cannot be empty") errNoStake = errors.New("no stake") diff --git a/vms/platformvm/txs/add_subnet_validator_tx.go b/vms/platformvm/txs/add_subnet_validator_tx.go index 3cc50d40b52..e48d3e21575 100644 --- a/vms/platformvm/txs/add_subnet_validator_tx.go +++ b/vms/platformvm/txs/add_subnet_validator_tx.go @@ -15,7 +15,7 @@ import ( ) var ( - _ StakerTx = &AddSubnetValidatorTx{} + _ StakerTx = (*AddSubnetValidatorTx)(nil) errAddPrimaryNetworkValidator = errors.New("can't add primary network validator with AddSubnetValidatorTx") ) diff --git a/vms/platformvm/txs/add_validator_tx.go b/vms/platformvm/txs/add_validator_tx.go index aaeb73536d5..bc397467089 100644 --- a/vms/platformvm/txs/add_validator_tx.go +++ b/vms/platformvm/txs/add_validator_tx.go @@ -20,7 +20,7 @@ import ( ) var ( - _ ValidatorTx = &AddValidatorTx{} + _ ValidatorTx = (*AddValidatorTx)(nil) errTooManyShares = fmt.Errorf("a staker can only require at most %d shares from delegators", reward.PercentDenominator) ) diff --git a/vms/platformvm/txs/advance_time_tx.go b/vms/platformvm/txs/advance_time_tx.go index 67f6ec674ad..3fd2dcb2813 100644 --- a/vms/platformvm/txs/advance_time_tx.go +++ b/vms/platformvm/txs/advance_time_tx.go @@ -11,7 +11,7 @@ import ( "github.com/ava-labs/avalanchego/vms/components/avax" ) -var _ UnsignedTx = &AdvanceTimeTx{} +var _ UnsignedTx = (*AdvanceTimeTx)(nil) // AdvanceTimeTx is a transaction to increase the chain's timestamp. // When the chain's timestamp is updated (a AdvanceTimeTx is accepted and diff --git a/vms/platformvm/txs/builder/builder.go b/vms/platformvm/txs/builder/builder.go index 9e1bbb9c0d0..1ca1a3bda3b 100644 --- a/vms/platformvm/txs/builder/builder.go +++ b/vms/platformvm/txs/builder/builder.go @@ -27,7 +27,7 @@ import ( const MaxPageSize = 1024 var ( - _ Builder = &builder{} + _ Builder = (*builder)(nil) errNoFunds = errors.New("no spendable funds were found") ) diff --git a/vms/platformvm/txs/create_chain_tx.go b/vms/platformvm/txs/create_chain_tx.go index 75679513877..95d6e73f772 100644 --- a/vms/platformvm/txs/create_chain_tx.go +++ b/vms/platformvm/txs/create_chain_tx.go @@ -20,7 +20,7 @@ const ( ) var ( - _ UnsignedTx = &CreateChainTx{} + _ UnsignedTx = (*CreateChainTx)(nil) ErrCantValidatePrimaryNetwork = errors.New("new blockchain can't be validated by primary network") diff --git a/vms/platformvm/txs/create_subnet_tx.go b/vms/platformvm/txs/create_subnet_tx.go index a119000c223..2a97c0ea7ec 100644 --- a/vms/platformvm/txs/create_subnet_tx.go +++ b/vms/platformvm/txs/create_subnet_tx.go @@ -8,7 +8,7 @@ import ( "github.com/ava-labs/avalanchego/vms/platformvm/fx" ) -var _ UnsignedTx = &CreateSubnetTx{} +var _ UnsignedTx = (*CreateSubnetTx)(nil) // CreateSubnetTx is an unsigned proposal to create a new subnet type CreateSubnetTx struct { diff --git a/vms/platformvm/txs/executor/atomic_tx_executor.go b/vms/platformvm/txs/executor/atomic_tx_executor.go index ade0dc51c19..bccffeff039 100644 --- a/vms/platformvm/txs/executor/atomic_tx_executor.go +++ b/vms/platformvm/txs/executor/atomic_tx_executor.go @@ -10,7 +10,7 @@ import ( "github.com/ava-labs/avalanchego/vms/platformvm/txs" ) -var _ txs.Visitor = &AtomicTxExecutor{} +var _ txs.Visitor = (*AtomicTxExecutor)(nil) // atomicTxExecutor is used to execute atomic transactions pre-AP5. After AP5 // the execution was moved to be performed inside of the standardTxExecutor. diff --git a/vms/platformvm/txs/executor/proposal_tx_executor.go b/vms/platformvm/txs/executor/proposal_tx_executor.go index 317a9e74e27..127614a1222 100644 --- a/vms/platformvm/txs/executor/proposal_tx_executor.go +++ b/vms/platformvm/txs/executor/proposal_tx_executor.go @@ -31,7 +31,7 @@ const ( ) var ( - _ txs.Visitor = &ProposalTxExecutor{} + _ txs.Visitor = (*ProposalTxExecutor)(nil) errChildBlockNotAfterParent = errors.New("proposed timestamp not after current chain time") errInvalidState = errors.New("generated output isn't valid state") diff --git a/vms/platformvm/txs/executor/standard_tx_executor.go b/vms/platformvm/txs/executor/standard_tx_executor.go index c39d08f022b..6e812e8ee37 100644 --- a/vms/platformvm/txs/executor/standard_tx_executor.go +++ b/vms/platformvm/txs/executor/standard_tx_executor.go @@ -18,7 +18,7 @@ import ( ) var ( - _ txs.Visitor = &StandardTxExecutor{} + _ txs.Visitor = (*StandardTxExecutor)(nil) errEmptyNodeID = errors.New("validator nodeID cannot be empty") errMaxStakeDurationTooLarge = errors.New("max stake duration must be less than or equal to the global max stake duration") diff --git a/vms/platformvm/txs/executor/tx_mempool_verifier.go b/vms/platformvm/txs/executor/tx_mempool_verifier.go index 5943560ed9f..6d3122e42da 100644 --- a/vms/platformvm/txs/executor/tx_mempool_verifier.go +++ b/vms/platformvm/txs/executor/tx_mempool_verifier.go @@ -13,7 +13,7 @@ import ( "github.com/ava-labs/avalanchego/vms/platformvm/txs" ) -var _ txs.Visitor = &MempoolTxVerifier{} +var _ txs.Visitor = (*MempoolTxVerifier)(nil) type MempoolTxVerifier struct { *Backend diff --git a/vms/platformvm/txs/export_tx.go b/vms/platformvm/txs/export_tx.go index e05177acc12..9fa2184e9ef 100644 --- a/vms/platformvm/txs/export_tx.go +++ b/vms/platformvm/txs/export_tx.go @@ -15,7 +15,7 @@ import ( ) var ( - _ UnsignedTx = &ExportTx{} + _ UnsignedTx = (*ExportTx)(nil) ErrWrongLocktime = errors.New("wrong locktime reported") errNoExportOutputs = errors.New("no export outputs") diff --git a/vms/platformvm/txs/import_tx.go b/vms/platformvm/txs/import_tx.go index 45cff3513ed..d4e16e20594 100644 --- a/vms/platformvm/txs/import_tx.go +++ b/vms/platformvm/txs/import_tx.go @@ -14,7 +14,7 @@ import ( ) var ( - _ UnsignedTx = &ImportTx{} + _ UnsignedTx = (*ImportTx)(nil) errNoImportInputs = errors.New("tx has no imported inputs") ) diff --git a/vms/platformvm/txs/mempool/issuer.go b/vms/platformvm/txs/mempool/issuer.go index 0a7d8177465..c26f7031d2f 100644 --- a/vms/platformvm/txs/mempool/issuer.go +++ b/vms/platformvm/txs/mempool/issuer.go @@ -10,7 +10,7 @@ import ( ) var ( - _ txs.Visitor = &issuer{} + _ txs.Visitor = (*issuer)(nil) errCantIssueAdvanceTimeTx = errors.New("can not issue an advance time tx") errCantIssueRewardValidatorTx = errors.New("can not issue a reward validator tx") diff --git a/vms/platformvm/txs/mempool/mempool.go b/vms/platformvm/txs/mempool/mempool.go index fd916c8eece..fd4930a5483 100644 --- a/vms/platformvm/txs/mempool/mempool.go +++ b/vms/platformvm/txs/mempool/mempool.go @@ -31,7 +31,7 @@ const ( ) var ( - _ Mempool = &mempool{} + _ Mempool = (*mempool)(nil) errMempoolFull = errors.New("mempool is full") ) diff --git a/vms/platformvm/txs/mempool/mempool_test.go b/vms/platformvm/txs/mempool/mempool_test.go index f0b09258a96..3fbb3514072 100644 --- a/vms/platformvm/txs/mempool/mempool_test.go +++ b/vms/platformvm/txs/mempool/mempool_test.go @@ -22,7 +22,7 @@ import ( "github.com/ava-labs/avalanchego/vms/secp256k1fx" ) -var _ BlockTimer = &noopBlkTimer{} +var _ BlockTimer = (*noopBlkTimer)(nil) type noopBlkTimer struct{} diff --git a/vms/platformvm/txs/mempool/remover.go b/vms/platformvm/txs/mempool/remover.go index decdd712e3f..3118d71d744 100644 --- a/vms/platformvm/txs/mempool/remover.go +++ b/vms/platformvm/txs/mempool/remover.go @@ -5,7 +5,7 @@ package mempool import "github.com/ava-labs/avalanchego/vms/platformvm/txs" -var _ txs.Visitor = &remover{} +var _ txs.Visitor = (*remover)(nil) type remover struct { m *mempool diff --git a/vms/platformvm/txs/remove_subnet_validator_tx.go b/vms/platformvm/txs/remove_subnet_validator_tx.go index d2d829fbf09..65c77ec8a87 100644 --- a/vms/platformvm/txs/remove_subnet_validator_tx.go +++ b/vms/platformvm/txs/remove_subnet_validator_tx.go @@ -13,7 +13,7 @@ import ( ) var ( - _ UnsignedTx = &RemoveSubnetValidatorTx{} + _ UnsignedTx = (*RemoveSubnetValidatorTx)(nil) errRemovePrimaryNetworkValidator = errors.New("can't remove primary network validator with RemoveSubnetValidatorTx") ) diff --git a/vms/platformvm/txs/reward_validator_tx.go b/vms/platformvm/txs/reward_validator_tx.go index 1c03bcb6cea..325e64b2ce4 100644 --- a/vms/platformvm/txs/reward_validator_tx.go +++ b/vms/platformvm/txs/reward_validator_tx.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/vms/components/avax" ) -var _ UnsignedTx = &RewardValidatorTx{} +var _ UnsignedTx = (*RewardValidatorTx)(nil) // RewardValidatorTx is a transaction that represents a proposal to // remove a validator that is currently validating from the validator set. diff --git a/vms/platformvm/txs/transform_subnet_tx.go b/vms/platformvm/txs/transform_subnet_tx.go index 40e560b823d..0b341579d67 100644 --- a/vms/platformvm/txs/transform_subnet_tx.go +++ b/vms/platformvm/txs/transform_subnet_tx.go @@ -15,7 +15,7 @@ import ( ) var ( - _ UnsignedTx = &TransformSubnetTx{} + _ UnsignedTx = (*TransformSubnetTx)(nil) errCantTransformPrimaryNetwork = errors.New("cannot transform primary network") errEmptyAssetID = errors.New("empty asset ID is not valid") diff --git a/vms/platformvm/txs/txheap/by_age.go b/vms/platformvm/txs/txheap/by_age.go index a4da6778f14..8d6047a7b2e 100644 --- a/vms/platformvm/txs/txheap/by_age.go +++ b/vms/platformvm/txs/txheap/by_age.go @@ -3,7 +3,7 @@ package txheap -var _ Heap = &byAge{} +var _ Heap = (*byAge)(nil) type byAge struct { txHeap diff --git a/vms/platformvm/txs/txheap/by_end_time.go b/vms/platformvm/txs/txheap/by_end_time.go index 9bc4e3f27d1..bfefe0b2e2a 100644 --- a/vms/platformvm/txs/txheap/by_end_time.go +++ b/vms/platformvm/txs/txheap/by_end_time.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/vms/platformvm/txs" ) -var _ TimedHeap = &byEndTime{} +var _ TimedHeap = (*byEndTime)(nil) type byEndTime struct { txHeap diff --git a/vms/platformvm/txs/txheap/by_start_time.go b/vms/platformvm/txs/txheap/by_start_time.go index a816ecff4c5..2c65c72918c 100644 --- a/vms/platformvm/txs/txheap/by_start_time.go +++ b/vms/platformvm/txs/txheap/by_start_time.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/vms/platformvm/txs" ) -var _ TimedHeap = &byStartTime{} +var _ TimedHeap = (*byStartTime)(nil) type TimedHeap interface { Heap diff --git a/vms/platformvm/txs/txheap/heap.go b/vms/platformvm/txs/txheap/heap.go index 62d94f42744..79445d48ea8 100644 --- a/vms/platformvm/txs/txheap/heap.go +++ b/vms/platformvm/txs/txheap/heap.go @@ -10,7 +10,7 @@ import ( "github.com/ava-labs/avalanchego/vms/platformvm/txs" ) -var _ Heap = &txHeap{} +var _ Heap = (*txHeap)(nil) type Heap interface { Add(tx *txs.Tx) diff --git a/vms/platformvm/txs/txheap/with_metrics.go b/vms/platformvm/txs/txheap/with_metrics.go index d652c11603c..3d2620a7fe0 100644 --- a/vms/platformvm/txs/txheap/with_metrics.go +++ b/vms/platformvm/txs/txheap/with_metrics.go @@ -10,7 +10,7 @@ import ( "github.com/ava-labs/avalanchego/vms/platformvm/txs" ) -var _ Heap = &withMetrics{} +var _ Heap = (*withMetrics)(nil) type withMetrics struct { Heap diff --git a/vms/platformvm/utxo/handler.go b/vms/platformvm/utxo/handler.go index 81a01ffc30e..05a45fe2c2f 100644 --- a/vms/platformvm/utxo/handler.go +++ b/vms/platformvm/utxo/handler.go @@ -25,7 +25,7 @@ import ( ) var ( - _ Handler = &handler{} + _ Handler = (*handler)(nil) errCantSign = errors.New("can't sign") errLockedFundsNotMarkedAsLocked = errors.New("locked funds not marked as locked") diff --git a/vms/platformvm/utxo/handler_test.go b/vms/platformvm/utxo/handler_test.go index da538ab3f07..e711bfb6f8e 100644 --- a/vms/platformvm/utxo/handler_test.go +++ b/vms/platformvm/utxo/handler_test.go @@ -20,7 +20,7 @@ import ( "github.com/ava-labs/avalanchego/vms/secp256k1fx" ) -var _ txs.UnsignedTx = &dummyUnsignedTx{} +var _ txs.UnsignedTx = (*dummyUnsignedTx)(nil) type dummyUnsignedTx struct { txs.BaseTx diff --git a/vms/platformvm/vm.go b/vms/platformvm/vm.go index eab8b53ffaa..ceffe7ed796 100644 --- a/vms/platformvm/vm.go +++ b/vms/platformvm/vm.go @@ -60,9 +60,9 @@ const ( ) var ( - _ block.ChainVM = &VM{} - _ secp256k1fx.VM = &VM{} - _ validators.State = &VM{} + _ block.ChainVM = (*VM)(nil) + _ secp256k1fx.VM = (*VM)(nil) + _ validators.State = (*VM)(nil) errWrongCacheType = errors.New("unexpectedly cached type") errMissingValidatorSet = errors.New("missing validator set") diff --git a/vms/propertyfx/factory.go b/vms/propertyfx/factory.go index 8aeecba225b..2e63c0ae4f1 100644 --- a/vms/propertyfx/factory.go +++ b/vms/propertyfx/factory.go @@ -10,7 +10,7 @@ import ( ) var ( - _ vms.Factory = &Factory{} + _ vms.Factory = (*Factory)(nil) // ID that this Fx uses when labeled ID = ids.ID{'p', 'r', 'o', 'p', 'e', 'r', 't', 'y', 'f', 'x'} diff --git a/vms/proposervm/batched_vm.go b/vms/proposervm/batched_vm.go index 8d10dff1cc9..6a4a4a6dad1 100644 --- a/vms/proposervm/batched_vm.go +++ b/vms/proposervm/batched_vm.go @@ -16,7 +16,7 @@ import ( statelessblock "github.com/ava-labs/avalanchego/vms/proposervm/block" ) -var _ block.BatchedChainVM = &VM{} +var _ block.BatchedChainVM = (*VM)(nil) func (vm *VM) GetAncestors( blkID ids.ID, diff --git a/vms/proposervm/block/block.go b/vms/proposervm/block/block.go index 1967abc3a91..46ed4ac18a4 100644 --- a/vms/proposervm/block/block.go +++ b/vms/proposervm/block/block.go @@ -15,7 +15,7 @@ import ( ) var ( - _ SignedBlock = &statelessBlock{} + _ SignedBlock = (*statelessBlock)(nil) errUnexpectedProposer = errors.New("expected no proposer but one was provided") errMissingProposer = errors.New("expected proposer but none was provided") diff --git a/vms/proposervm/block_server.go b/vms/proposervm/block_server.go index d45676d6c1d..4a721467997 100644 --- a/vms/proposervm/block_server.go +++ b/vms/proposervm/block_server.go @@ -9,7 +9,7 @@ import ( "github.com/ava-labs/avalanchego/vms/proposervm/indexer" ) -var _ indexer.BlockServer = &VM{} +var _ indexer.BlockServer = (*VM)(nil) // Note: this is a contention heavy call that should be avoided // for frequent/repeated indexer ops diff --git a/vms/proposervm/indexer/block_server_test.go b/vms/proposervm/indexer/block_server_test.go index caabac05d97..e2ed4b80bff 100644 --- a/vms/proposervm/indexer/block_server_test.go +++ b/vms/proposervm/indexer/block_server_test.go @@ -15,7 +15,7 @@ var ( errGetWrappingBlk = errors.New("unexpectedly called GetWrappingBlk") errCommit = errors.New("unexpectedly called Commit") - _ BlockServer = &TestBlockServer{} + _ BlockServer = (*TestBlockServer)(nil) ) // TestBatchedVM is a BatchedVM that is useful for testing. diff --git a/vms/proposervm/indexer/height_indexer.go b/vms/proposervm/indexer/height_indexer.go index 27f4b587402..97d9ad9d269 100644 --- a/vms/proposervm/indexer/height_indexer.go +++ b/vms/proposervm/indexer/height_indexer.go @@ -25,7 +25,7 @@ const ( sleepDurationMultiplier = 5 ) -var _ HeightIndexer = &heightIndexer{} +var _ HeightIndexer = (*heightIndexer)(nil) type HeightIndexer interface { // Returns whether the height index is fully repaired. diff --git a/vms/proposervm/post_fork_block.go b/vms/proposervm/post_fork_block.go index 2705fc7d5ec..5803bd653e8 100644 --- a/vms/proposervm/post_fork_block.go +++ b/vms/proposervm/post_fork_block.go @@ -10,7 +10,7 @@ import ( "github.com/ava-labs/avalanchego/vms/proposervm/block" ) -var _ PostForkBlock = &postForkBlock{} +var _ PostForkBlock = (*postForkBlock)(nil) type postForkBlock struct { block.SignedBlock diff --git a/vms/proposervm/post_fork_option.go b/vms/proposervm/post_fork_option.go index 8243afb899f..7a57f0782fa 100644 --- a/vms/proposervm/post_fork_option.go +++ b/vms/proposervm/post_fork_option.go @@ -11,7 +11,7 @@ import ( "github.com/ava-labs/avalanchego/vms/proposervm/block" ) -var _ PostForkBlock = &postForkOption{} +var _ PostForkBlock = (*postForkOption)(nil) // The parent of a *postForkOption must be a *postForkBlock. type postForkOption struct { diff --git a/vms/proposervm/pre_fork_block.go b/vms/proposervm/pre_fork_block.go index b28b69f62ab..8f5f8687e9d 100644 --- a/vms/proposervm/pre_fork_block.go +++ b/vms/proposervm/pre_fork_block.go @@ -14,7 +14,7 @@ import ( "github.com/ava-labs/avalanchego/vms/proposervm/block" ) -var _ Block = &preForkBlock{} +var _ Block = (*preForkBlock)(nil) type preForkBlock struct { snowman.Block diff --git a/vms/proposervm/proposer/windower.go b/vms/proposervm/proposer/windower.go index 36255d21d6c..e01a1f5d404 100644 --- a/vms/proposervm/proposer/windower.go +++ b/vms/proposervm/proposer/windower.go @@ -21,7 +21,7 @@ const ( MaxDelay = MaxWindows * WindowDuration ) -var _ Windower = &windower{} +var _ Windower = (*windower)(nil) type Windower interface { Delay( diff --git a/vms/proposervm/state/block_height_index.go b/vms/proposervm/state/block_height_index.go index f94d56aab3c..a964f8a14a0 100644 --- a/vms/proposervm/state/block_height_index.go +++ b/vms/proposervm/state/block_height_index.go @@ -28,7 +28,7 @@ const ( ) var ( - _ HeightIndex = &heightIndex{} + _ HeightIndex = (*heightIndex)(nil) heightPrefix = []byte("height") metadataPrefix = []byte("metadata") diff --git a/vms/proposervm/state/block_state.go b/vms/proposervm/state/block_state.go index dccf46a563f..f98ae0dfb23 100644 --- a/vms/proposervm/state/block_state.go +++ b/vms/proposervm/state/block_state.go @@ -22,7 +22,7 @@ const blockCacheSize = 8192 var ( errBlockWrongVersion = errors.New("wrong version") - _ BlockState = &blockState{} + _ BlockState = (*blockState)(nil) ) type BlockState interface { diff --git a/vms/proposervm/state/chain_state.go b/vms/proposervm/state/chain_state.go index c5311250fdc..de7bbb4671f 100644 --- a/vms/proposervm/state/chain_state.go +++ b/vms/proposervm/state/chain_state.go @@ -15,7 +15,7 @@ const ( var ( lastAcceptedKey = []byte{lastAcceptedByte} - _ ChainState = &chainState{} + _ ChainState = (*chainState)(nil) ) type ChainState interface { diff --git a/vms/proposervm/state_summary.go b/vms/proposervm/state_summary.go index 5e50dad572e..f33fc0d1baf 100644 --- a/vms/proposervm/state_summary.go +++ b/vms/proposervm/state_summary.go @@ -8,7 +8,7 @@ import ( "github.com/ava-labs/avalanchego/vms/proposervm/summary" ) -var _ block.StateSummary = &stateSummary{} +var _ block.StateSummary = (*stateSummary)(nil) // stateSummary implements block.StateSummary by layering three objects: // 1. [statelessSummary] carries all summary marshallable content along with diff --git a/vms/proposervm/summary/state_summary.go b/vms/proposervm/summary/state_summary.go index badbddea1d8..368b84f7766 100644 --- a/vms/proposervm/summary/state_summary.go +++ b/vms/proposervm/summary/state_summary.go @@ -7,7 +7,7 @@ import ( "github.com/ava-labs/avalanchego/ids" ) -var _ StateSummary = &stateSummary{} +var _ StateSummary = (*stateSummary)(nil) type StateSummary interface { ID() ids.ID diff --git a/vms/proposervm/vm.go b/vms/proposervm/vm.go index adce7b7d45a..0f974cf8829 100644 --- a/vms/proposervm/vm.go +++ b/vms/proposervm/vm.go @@ -46,10 +46,10 @@ const ( ) var ( - _ block.ChainVM = &VM{} - _ block.BatchedChainVM = &VM{} - _ block.HeightIndexedChainVM = &VM{} - _ block.StateSyncableVM = &VM{} + _ block.ChainVM = (*VM)(nil) + _ block.BatchedChainVM = (*VM)(nil) + _ block.HeightIndexedChainVM = (*VM)(nil) + _ block.StateSyncableVM = (*VM)(nil) dbPrefix = []byte("proposervm") ) diff --git a/vms/proposervm/vm_test.go b/vms/proposervm/vm_test.go index 2415aa91fe5..eafedf6beee 100644 --- a/vms/proposervm/vm_test.go +++ b/vms/proposervm/vm_test.go @@ -35,9 +35,9 @@ import ( ) var ( - _ block.ChainVM = &fullVM{} - _ block.HeightIndexedChainVM = &fullVM{} - _ block.StateSyncableVM = &fullVM{} + _ block.ChainVM = (*fullVM)(nil) + _ block.HeightIndexedChainVM = (*fullVM)(nil) + _ block.StateSyncableVM = (*fullVM)(nil) ) type fullVM struct { diff --git a/vms/registry/vm_getter.go b/vms/registry/vm_getter.go index 1860113590a..9d16ab56643 100644 --- a/vms/registry/vm_getter.go +++ b/vms/registry/vm_getter.go @@ -16,7 +16,7 @@ import ( ) var ( - _ VMGetter = &vmGetter{} + _ VMGetter = (*vmGetter)(nil) errInvalidVMID = errors.New("invalid vmID") ) diff --git a/vms/registry/vm_registerer.go b/vms/registry/vm_registerer.go index 40d373e336e..1b839adf56f 100644 --- a/vms/registry/vm_registerer.go +++ b/vms/registry/vm_registerer.go @@ -18,7 +18,7 @@ import ( "github.com/ava-labs/avalanchego/vms" ) -var _ VMRegisterer = &vmRegisterer{} +var _ VMRegisterer = (*vmRegisterer)(nil) // VMRegisterer defines functionality to install a virtual machine. type VMRegisterer interface { diff --git a/vms/registry/vm_registry.go b/vms/registry/vm_registry.go index ff54a362f98..c225a48f804 100644 --- a/vms/registry/vm_registry.go +++ b/vms/registry/vm_registry.go @@ -5,7 +5,7 @@ package registry import "github.com/ava-labs/avalanchego/ids" -var _ VMRegistry = &vmRegistry{} +var _ VMRegistry = (*vmRegistry)(nil) // VMRegistry defines functionality to get any new virtual machines on the node, // and install them if they're not already installed. diff --git a/vms/rpcchainvm/factory.go b/vms/rpcchainvm/factory.go index f55945b03c7..c8c0590a055 100644 --- a/vms/rpcchainvm/factory.go +++ b/vms/rpcchainvm/factory.go @@ -23,7 +23,7 @@ import ( var ( errWrongVM = errors.New("wrong vm type") - _ vms.Factory = &factory{} + _ vms.Factory = (*factory)(nil) ) type factory struct { diff --git a/vms/rpcchainvm/ghttp/gconn/conn_client.go b/vms/rpcchainvm/ghttp/gconn/conn_client.go index cc91e68268e..add8303f6c8 100644 --- a/vms/rpcchainvm/ghttp/gconn/conn_client.go +++ b/vms/rpcchainvm/ghttp/gconn/conn_client.go @@ -17,7 +17,7 @@ import ( connpb "github.com/ava-labs/avalanchego/proto/pb/net/conn" ) -var _ net.Conn = &Client{} +var _ net.Conn = (*Client)(nil) // Client is an implementation of a connection that talks over RPC. type Client struct { diff --git a/vms/rpcchainvm/ghttp/gconn/conn_server.go b/vms/rpcchainvm/ghttp/gconn/conn_server.go index 6576e5c4cd4..6dfe35993d0 100644 --- a/vms/rpcchainvm/ghttp/gconn/conn_server.go +++ b/vms/rpcchainvm/ghttp/gconn/conn_server.go @@ -15,7 +15,7 @@ import ( connpb "github.com/ava-labs/avalanchego/proto/pb/net/conn" ) -var _ connpb.ConnServer = &Server{} +var _ connpb.ConnServer = (*Server)(nil) // Server is an http.Conn that is managed over RPC. type Server struct { diff --git a/vms/rpcchainvm/ghttp/greader/reader_client.go b/vms/rpcchainvm/ghttp/greader/reader_client.go index ce0702d5910..57fe97ccb4c 100644 --- a/vms/rpcchainvm/ghttp/greader/reader_client.go +++ b/vms/rpcchainvm/ghttp/greader/reader_client.go @@ -11,7 +11,7 @@ import ( readerpb "github.com/ava-labs/avalanchego/proto/pb/io/reader" ) -var _ io.Reader = &Client{} +var _ io.Reader = (*Client)(nil) // Client is a reader that talks over RPC. type Client struct{ client readerpb.ReaderClient } diff --git a/vms/rpcchainvm/ghttp/greader/reader_server.go b/vms/rpcchainvm/ghttp/greader/reader_server.go index 0fd5a2b597e..8a598881106 100644 --- a/vms/rpcchainvm/ghttp/greader/reader_server.go +++ b/vms/rpcchainvm/ghttp/greader/reader_server.go @@ -10,7 +10,7 @@ import ( readerpb "github.com/ava-labs/avalanchego/proto/pb/io/reader" ) -var _ readerpb.ReaderServer = &Server{} +var _ readerpb.ReaderServer = (*Server)(nil) // Server is an io.Reader that is managed over RPC. type Server struct { diff --git a/vms/rpcchainvm/ghttp/gresponsewriter/locked_writer.go b/vms/rpcchainvm/ghttp/gresponsewriter/locked_writer.go index 5a3290e83a1..b937d856e09 100644 --- a/vms/rpcchainvm/ghttp/gresponsewriter/locked_writer.go +++ b/vms/rpcchainvm/ghttp/gresponsewriter/locked_writer.go @@ -11,9 +11,9 @@ import ( ) var ( - _ http.ResponseWriter = &lockedWriter{} - _ http.Flusher = &lockedWriter{} - _ http.Hijacker = &lockedWriter{} + _ http.ResponseWriter = (*lockedWriter)(nil) + _ http.Flusher = (*lockedWriter)(nil) + _ http.Hijacker = (*lockedWriter)(nil) ) type lockedWriter struct { diff --git a/vms/rpcchainvm/ghttp/gresponsewriter/writer_client.go b/vms/rpcchainvm/ghttp/gresponsewriter/writer_client.go index f34a393ad7a..fbcbaffe7a0 100644 --- a/vms/rpcchainvm/ghttp/gresponsewriter/writer_client.go +++ b/vms/rpcchainvm/ghttp/gresponsewriter/writer_client.go @@ -23,9 +23,9 @@ import ( ) var ( - _ http.ResponseWriter = &Client{} - _ http.Flusher = &Client{} - _ http.Hijacker = &Client{} + _ http.ResponseWriter = (*Client)(nil) + _ http.Flusher = (*Client)(nil) + _ http.Hijacker = (*Client)(nil) ) // Client is an http.ResponseWriter that talks over RPC. diff --git a/vms/rpcchainvm/ghttp/gresponsewriter/writer_server.go b/vms/rpcchainvm/ghttp/gresponsewriter/writer_server.go index 38c1ad630aa..d0ef0653961 100644 --- a/vms/rpcchainvm/ghttp/gresponsewriter/writer_server.go +++ b/vms/rpcchainvm/ghttp/gresponsewriter/writer_server.go @@ -26,7 +26,7 @@ var ( errUnsupportedFlushing = errors.New("response writer doesn't support flushing") errUnsupportedHijacking = errors.New("response writer doesn't support hijacking") - _ responsewriterpb.WriterServer = &Server{} + _ responsewriterpb.WriterServer = (*Server)(nil) ) // Server is an http.ResponseWriter that is managed over RPC. diff --git a/vms/rpcchainvm/ghttp/gwriter/writer_client.go b/vms/rpcchainvm/ghttp/gwriter/writer_client.go index 5fdc224b3c9..7fa1d3d4a9c 100644 --- a/vms/rpcchainvm/ghttp/gwriter/writer_client.go +++ b/vms/rpcchainvm/ghttp/gwriter/writer_client.go @@ -11,7 +11,7 @@ import ( writerpb "github.com/ava-labs/avalanchego/proto/pb/io/writer" ) -var _ io.Writer = &Client{} +var _ io.Writer = (*Client)(nil) // Client is an io.Writer that talks over RPC. type Client struct{ client writerpb.WriterClient } diff --git a/vms/rpcchainvm/ghttp/gwriter/writer_server.go b/vms/rpcchainvm/ghttp/gwriter/writer_server.go index 52f57ebe09e..1f3cd0d8ca6 100644 --- a/vms/rpcchainvm/ghttp/gwriter/writer_server.go +++ b/vms/rpcchainvm/ghttp/gwriter/writer_server.go @@ -10,7 +10,7 @@ import ( writerpb "github.com/ava-labs/avalanchego/proto/pb/io/writer" ) -var _ writerpb.WriterServer = &Server{} +var _ writerpb.WriterServer = (*Server)(nil) // Server is an http.Handler that is managed over RPC. type Server struct { diff --git a/vms/rpcchainvm/ghttp/http_client.go b/vms/rpcchainvm/ghttp/http_client.go index 5119dcf25a2..b72adf391ef 100644 --- a/vms/rpcchainvm/ghttp/http_client.go +++ b/vms/rpcchainvm/ghttp/http_client.go @@ -16,7 +16,7 @@ import ( responsewriterpb "github.com/ava-labs/avalanchego/proto/pb/http/responsewriter" ) -var _ http.Handler = &Client{} +var _ http.Handler = (*Client)(nil) // Client is an http.Handler that talks over RPC. type Client struct { diff --git a/vms/rpcchainvm/ghttp/http_server.go b/vms/rpcchainvm/ghttp/http_server.go index 440e433b644..53afbc0b391 100644 --- a/vms/rpcchainvm/ghttp/http_server.go +++ b/vms/rpcchainvm/ghttp/http_server.go @@ -21,8 +21,8 @@ import ( ) var ( - _ httppb.HTTPServer = &Server{} - _ http.ResponseWriter = &ResponseWriter{} + _ httppb.HTTPServer = (*Server)(nil) + _ http.ResponseWriter = (*ResponseWriter)(nil) ) // Server is an http.Handler that is managed over RPC. diff --git a/vms/rpcchainvm/gsubnetlookup/subnet_lookup_client.go b/vms/rpcchainvm/gsubnetlookup/subnet_lookup_client.go index ddb77cb27fe..ef3ce6de7bd 100644 --- a/vms/rpcchainvm/gsubnetlookup/subnet_lookup_client.go +++ b/vms/rpcchainvm/gsubnetlookup/subnet_lookup_client.go @@ -12,7 +12,7 @@ import ( subnetlookuppb "github.com/ava-labs/avalanchego/proto/pb/subnetlookup" ) -var _ snow.SubnetLookup = &Client{} +var _ snow.SubnetLookup = (*Client)(nil) // Client is a subnet lookup that talks over RPC. type Client struct { diff --git a/vms/rpcchainvm/gsubnetlookup/subnet_lookup_server.go b/vms/rpcchainvm/gsubnetlookup/subnet_lookup_server.go index 78cfde3f570..a5a087bad54 100644 --- a/vms/rpcchainvm/gsubnetlookup/subnet_lookup_server.go +++ b/vms/rpcchainvm/gsubnetlookup/subnet_lookup_server.go @@ -12,7 +12,7 @@ import ( subnetlookuppb "github.com/ava-labs/avalanchego/proto/pb/subnetlookup" ) -var _ subnetlookuppb.SubnetLookupServer = &Server{} +var _ subnetlookuppb.SubnetLookupServer = (*Server)(nil) // Server is a subnet lookup that is managed over RPC. type Server struct { diff --git a/vms/rpcchainvm/messenger/messenger_server.go b/vms/rpcchainvm/messenger/messenger_server.go index 2e6ed5dfb83..2949da620bb 100644 --- a/vms/rpcchainvm/messenger/messenger_server.go +++ b/vms/rpcchainvm/messenger/messenger_server.go @@ -15,7 +15,7 @@ import ( var ( errFullQueue = errors.New("full message queue") - _ messengerpb.MessengerServer = &Server{} + _ messengerpb.MessengerServer = (*Server)(nil) ) // Server is a messenger that is managed over RPC. diff --git a/vms/rpcchainvm/vm.go b/vms/rpcchainvm/vm.go index b71d956e621..135dc26c3b5 100644 --- a/vms/rpcchainvm/vm.go +++ b/vms/rpcchainvm/vm.go @@ -33,8 +33,8 @@ var ( "vm": &vmPlugin{}, } - _ plugin.Plugin = &vmPlugin{} - _ plugin.GRPCPlugin = &vmPlugin{} + _ plugin.Plugin = (*vmPlugin)(nil) + _ plugin.GRPCPlugin = (*vmPlugin)(nil) ) type vmPlugin struct { diff --git a/vms/rpcchainvm/vm_client.go b/vms/rpcchainvm/vm_client.go index ce427f7e45c..346edc2f678 100644 --- a/vms/rpcchainvm/vm_client.go +++ b/vms/rpcchainvm/vm_client.go @@ -70,15 +70,15 @@ var ( errUnsupportedFXs = errors.New("unsupported feature extensions") errBatchedParseBlockWrongNumberOfBlocks = errors.New("BatchedParseBlock returned different number of blocks than expected") - _ block.ChainVM = &VMClient{} - _ block.BatchedChainVM = &VMClient{} - _ block.HeightIndexedChainVM = &VMClient{} - _ block.StateSyncableVM = &VMClient{} - _ prometheus.Gatherer = &VMClient{} + _ block.ChainVM = (*VMClient)(nil) + _ block.BatchedChainVM = (*VMClient)(nil) + _ block.HeightIndexedChainVM = (*VMClient)(nil) + _ block.StateSyncableVM = (*VMClient)(nil) + _ prometheus.Gatherer = (*VMClient)(nil) - _ snowman.Block = &blockClient{} + _ snowman.Block = (*blockClient)(nil) - _ block.StateSummary = &summaryClient{} + _ block.StateSummary = (*summaryClient)(nil) ) // VMClient is an implementation of a VM that talks over RPC. diff --git a/vms/rpcchainvm/vm_server.go b/vms/rpcchainvm/vm_server.go index c8ff189951f..1dd1bb85536 100644 --- a/vms/rpcchainvm/vm_server.go +++ b/vms/rpcchainvm/vm_server.go @@ -48,7 +48,7 @@ import ( vmpb "github.com/ava-labs/avalanchego/proto/pb/vm" ) -var _ vmpb.VMServer = &VMServer{} +var _ vmpb.VMServer = (*VMServer)(nil) // VMServer is a VM that is managed over RPC. type VMServer struct { diff --git a/vms/rpcchainvm/vm_test.go b/vms/rpcchainvm/vm_test.go index f92decdb632..add8fe3fa48 100644 --- a/vms/rpcchainvm/vm_test.go +++ b/vms/rpcchainvm/vm_test.go @@ -42,8 +42,8 @@ import ( ) var ( - _ plugin.Plugin = &testVMPlugin{} - _ plugin.GRPCPlugin = &testVMPlugin{} + _ plugin.Plugin = (*testVMPlugin)(nil) + _ plugin.GRPCPlugin = (*testVMPlugin)(nil) ) // Test_VMServerInterface ensures that the RPCs methods defined by VMServer diff --git a/vms/secp256k1fx/factory.go b/vms/secp256k1fx/factory.go index 9952fb66497..059e2aa83e6 100644 --- a/vms/secp256k1fx/factory.go +++ b/vms/secp256k1fx/factory.go @@ -10,7 +10,7 @@ import ( ) var ( - _ vms.Factory = &Factory{} + _ vms.Factory = (*Factory)(nil) // ID that this Fx uses when labeled ID = ids.ID{'s', 'e', 'c', 'p', '2', '5', '6', 'k', '1', 'f', 'x'} diff --git a/vms/secp256k1fx/keychain.go b/vms/secp256k1fx/keychain.go index d03dfd2e57b..a845f9b6985 100644 --- a/vms/secp256k1fx/keychain.go +++ b/vms/secp256k1fx/keychain.go @@ -18,7 +18,7 @@ import ( var ( errCantSpend = errors.New("unable to spend this UTXO") - _ keychain.Keychain = &Keychain{} + _ keychain.Keychain = (*Keychain)(nil) ) // Keychain is a collection of keys that can be used to spend outputs diff --git a/vms/secp256k1fx/mint_output.go b/vms/secp256k1fx/mint_output.go index 7f293f2130f..b79e73829a4 100644 --- a/vms/secp256k1fx/mint_output.go +++ b/vms/secp256k1fx/mint_output.go @@ -7,7 +7,7 @@ import ( "github.com/ava-labs/avalanchego/vms/components/verify" ) -var _ verify.State = &MintOutput{} +var _ verify.State = (*MintOutput)(nil) type MintOutput struct { OutputOwners `serialize:"true"` diff --git a/vms/secp256k1fx/output_owners.go b/vms/secp256k1fx/output_owners.go index a2962135122..7212636a9d8 100644 --- a/vms/secp256k1fx/output_owners.go +++ b/vms/secp256k1fx/output_owners.go @@ -21,7 +21,7 @@ var ( errAddrsNotSortedUnique = errors.New("addresses not sorted and unique") errMarshal = errors.New("cannot marshal without ctx") - _ verify.State = &OutputOwners{} + _ verify.State = (*OutputOwners)(nil) ) type OutputOwners struct { diff --git a/vms/secp256k1fx/transfer_output.go b/vms/secp256k1fx/transfer_output.go index 6327d774926..05cd2dcba68 100644 --- a/vms/secp256k1fx/transfer_output.go +++ b/vms/secp256k1fx/transfer_output.go @@ -11,7 +11,7 @@ import ( ) var ( - _ verify.State = &OutputOwners{} + _ verify.State = (*OutputOwners)(nil) errNoValueOutput = errors.New("output has no value") ) diff --git a/vms/secp256k1fx/tx.go b/vms/secp256k1fx/tx.go index fe7179b5b08..116c65780e6 100644 --- a/vms/secp256k1fx/tx.go +++ b/vms/secp256k1fx/tx.go @@ -8,7 +8,7 @@ type UnsignedTx interface { Bytes() []byte } -var _ UnsignedTx = &TestTx{} +var _ UnsignedTx = (*TestTx)(nil) // TestTx is a minimal implementation of a Tx type TestTx struct{ UnsignedBytes []byte } diff --git a/vms/secp256k1fx/vm.go b/vms/secp256k1fx/vm.go index d692fea567e..050fe9ac181 100644 --- a/vms/secp256k1fx/vm.go +++ b/vms/secp256k1fx/vm.go @@ -16,7 +16,7 @@ type VM interface { Logger() logging.Logger } -var _ VM = &TestVM{} +var _ VM = (*TestVM)(nil) // TestVM is a minimal implementation of a VM type TestVM struct { diff --git a/wallet/chain/p/backend.go b/wallet/chain/p/backend.go index 8f267a6d7c5..0dcc121172f 100644 --- a/wallet/chain/p/backend.go +++ b/wallet/chain/p/backend.go @@ -15,7 +15,7 @@ import ( "github.com/ava-labs/avalanchego/vms/platformvm/txs" ) -var _ Backend = &backend{} +var _ Backend = (*backend)(nil) type ChainUTXOs interface { AddUTXO(ctx stdcontext.Context, destinationChainID ids.ID, utxo *avax.UTXO) error diff --git a/wallet/chain/p/backend_visitor.go b/wallet/chain/p/backend_visitor.go index 02ae9ae1de9..9269bc38c48 100644 --- a/wallet/chain/p/backend_visitor.go +++ b/wallet/chain/p/backend_visitor.go @@ -12,7 +12,7 @@ import ( "github.com/ava-labs/avalanchego/vms/platformvm/txs" ) -var _ txs.Visitor = &backendVisitor{} +var _ txs.Visitor = (*backendVisitor)(nil) // backendVisitor handles accepting of transactions for the backend type backendVisitor struct { diff --git a/wallet/chain/p/builder.go b/wallet/chain/p/builder.go index a9a3fdb54c9..13235f29051 100644 --- a/wallet/chain/p/builder.go +++ b/wallet/chain/p/builder.go @@ -29,7 +29,7 @@ var ( errInsufficientAuthorization = errors.New("insufficient authorization") errInsufficientFunds = errors.New("insufficient funds") - _ Builder = &builder{} + _ Builder = (*builder)(nil) ) // Builder provides a convenient interface for building unsigned P-chain diff --git a/wallet/chain/p/builder_with_options.go b/wallet/chain/p/builder_with_options.go index bd597e39c80..4761b007a62 100644 --- a/wallet/chain/p/builder_with_options.go +++ b/wallet/chain/p/builder_with_options.go @@ -15,7 +15,7 @@ import ( "github.com/ava-labs/avalanchego/wallet/subnet/primary/common" ) -var _ Builder = &builderWithOptions{} +var _ Builder = (*builderWithOptions)(nil) type builderWithOptions struct { Builder diff --git a/wallet/chain/p/context.go b/wallet/chain/p/context.go index 715991a4746..ac602937462 100644 --- a/wallet/chain/p/context.go +++ b/wallet/chain/p/context.go @@ -11,7 +11,7 @@ import ( "github.com/ava-labs/avalanchego/vms/avm" ) -var _ Context = &context{} +var _ Context = (*context)(nil) type Context interface { NetworkID() uint32 diff --git a/wallet/chain/p/signer.go b/wallet/chain/p/signer.go index 426a39ee33e..8c5e3190570 100644 --- a/wallet/chain/p/signer.go +++ b/wallet/chain/p/signer.go @@ -12,7 +12,7 @@ import ( "github.com/ava-labs/avalanchego/vms/platformvm/txs" ) -var _ Signer = &txSigner{} +var _ Signer = (*txSigner)(nil) type Signer interface { SignUnsigned(ctx stdcontext.Context, tx txs.UnsignedTx) (*txs.Tx, error) diff --git a/wallet/chain/p/signer_visitor.go b/wallet/chain/p/signer_visitor.go index 19e349c710a..35f1e949441 100644 --- a/wallet/chain/p/signer_visitor.go +++ b/wallet/chain/p/signer_visitor.go @@ -23,7 +23,7 @@ import ( ) var ( - _ txs.Visitor = &signerVisitor{} + _ txs.Visitor = (*signerVisitor)(nil) errUnsupportedTxType = errors.New("unsupported tx type") errUnknownInputType = errors.New("unknown input type") diff --git a/wallet/chain/p/wallet.go b/wallet/chain/p/wallet.go index b5ecb9a16c9..53fbefc17fc 100644 --- a/wallet/chain/p/wallet.go +++ b/wallet/chain/p/wallet.go @@ -21,7 +21,7 @@ import ( var ( errNotCommitted = errors.New("not committed") - _ Wallet = &wallet{} + _ Wallet = (*wallet)(nil) ) type Wallet interface { diff --git a/wallet/chain/p/wallet_with_options.go b/wallet/chain/p/wallet_with_options.go index 144d7707f3d..4352f5f5014 100644 --- a/wallet/chain/p/wallet_with_options.go +++ b/wallet/chain/p/wallet_with_options.go @@ -15,7 +15,7 @@ import ( "github.com/ava-labs/avalanchego/wallet/subnet/primary/common" ) -var _ Wallet = &walletWithOptions{} +var _ Wallet = (*walletWithOptions)(nil) func NewWalletWithOptions( wallet Wallet, diff --git a/wallet/chain/x/backend.go b/wallet/chain/x/backend.go index 6b5c9481dcd..9aa1065215a 100644 --- a/wallet/chain/x/backend.go +++ b/wallet/chain/x/backend.go @@ -13,7 +13,7 @@ import ( "github.com/ava-labs/avalanchego/vms/components/avax" ) -var _ Backend = &backend{} +var _ Backend = (*backend)(nil) type ChainUTXOs interface { AddUTXO(ctx stdcontext.Context, destinationChainID ids.ID, utxo *avax.UTXO) error diff --git a/wallet/chain/x/builder.go b/wallet/chain/x/builder.go index 160fc4a7c45..3ebcd88fe18 100644 --- a/wallet/chain/x/builder.go +++ b/wallet/chain/x/builder.go @@ -24,7 +24,7 @@ var ( errNoChangeAddress = errors.New("no possible change address") errInsufficientFunds = errors.New("insufficient funds") - _ Builder = &builder{} + _ Builder = (*builder)(nil) ) // Builder provides a convenient interface for building unsigned X-chain diff --git a/wallet/chain/x/builder_with_options.go b/wallet/chain/x/builder_with_options.go index 2dd098fee3d..10a65c03a0e 100644 --- a/wallet/chain/x/builder_with_options.go +++ b/wallet/chain/x/builder_with_options.go @@ -12,7 +12,7 @@ import ( "github.com/ava-labs/avalanchego/wallet/subnet/primary/common" ) -var _ Builder = &builderWithOptions{} +var _ Builder = (*builderWithOptions)(nil) type builderWithOptions struct { Builder diff --git a/wallet/chain/x/context.go b/wallet/chain/x/context.go index 7f081828c89..79bf7c987b3 100644 --- a/wallet/chain/x/context.go +++ b/wallet/chain/x/context.go @@ -11,7 +11,7 @@ import ( "github.com/ava-labs/avalanchego/vms/avm" ) -var _ Context = &context{} +var _ Context = (*context)(nil) type Context interface { NetworkID() uint32 diff --git a/wallet/chain/x/signer.go b/wallet/chain/x/signer.go index e5eb504a138..fd6fb7f61e2 100644 --- a/wallet/chain/x/signer.go +++ b/wallet/chain/x/signer.go @@ -34,7 +34,7 @@ var ( emptySig [crypto.SECP256K1RSigLen]byte - _ Signer = &signer{} + _ Signer = (*signer)(nil) ) type Signer interface { diff --git a/wallet/chain/x/wallet.go b/wallet/chain/x/wallet.go index 4bbde834843..1300b187eab 100644 --- a/wallet/chain/x/wallet.go +++ b/wallet/chain/x/wallet.go @@ -19,7 +19,7 @@ import ( var ( errNotAccepted = errors.New("not accepted") - _ Wallet = &wallet{} + _ Wallet = (*wallet)(nil) ) type Wallet interface { diff --git a/wallet/chain/x/wallet_with_options.go b/wallet/chain/x/wallet_with_options.go index 64be4e20670..14cf8da8219 100644 --- a/wallet/chain/x/wallet_with_options.go +++ b/wallet/chain/x/wallet_with_options.go @@ -12,7 +12,7 @@ import ( "github.com/ava-labs/avalanchego/wallet/subnet/primary/common" ) -var _ Wallet = &walletWithOptions{} +var _ Wallet = (*walletWithOptions)(nil) func NewWalletWithOptions( wallet Wallet, diff --git a/wallet/subnet/primary/utxos.go b/wallet/subnet/primary/utxos.go index 365aae95dc2..290ac02d685 100644 --- a/wallet/subnet/primary/utxos.go +++ b/wallet/subnet/primary/utxos.go @@ -15,8 +15,8 @@ import ( ) var ( - _ UTXOs = &utxos{} - _ ChainUTXOs = &chainUTXOs{} + _ UTXOs = (*utxos)(nil) + _ ChainUTXOs = (*chainUTXOs)(nil) // TODO: refactor ChainUTXOs definition to allow the client implementations // to perform their own assertions. diff --git a/wallet/subnet/primary/wallet.go b/wallet/subnet/primary/wallet.go index dc4241ff78a..3ed03e198f3 100644 --- a/wallet/subnet/primary/wallet.go +++ b/wallet/subnet/primary/wallet.go @@ -17,7 +17,7 @@ import ( "github.com/ava-labs/avalanchego/wallet/subnet/primary/common" ) -var _ Wallet = &wallet{} +var _ Wallet = (*wallet)(nil) // Wallet provides chain wallets for the primary network. type Wallet interface {