-
Notifications
You must be signed in to change notification settings - Fork 817
Add available memory health check #1315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| times = &cpu.TimesStat{} | ||
| } | ||
|
|
||
| io, err := p.p.IOCounters() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't implemented on macos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
availableMemoryBytes := n.resourceManager.AvailableMemoryBytes()
Does this work for Windows?
(this works on linux/mac)
|
Fetching memory inside of K8s isn't currently supported - so this approach doesn't currently work. See: shirou/gopsutil#1320 |
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Why this should be merged
Closes #1314
Nodes OOMing can cause extended downtime due to re-generating any non-committed state. This will more aggressively warn a node operator that the node is running out of memory.
How this works
Adds configs:
--system-tracker-memory-required-available(defaults to 500 MiB)--system-tracker-memory-warning-threshold-available(defaults to 1 GiB)How this was tested