Repository navigation
Epoching ACP181 implementation - #4238
Merged
Merged
Conversation
StephenButtolph
approved these changes
Oct 4, 2025
iansuvak
approved these changes
Oct 6, 2025
iansuvak
left a comment
Contributor
There was a problem hiding this comment.
Focused on the most recent set of changes but took a read of everything. I do like the extraction of the logic into a separate acp181 package and change of interface that it takes in upgrades instead of the epoch duration.
michaelkaplan13
approved these changes
Oct 6, 2025
michaelkaplan13
left a comment
Contributor
There was a problem hiding this comment.
I joined the review party late here, but think this got to a very clean implementation that is easy to follow from the specification.
Just had one nit/question about the proto field ordering, but I don't think it's consequential either way.
yacovm
approved these changes
Oct 6, 2025
yacovm
left a comment
Contributor
There was a problem hiding this comment.
This PR seems much slimmer than it was a few weeks ago
joshua-kim
reviewed
Oct 6, 2025
StephenButtolph
enabled auto-merge
October 7, 2025 13:51
StephenButtolph
disabled auto-merge
October 7, 2025 14:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Implements ProposerVM epochs as described in avalanche-foundation/ACPs#181
How this works
Adds two a new serializable block types to encode epoch information:
statelessUnsignedGraniteBlockandstatelessGraniteBlock.How this was tested
E2E and unit tests
Currently all
proposervmunit tests have theirgraniteTimeset to equal theirdurangoTime. We should go through and find any tests we would like to explicitly test for granite.Need to be documented in RELEASES.md?
Yes