Skip to content

Epoching ACP181 implementation - #4238

Merged
StephenButtolph merged 145 commits into
masterfrom
epoching-implementation
Oct 7, 2025
Merged

StephenButtolph merged 145 commits into
masterfrom
epoching-implementation

Conversation

@geoff-vball

@geoff-vball geoff-vball commented Sep 3, 2025 •

Copy link
Copy Markdown
Contributor

Why this should be merged

Implements ProposerVM epochs as described in avalanche-foundation/ACPs#181

How this works

Adds two a new serializable block types to encode epoch information: statelessUnsignedGraniteBlock and statelessGraniteBlock.

How this was tested

E2E and unit tests

Currently all proposervm unit tests have their graniteTime set to equal their durangoTime. We should go through and find any tests we would like to explicitly test for granite.

Need to be documented in RELEASES.md?

Yes

@iansuvak iansuvak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focused on the most recent set of changes but took a read of everything. I do like the extraction of the logic into a separate acp181 package and change of interface that it takes in upgrades instead of the epoch duration.

Comment thread upgrade/upgrade.go Resolved
Comment thread connectproto/proposervm/service.proto Resolved

@michaelkaplan13 michaelkaplan13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I joined the review party late here, but think this got to a very clean implementation that is easy to follow from the specification.

Just had one nit/question about the proto field ordering, but I don't think it's consequential either way.

@yacovm yacovm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems much slimmer than it was a few weeks ago

Comment thread tests/e2e/c/proposervm_epoch.go Resolved
Comment thread tests/e2e/c/proposervm_epoch.go Resolved
Comment thread upgrade/upgrade.go Resolved
Comment thread tests/e2e/c/proposervm_epoch.go Resolved
Comment thread tests/e2e/c/proposervm_epoch.go Resolved
Comment thread tests/e2e/p/l1.go Resolved
Comment thread tests/e2e/p/l1.go Resolved
Comment thread vms/proposervm/acp181/epoch.go Resolved
Comment thread vms/proposervm/acp181/epoch.go Resolved
Comment thread vms/proposervm/acp181/epoch_test.go Resolved
Comment thread vms/proposervm/block_test.go Resolved
Comment thread connectproto/proposervm/service.proto Resolved
Comment thread connectproto/proposervm/service.proto Resolved
@StephenButtolph
StephenButtolph merged commit 7b75fa5 into master Oct 7, 2025
@StephenButtolph
StephenButtolph deleted the epoching-implementation branch October 7, 2025 14:16
@github-project-automation github-project-automation Bot moved this from In Progress 🏗️ to Done 🎉 in avalanchego Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add "GetEpoch" RPC method to ProposerVM API

10 participants