Remove gosec from test linting #4471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alarso16
requested review from
StephenButtolph,
joshua-kim,
maru-ava and
rrazvan1
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the gosec linter from test files and eliminates all #nosec comments that were used to suppress security warnings for intentional random number generation in tests.
Key Changes:
- Added gosec to the list of excluded linters for test files in
.golangci.yml - Removed
#nosec G404and#nosec G204comments from test files across the codebase - Removed
//nolint:goseccomment from one test file
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .golangci.yml | Added gosec to the excluded linters list for test files |
| x/sync/workheap_test.go | Removed #nosec comment from random number generation |
| x/sync/sync_test.go | Removed #nosec comment from random number generation |
| x/merkledb/view_test.go | Removed #nosec comment from random number generation |
| x/merkledb/view_iterator_test.go | Removed #nosec comment from random number generation |
| x/merkledb/trie_test.go | Removed #nosec comment from random number generation |
| x/merkledb/sync_test.go | Removed multiple #nosec comments from random operations |
| x/merkledb/proof_test.go | Removed multiple #nosec comments from random operations |
| x/merkledb/network_server_test.go | Removed #nosec comments from random number generation |
| x/merkledb/history_test.go | Removed #nosec comment from random number generation |
| x/merkledb/helpers_test.go | Removed #nosec comments from random operations |
| x/merkledb/hashing_test.go | Removed multiple #nosec comments from random operations |
| x/merkledb/db_test.go | Removed multiple #nosec comments from random operations |
| x/merkledb/codec_test.go | Removed #nosec comments from random operations |
| wallet/chain/p/builder/builder_test.go | Removed #nosec comments from random number generation |
| vms/proposervm/proposer/windower_test.go | Removed #nosec comments from random number generation |
| vms/platformvm/state/state_test.go | Removed nolint:gosec comment |
| vms/platformvm/state/l1_validator_test.go | Removed multiple #nosec comments from random operations |
| utils/formatting/encoding_benchmark_test.go | Removed #nosec comment from random operation |
| utils/bag/bag_benchmark_test.go | Removed #nosec comments from random operations |
| tests/fixture/tmpnet/process_runtime.go | Removed #nosec G204 comment from command execution |
| snow/networking/sender/sender_test.go | Removed #nosec comment from random operation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
joshua-kim
changed the title
joshua-kim
approved these changes
Nov 6, 2025
StephenButtolph
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The linter is intended to catch mistakes, but (almost) all of the nolint clauses for gosec in testing were for random number generation. These are intentional, so it's feels unreasonable to lint in the first place.
How this works
Removed linter, and did a global search for
#nosecand removed all in testing files.How this was tested
CI
Need to be documented in RELEASES.md?
No