Use constant stop/start db syntax for current/pending validators #743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #743 +/- ##
===================================================
+ Coverage 56.83089% 56.84548% +0.01459%
===================================================
Files 319 319
Lines 20561 20561
===================================================
+ Hits 11685 11688 +3
+ Misses 7617 7615 -2
+ Partials 1259 1258 -1 |
StephenButtolph
approved these changes
Feb 1, 2021
StephenButtolph
approved these changes
Feb 1, 2021
StephenButtolph
added a commit
that referenced
this pull request
Aug 4, 2021
AV-746: cleaned up poll printing
StephenButtolph
pushed a commit
that referenced
this pull request
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some comments describing the iterators over the current/pending validator sets. Additionally, it uses the same syntax throughout when creating these iterators of
startIter/stopIter.