From b14d520293dab84a90774ccafdf8a3642d1bc9e0 Mon Sep 17 00:00:00 2001 From: Quentin Mc Gaw Date: Wed, 18 Dec 2024 11:59:47 +0100 Subject: [PATCH 1/7] chore(ci): define github labels in code --- .github/labels.yml | 68 ++++++++++++++++++++++++++++++++ .github/workflows/label-skip.yml | 15 +++++++ .github/workflows/labels.yml | 24 +++++++++++ 3 files changed, 107 insertions(+) create mode 100644 .github/labels.yml create mode 100644 .github/workflows/label-skip.yml create mode 100644 .github/workflows/labels.yml diff --git a/.github/labels.yml b/.github/labels.yml new file mode 100644 index 00000000000..b0ff1ee3ce2 --- /dev/null +++ b/.github/labels.yml @@ -0,0 +1,68 @@ +# libevm specific labels +- name: "Status: ๐Ÿ”ด Blocked by Geth sync" + color: "959a9c" + description: "This needs to wait for the next fork sync with the geth repository ๐Ÿด" + +# General categories +- name: "Category: New feature ๐Ÿ†•" + color: "ffc7ea" +- name: "Category: Documentation โœ’๏ธ" + description: "A problem with the readme or a code comment." + color: "ffc7ea" +- name: "Category: Bug ๐Ÿ›" + color: "ffc7ea" + from_name: "bug" +- name: "Category: Investigation ๐Ÿ”" + color: "ffc7ea" +- name: "Category: CI โ›“๏ธ" + description: "Anything related to continuous integration" + color: "ffc7ea" +- name: "Category: Testing ๐Ÿงช" + description: "Unit tests, integration tests, etc." + color: "ffc7ea" +- name: "Category: Code quality โœ๏ธ" + description: "Unit tests, integration tests, etc." + color: "ffc7ea" +- name: "Category: Performance ๐Ÿš€" + color: "ffc7ea" +- name: "Category: Label missing โ—" + description: "Use this if it feels a label should be added to label this issue" + color: "ffc7ea" + +# Status +- name: "Status: ๐Ÿ—ฏ๏ธ Waiting for feedback" + color: "f7d692" +- name: "Status: ๐Ÿ”ด Blocked" + color: "f7d692" + description: "Blocked by another issue or pull request" +- name: "Status: ๐ŸŸก Nearly resolved" + color: "f7d692" + description: "This might be resolved or is about to be resolved" + +# Priority +- name: "Priority: ๐Ÿšจ Urgent" + color: "03adfc" +- name: "Priority: ๐Ÿ“Œ Before next release" + color: "03adfc" + description: "Has to be done before the next release" +- name: "Status: ๐Ÿ”’ After next release" + color: "03adfc" + description: "Will be done after the next release" +- name: "Priority: ๐Ÿ’ค Low priority" + color: "03adfc" + +# Complexity +- name: "Complexity: ๐ŸŸฅ Hard to do" + color: "ff9efc" +- name: "Complexity: ๐ŸŸฉ Easy to do" + color: "ff9efc" + +# Closing reason +- name: "Closed: ๐Ÿ‘ฅ Duplicate" + color: "959a9c" + description: "Issue duplicates an existing issue" +- name: "Closed: โšฐ๏ธ Inactive" + color: "959a9c" + description: "No answer was received for weeks" +- name: "Closed: ๐Ÿ—‘๏ธ Bad issue" + color: "959a9c" diff --git a/.github/workflows/label-skip.yml b/.github/workflows/label-skip.yml new file mode 100644 index 00000000000..5f62d97169d --- /dev/null +++ b/.github/workflows/label-skip.yml @@ -0,0 +1,15 @@ +name: labels +on: + pull_request: + paths-ignore: + - .github/labels.yml + - .github/workflows/labels.yml + +jobs: + labeler: + permissions: + actions: read + runs-on: ubuntu-latest + steps: + - name: No trigger path triggered for required workflow. + run: exit 0 diff --git a/.github/workflows/labels.yml b/.github/workflows/labels.yml new file mode 100644 index 00000000000..515691cafe1 --- /dev/null +++ b/.github/workflows/labels.yml @@ -0,0 +1,24 @@ +name: labels +on: + push: + branches: + - main + paths: + - .github/labels.yml + - .github/workflows/labels.yml + pull_request: # dry run only + paths: + - .github/labels.yml + - .github/workflows/labels.yml + +jobs: + labeler: + permissions: + contents: read + issues: write + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - uses: crazy-max/ghaction-github-labeler@v5 + with: + dry-run: ${{ github.event_name == 'pull_request' }} From 320427bf8544ccc72e7861f1b109fa29030589cf Mon Sep 17 00:00:00 2001 From: Quentin Mc Gaw Date: Wed, 18 Dec 2024 12:29:32 +0100 Subject: [PATCH 2/7] Add DO NOT MERGE label migration --- .github/labels.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/labels.yml b/.github/labels.yml index b0ff1ee3ce2..df6c05ae21d 100644 --- a/.github/labels.yml +++ b/.github/labels.yml @@ -2,6 +2,9 @@ - name: "Status: ๐Ÿ”ด Blocked by Geth sync" color: "959a9c" description: "This needs to wait for the next fork sync with the geth repository ๐Ÿด" +- name: "Status: ๐Ÿ”ด DO NOT MERGE" + color: "959a9c" + from_name: "DO NOT MERGE" # General categories - name: "Category: New feature ๐Ÿ†•" From 9635d3a6d78808613a229f7bee1a1e2634c5fc12 Mon Sep 17 00:00:00 2001 From: Quentin Mc Gaw Date: Wed, 18 Dec 2024 15:01:06 +0100 Subject: [PATCH 3/7] Remove label-skip workflow --- .github/workflows/label-skip.yml | 15 --------------- 1 file changed, 15 deletions(-) delete mode 100644 .github/workflows/label-skip.yml diff --git a/.github/workflows/label-skip.yml b/.github/workflows/label-skip.yml deleted file mode 100644 index 5f62d97169d..00000000000 --- a/.github/workflows/label-skip.yml +++ /dev/null @@ -1,15 +0,0 @@ -name: labels -on: - pull_request: - paths-ignore: - - .github/labels.yml - - .github/workflows/labels.yml - -jobs: - labeler: - permissions: - actions: read - runs-on: ubuntu-latest - steps: - - name: No trigger path triggered for required workflow. - run: exit 0 From c619f562e11d1c5fcf76a97961d10a1e0f8f201e Mon Sep 17 00:00:00 2001 From: Quentin Mc Gaw Date: Wed, 18 Dec 2024 15:05:29 +0100 Subject: [PATCH 4/7] Remove invalid code quality description line --- .github/labels.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/labels.yml b/.github/labels.yml index df6c05ae21d..6ac6b81dd2a 100644 --- a/.github/labels.yml +++ b/.github/labels.yml @@ -24,7 +24,6 @@ description: "Unit tests, integration tests, etc." color: "ffc7ea" - name: "Category: Code quality โœ๏ธ" - description: "Unit tests, integration tests, etc." color: "ffc7ea" - name: "Category: Performance ๐Ÿš€" color: "ffc7ea" From 3ec283d801ce49fd6e467edc7f460bd0c1652025 Mon Sep 17 00:00:00 2001 From: Quentin Mc Gaw Date: Wed, 18 Dec 2024 15:06:04 +0100 Subject: [PATCH 5/7] Change complexity green square to blue square --- .github/labels.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/labels.yml b/.github/labels.yml index 6ac6b81dd2a..40b930a8221 100644 --- a/.github/labels.yml +++ b/.github/labels.yml @@ -56,7 +56,7 @@ # Complexity - name: "Complexity: ๐ŸŸฅ Hard to do" color: "ff9efc" -- name: "Complexity: ๐ŸŸฉ Easy to do" +- name: "Complexity: ๐ŸŸฆ Easy to do" color: "ff9efc" # Closing reason From 037c943e416c58f053841b2962616e70a0f93ef7 Mon Sep 17 00:00:00 2001 From: Quentin Mc Gaw Date: Wed, 18 Dec 2024 15:06:19 +0100 Subject: [PATCH 6/7] Remove Closed: bad issue label --- .github/labels.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/labels.yml b/.github/labels.yml index 40b930a8221..7ee4e48addc 100644 --- a/.github/labels.yml +++ b/.github/labels.yml @@ -66,5 +66,3 @@ - name: "Closed: โšฐ๏ธ Inactive" color: "959a9c" description: "No answer was received for weeks" -- name: "Closed: ๐Ÿ—‘๏ธ Bad issue" - color: "959a9c" From e56bec0f326132eb72f736d1dba07b193218079a Mon Sep 17 00:00:00 2001 From: Arran Schlosberg <519948+ARR4N@users.noreply.github.com> Date: Thu, 19 Dec 2024 16:03:21 +0000 Subject: [PATCH 7/7] chore: migrate instead of delete old labels (#95) Easier than PR suggestions. I noticed that some useful labels were being deleted either entirely or to be replaced with effectively the same thing. --------- Signed-off-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com> Co-authored-by: Quentin McGaw --- .github/labels.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/labels.yml b/.github/labels.yml index 7ee4e48addc..81c3480fa10 100644 --- a/.github/labels.yml +++ b/.github/labels.yml @@ -66,3 +66,7 @@ - name: "Closed: โšฐ๏ธ Inactive" color: "959a9c" description: "No answer was received for weeks" +- name: "Closed: ๐Ÿ™… Won't fix" + color: "959a9c" +- name: "Closed: ๐Ÿงบ Invalid" + color: "959a9c"