Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avahi-autoipd's iface-linux.c uses IFLA_RTA instead of IFA_RTA, crashes some platforms #42

Closed
fastcat opened this issue Jan 26, 2016 · 2 comments
Assignees
Labels
Milestone

Comments

@fastcat
Copy link

fastcat commented Jan 26, 2016

See this line of code: https://github.com/lathiat/avahi/blob/master/avahi-autoipd/iface-linux.c#L144

It's processing an ifaddrmsg, but using a macro for an ifinfomsg. The sizes are different, and this means that it's at least getting the data wrong, and on an ARM platform I'm using, this makes avahi-autoipd crash.

@lathiat
Copy link
Contributor

lathiat commented Feb 9, 2016

Thanks for picking this up and reporting it. You are correct the wrong function is used and I will commit a fix for this.

Could you tell me which specific arm platform / kernel version this was failing on?

@lathiat lathiat self-assigned this Feb 9, 2016
@lathiat lathiat added this to the v0.6.32 milestone Feb 9, 2016
@lathiat lathiat added the bug label Feb 9, 2016
@fastcat
Copy link
Author

fastcat commented Feb 10, 2016

This was found on a Broadcom ARM SoC, and on investigation was found to also affect (= cause a crash) a related Broadcom MIPS SoC, though at much lower frequency. The ARM SoC that crashed on this nearly 100% was running a 3.14.28-derived kernel.

murraycu pushed a commit to murraycu/avahi that referenced this issue Nov 16, 2016
…oses: avahi#42)

This crashes on some architectures (e.g. ARM) due to size differences
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants