Fix a crash when txt records has an empty value #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's a regression that came with 3b067e0 ("Add support for binary values in TXT records in service files"), we dropped the NULL check for the strlen call. Other txt record types already check for NULL value in the decode functions. Reported at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=882386
invidian
approved these changes
Jul 17, 2019
|
This segfault is older than two years now. Is anybody going to merge this PR? See also: #247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's a regression that came with 3b067e0 ("Add support for
binary values in TXT records in service files"), we dropped the NULL
check for the strlen call. Other txt record types already check for
NULL value in the decode functions.
Reported at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=882386