Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeBSD/IPv6 improvements #72

Merged
merged 4 commits into from
Jun 26, 2020
Merged

FreeBSD/IPv6 improvements #72

merged 4 commits into from
Jun 26, 2020

Conversation

valpackett
Copy link
Contributor

  • Rewrite __nss_bsdcompat_getaddrinfo to directly use gethostbyname_impl (now named _nss_mdns_gethostbyname_impl and non-static)
    • so now getaddrinfo with AF_UNSPEC would return both v4 and v6 results
    • e.g. on my v6-only avahi setup curl something.local with nss_mdns eventually returns the expected v6 address
  • Reenable nss_mdns6 and 4 on FreeBSD
    • with nss_mdns6, curl something.local instantly returns the expected v6 address for me

@valpackett
Implement __nss_bsdcompat_getaddrinfo directly on top of gethostbynam…
f56f130 
…e_impl

This allows returning both v6 and v4 addresses from getaddrinfo with AF_UNSPEC.
@valpackett
Remove "FreeBSD 5.x" comment
7a517c0 
This is ancient history, no need to 'XXX' that.
Current FreeBSD is version 13.
@valpackett
Build v4/v6 only libraries on FreeBSD
f75bff3 
They actually work as intended.
i.e. with a v6-only Avahi, mdns6 resolves instantly, while mdns is delayed for the v4 failure.
@valpackett
Extract function prototypes into nss.h
42720d9
agoode
agoode approved these changes Jun 26, 2020
View reviewed changes
Copy link
Collaborator

@agoode agoode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don't have a BSD setup so am trusting this works for you.

@agoode agoode merged commit 99c2f1c into avahi:master Jun 26, 2020
@Neustradamus
Copy link

@myfreeweb: Good job!
If you have finished, I hope a new build of nss-mdns soon :)

@wahjava
Copy link

wahjava commented Aug 1, 2020

@myfreeweb: Good job!
If you have finished, I hope a new build of nss-mdns soon :)

@Neustradamus assuming you meant in the port, then port is already updated a while ago

@Neustradamus
Copy link

Neustradamus commented Aug 1, 2020 •
edited
Loading

@wahjava: Yes but not in the official code :)

Last version is :
-> v0.14.1 : @agoode released this on 18 Mar 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agoode agoode agoode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@valpackett @Neustradamus @wahjava @agoode