New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-existent npm run script in maintaining.md #1434

Merged
merged 2 commits into from Jul 2, 2017

Conversation

Projects
None yet
3 participants
@roperzh
Contributor

roperzh commented Jun 30, 2017

馃憢 Hello!

What

This PR updates the documentation, removing the outdated coverage script and including the visual script.

Why

When cloning the repo and setting everything up, I found about the maintaining.md file and tried to npm run coverage which gave me an error, as somebody new to the project, this was confusing.

Updates the testing section of maintaining.md
Removes the outdated `coverage` script and documents the `visual`
script.
@novemberborn

This comment has been minimized.

Show comment
Hide comment
@novemberborn

novemberborn Jul 2, 2017

Member

Thanks!

I never even knew about npm run visual. @avajs/core do any of us run it? What's the value?

Member

novemberborn commented Jul 2, 2017

Thanks!

I never even knew about npm run visual. @avajs/core do any of us run it? What's the value?

@sindresorhus

This comment has been minimized.

Show comment
Hide comment
@sindresorhus

sindresorhus Jul 2, 2017

Member

I never even knew about npm run visual. @avajs/core do any of us run it? What's the value?

It's to manually ensure we didn't break the mini-reporter. It's not something contributors should care about.

Member

sindresorhus commented Jul 2, 2017

I never even knew about npm run visual. @avajs/core do any of us run it? What's the value?

It's to manually ensure we didn't break the mini-reporter. It's not something contributors should care about.

@sindresorhus sindresorhus changed the title from Updates the testing section of maintaining.md to Remove non-existent npm run script in maintaining.md Jul 2, 2017

@sindresorhus sindresorhus merged commit 0069a7e into avajs:master Jul 2, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@roperzh roperzh deleted the roperzh:update-maintaining-instructions branch Jul 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment