Recipe instructions for making jQuery available in browser #1543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't readily find instructions - maybe this helps!
novemberborn
requested changes
Oct 10, 2017
Member
novemberborn
left a comment
novemberborn
left a comment
There was a problem hiding this comment.
Thanks for your PR @ptim!
(not creating a topic branch as it's a docs PR stright from GH.. is that okay?)
Yes that's fine. The branch name really doesn't matter, it's in your fork anyway.
docs/recipes/browser-testing.md
Outdated
| browserEnv(['window', 'document', 'navigator']); | ||
| ``` | ||
|
|
||
| If your components use jQuery, you can make it available like so: |
Member
There was a problem hiding this comment.
I wonder if you could rephrase this a little. What's interesting is that you're adding additional global variables. jQuery could be an example of that:
You can expose more global variables by assigning them to the
globalobject. For instance jQuery is typically available through the$variable:
refer to jquery as an example of the more general case :)
Contributor
Author
|
Thanks for the feedback @novemberborn! Your phrasing gives much more context - thanks! |
sindresorhus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't readily find instructions for using jquery in the browser - hopefully this helps!
(not creating a topic branch as it's a docs PR stright from GH.. is that okay?)