process is forked with a single JSON argument

[jokeyrhyme]

This PR attempts to fix #318 .

Initially, the JSON string is converted back into process.argv values in lib/babel.js. I'm happy to go further and actually try to eliminate --fail-fast and --serial altogether in the child process, but I figured it was worth sharing what I had so far.

[sindresorhus]

I think we should do this.options = options in the Api constructor so we can just pass the whole options object here instead of explicitly specify each option.

[jokeyrhyme]

Okay, I've removed the direct dependency on "has-flag" (although istanbul still pulls it in), and the child process just uses the parsed JSON options instead of using hasFlag.

[sindresorhus]

See: #319 (comment)

[jokeyrhyme]

Okay, fork now has the signature: fork(file: String, opts?: Object) => Promise, which means I was able to undo the changes I had to make to tests previously.

[sindresorhus]

You can't just remove this. The options are used directly on this in the code and needs to be changed to use this.options.x.

[jokeyrhyme]

assign(this, options); has been replaced with objectAssign(this, options);

[jokeyrhyme]

I very thoroughly checked for "serial" and "failFast" property access before removing that assign(this, options); in api.js, but I've reverted as you suggested.

[sindresorhus]

@jokeyrhyme It's for example used here: https://github.com/jokeyrhyme/ava/blob/af4e70377a2b0143005c5fad52913821fcbdfbeb/api.js#L150

I would like to remove it though, as I feel it's pretty dirty to have arbitrary options mixed into this. @vdemedes You ok with that? Any other places it's used?

[jokeyrhyme]

It's weird that the tests were still passing when I dropped the assign(this, options) in api.js...

[sindresorhus]

This is outdated

[jokeyrhyme]

Should I completely drop the "time-require" module from package.json dependencies and the related --sorted stuff?

[sindresorhus]

No, meant that exports.opts._sorted is outdated with the latest PR changes.

[sindresorhus]

Very nice work @jokeyrhyme :) Can you squash it down to one commit?

[sindresorhus]

LGTM

[jokeyrhyme]

Done. :)

[jokeyrhyme]

@sindresorhus I think your "LGTM" came before my squash :)

[jamestalmage]

LGTM

[vadimdemedes]

@sindresorhus This (https://github.com/jokeyrhyme/ava/blob/af4e70377a2b0143005c5fad52913821fcbdfbeb/api.js#L150) is required for serial execution of forks (#282).

[jokeyrhyme]

@vdemedes in my squashed commit, I include moving that over to this.options.serial:
https://github.com/jokeyrhyme/ava/blob/eeeec706c285ed30889c6bf602f7797f31720270/api.js#L150

[vadimdemedes]

@jokeyrhyme Oh, my bad. Everything is fine then!

[vadimdemedes]

LGTM

[vadimdemedes]

@jokeyrhyme Ron, thank you for your valuable contribution to AVA, we really appreciate it! We'd love to see your new PRs soon!

[sindresorhus]

Thank you! :D

[jokeyrhyme]

🎉 😺