From c8ddcc38de1b1139578f459d058f6eb182056e3e Mon Sep 17 00:00:00 2001 From: Guillaume Martigny Date: Sun, 2 Jun 2019 10:18:49 +0200 Subject: [PATCH] Guard direct function calls in prefer-t-regex Fix #251 --- rules/prefer-t-regex.js | 2 +- test/prefer-t-regex.js | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/rules/prefer-t-regex.js b/rules/prefer-t-regex.js index bde6ab09..90ae8355 100644 --- a/rules/prefer-t-regex.js +++ b/rules/prefer-t-regex.js @@ -37,7 +37,7 @@ const create = context => { // First argument is a call expression const isFunctionCall = firstArg.type === 'CallExpression'; - if (!isFunctionCall) { + if (!isFunctionCall || !firstArg.callee.property) { return; } diff --git a/test/prefer-t-regex.js b/test/prefer-t-regex.js index 77a44de0..81febe84 100644 --- a/test/prefer-t-regex.js +++ b/test/prefer-t-regex.js @@ -23,6 +23,7 @@ ruleTester.run('prefer-t-regex', rule, { header + 'test(t => t.true(foo.bar()));', header + 'const a = /\\d+/;\ntest(t => t.truthy(a));', header + 'const a = "not a regexp";\ntest(t => t.true(a.test("foo")));', + header + 'test("main", t => t.true(foo()));', // Shouldn't be triggered since it's not a test file 'test(t => t.true(/\\d+/.test("foo")));' ],