-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plenty of rules (#2, #3, #5, #6, #7 and #8) #11
Conversation
Oh wow. This is amazing!
Yes, please. That would make it a lot easier to review and easier for you to update :)
AVA transpiles the test files with Babel, but not the code itself. So you can only use |
Gotcha!
Ok. Will split it up later today then. I hope there won't be too many conflicts as some of them touch the same portions (util, index and README), but I'll handle that if it comes up.
Glad you like it ;) |
Thanks for an amazing contribution, @jfmengels! |
Lol. So much Leonardo :p |
(couldn't resist) I'll close this one, I've opened a few others (#13, #14, #15), feel free to merge however you feel, I'll come around to handle conflicts). I'll create the rest of them when those get merged, as some use code that has been added in those PRs ( And by the way, thanks for making this great on-hands introduction to eslint rule writing :D |
I implemented the rules in issues #2, #3, #5, #6, #7 and #8.
I'm not that familiar with Ava (but pretty excited about it, so I felt pretty motivated to do this), so let me know if I've got anything wrong, if there's anything to fix, or if you prefer this being split into multiple PRs.
Also, if someone can tell me why the use of
const
makes the tests fail in Node 0.10/0.12 but is ok on master where I also seeconst
...