Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item lease for IP addresses is giving access to the items past the given end date #2081

Open
Karthikeya212 opened this issue Jun 21, 2017 · 5 comments

Comments

@Karthikeya212
Copy link

@Karthikeya212 Karthikeya212 commented Jun 21, 2017

Descriptive summary

Server: mco-staging.dlib.indiana.edu
Testing: Regression
Browser: Chrome(56.0.2924.87 (64-bit))
Operating System: Windows10
Issue: Item lease added for an ip-address with some date range is giving access to those items even after the date range is expired. This functionality is working fine for lease access to Avalon User and Avalon Group.

Expected behavior

Actual behavior

Steps to reproduce the behavior

  1. Open two windows with sodium system, and login with a Manager on one system and donot login in the second one.
  2. Edit an item, and add lease for that systems ip-address with date ranges that are already expired (i.e past dates).
  3. After adding the lease, publish the item.
  4. Search for the item in second window (without login), as the lease has expired this item shouldn't be shown, but it shows.
  5. The only way to restrict the access for the ip's is to remove the lease entry.

Related work

Link to related tickets or prior related work here.

@cjcolvar
Copy link
Member

@cjcolvar cjcolvar commented Jun 21, 2017

This also applies to external groups.

For some reason we are including the values from the lease into the solrized media object. The code that causes this problem is here:
https://github.com/avalonmediasystem/avalon/blob/develop/app/models/media_object.rb#L203-L204

Loading

@cjcolvar
Copy link
Member

@cjcolvar cjcolvar commented Jun 21, 2017

Looks like it was added here to have the values show up in the facet:
780edfd

This maybe has always been broken, I'll have to think about how to fix it.

Loading

@joncameron joncameron added this to the Backlog milestone Jun 23, 2017
@joncameron joncameron added this to the Backlog milestone Jun 23, 2017
@joncameron joncameron removed this from the Backlog milestone Sep 27, 2017
@joncameron joncameron added this to the Someday milestone Sep 27, 2017
@joncameron joncameron removed the ready label Sep 27, 2017
@joncameron
Copy link
Contributor

@joncameron joncameron commented May 17, 2019

This needs to be retested. Still valid?

Loading

@cjcolvar
Copy link
Member

@cjcolvar cjcolvar commented May 20, 2019

I think this is still valid and I hit it during regression testing. It is listed on our known issues page and I think it might be hard to solve.

Loading

@joncameron
Copy link
Contributor

@joncameron joncameron commented Jun 11, 2020

Boils down to an issue of how the solr query is written.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants