Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Is MasterFile moved in the middle of a batch ingest for new batch process? #2310

Closed
1 task
phuongdh opened this issue Sep 12, 2017 · 6 comments
Closed
1 task

Comments

@phuongdh
Copy link
Member

@phuongdh phuongdh commented Sep 12, 2017

Description

When master_file_strategy is move, sometimes during the middle of a long batch ingest, a master file would get moved, thus failing the batch.

I assume the same problem might happen when master_file_strategy is delete.

Done Looks Like

Batch ingest validation will fail if single file referenced in multiple rows.

Tasks

  • Manifest validation is updated to include error cases with a single file reference being present in multiple object rows
@joncameron joncameron changed the title MasterFile moved in the middle of a batch ingest Is MasterFile moved in the middle of a batch ingest for new batch process? Sep 21, 2017
@joncameron
Copy link
Contributor

@joncameron joncameron commented Sep 21, 2017

This isn't a case that would often be encountered in real life.

Another option: updating the manifest validation to throw an error on a single file being represented in multiple rows in the manifest.

@davidschober davidschober added this to the Backlog milestone Sep 27, 2017
@joncameron joncameron changed the title Is MasterFile moved in the middle of a batch ingest for new batch process? Testing: Is MasterFile moved in the middle of a batch ingest for new batch process? Sep 29, 2017
@davidschober
Copy link

@davidschober davidschober commented Nov 27, 2017

@carrickr @cjcolvar can you dig into this? Is this case still true with the rewrite? If not, feel free to abandon.

@cjcolvar
Copy link
Member

@cjcolvar cjcolvar commented Nov 27, 2017

@davidschober This scenario is still a possibility with the rewrite. Is it still important to provide validation feedback to the user when the same file is used multiple times in a batch manifest?

@bkeese
Copy link
Contributor

@bkeese bkeese commented Dec 7, 2017

@carrickr Have you dealt with this in your recent batch work?

@phuongdh phuongdh added 6.x and removed 6.3 labels Dec 8, 2017
@phuongdh
Copy link
Member Author

@phuongdh phuongdh commented Dec 8, 2017

Discussion at standup today: find a real use case or won't fix. This is an edge case that may require major rewrite. Brian: this could be a problem when rerunning batches. Carrick: doc says you have to reupload when rerunning so we won't have this problem. Tabling this for now so we can make the deadline.

@joncameron joncameron removed this from the Backlog milestone Jan 24, 2018
@joncameron joncameron added this to the Avalon 6.x Backlog milestone Jan 24, 2018
@davidschober davidschober removed this from the Avalon 6.x Backlog milestone May 8, 2019
@davidschober davidschober added this to the Backlog milestone May 8, 2019
@davidschober
Copy link

@davidschober davidschober commented Jun 25, 2019

this is a won't fix. We've never had this problem in the wild.

@joncameron joncameron removed this from the Backlog milestone Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants