Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to change quality using keyboard #2678

Closed
Karthikeya212 opened this issue Dec 22, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@Karthikeya212
Copy link
Collaborator

commented Dec 22, 2017

Descriptive summary

Server: https://spruce.dlib.indiana.edu
Testing: Regression Testing
Browser: Chrome 62.0.3202.94, EDGE 40
Operating System: Windows10
Issue: Unable to change quality using keyboard. User can navigate to the quality icon using TAB, once quality icon is reached it opens up the panel with high/med/low options, but the user cannot navigate/select any of those option in the panel. The next TAB click is an empty operation and user cannot see where the control is, and one more TAB takes control to the next available icon in the player. Moreover, the quality panel never closes after that unless user hovers over the quality icon.

Note: There is also an empty TAB operation before control moves to the quality icon, i.e. user cannot see where the control is before reaching quality icon.

@cjcolvar

This comment has been minimized.

Copy link
Member

commented Dec 22, 2017

I don't remember it being this bad when I tested earlier this week. I wonder if adding the closed captions toggle made things worse.

@Karthikeya212

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 22, 2017

I checked it again and I observed that after highlighting quality icon a TAB after that is actually going into the quality panel and using the down arrow we can select the relevant quality, but the user has no way to find this out as no visible sign that the quality panel is highlighted. However the panel closing issue still resides, i.e. the panel doesn't collapse automatically.

@cjcolvar

This comment has been minimized.

Copy link
Member

commented Dec 22, 2017

I was able to open the panel and up the arrow keys to change qualities by hitting enter when the quality icon was highlighted, but had the same issue of not being able to close the quality panel.

@joncameron joncameron added this to the Avalon 6.x Backlog milestone Jan 24, 2018

@joncameron joncameron added abandoned and removed bug 🐛 labels Jun 25, 2019

@joncameron joncameron closed this Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.