Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"title" Attribute in iframe Embed Code Is Not Encoded Properly #2930

Closed
joncameron opened this issue Apr 22, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@joncameron
Copy link
Contributor

commented Apr 22, 2018

Description

In the Embed tab of the Share section of a MediaObject view page, the iframe 'title' attribute contains the unencoded full text of the MediaObject's title. The title attribute could then contain single quotes and other characters that should be escaped according to the HTML spec.

While browsers can parse the title field and display the iframe, this breaks functionality in third party services that aren't expecting characters like unencoded apostophes in HTML attributes.

Relevant HTML Spec Page

https://html.spec.whatwg.org/multipage/syntax.html#unquoted

Example

https://media.dlib.indiana.edu/media_objects/9019s265v

Embed Code

        <iframe title="“Headless” metadata for library discovery: NYU’s Ichabod project" src="https://purl.dlib.indiana.edu/iudl/media/6537033g5k?urlappend=%2Fembed" width="600" height="337" frameborder="0" webkitallowfullscreen mozallowfullscreen allowfullscreen></iframe>

View of embed code

screen shot 2018-04-22 at 12 24 32 pm

Done Looks Like

Characters in the title attribute in iframe embed code are encoded as per the HTML spec.

@joncameron joncameron added the bug 🐛 label Apr 22, 2018

@joncameron joncameron added this to the Avalon 6.x Backlog milestone Apr 22, 2018

@joncameron joncameron added ready and removed Needs Refinement labels Jul 19, 2018

@bkeese bkeese self-assigned this Feb 1, 2019

@bkeese bkeese added In Review and removed ready labels Feb 1, 2019

@bkeese bkeese closed this Feb 4, 2019

@bkeese bkeese removed the In Review label Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.