Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Player Does Not Some Browsers #3335

Closed
joncameron opened this issue May 10, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@joncameron
Copy link
Contributor

commented May 10, 2019

Description

In Safari 12.1, MediaElement displays an audio player for audio items, but does not display the player for videos.

The same holds true for the latest Chrome for Android, tested on a Galaxy S9 in Browserstack.

And for Internet Explorer 11 on Windows 7 in Browserstack.

Done Looks Like

  • The video player appears on the view page for all browsers.

@joncameron joncameron added the bug label May 10, 2019

@davidschober davidschober added the ready label May 10, 2019

@joncameron joncameron changed the title Video Player Does Not Appear in Safari Video Player Does Not Some Browsers May 10, 2019

@cjcolvar cjcolvar self-assigned this May 10, 2019

@cjcolvar

This comment has been minimized.

Copy link
Member

commented May 10, 2019

#3337 allows the player to load and play on Safari on OS X and iOS as well as Chrome on Android and IE11.
But the captions button is not sticky on Safari on OSX (this might also be the case for iOS and Android). @davidschober @joncameron Is this an issue that needs to be fixed? It appears that this is currently broken in MCO.

@davidschober

This comment has been minimized.

Copy link

commented May 11, 2019

@cjcolvar

This comment has been minimized.

Copy link
Member

commented May 14, 2019

I already did a dive on this and it wasn't obvious how to resolve the issue which appears to be inside ME.js: player.tracks wasn't initialized as expected here (https://github.com/avalonmediasystem/avalon/blob/develop/app/assets/javascripts/media_player_wrapper/avalon_player_new.es6#L338).
I think it would probably take more time than it is worth it to fix this right now and the impact to the user is minimal. The worst is that the user needs to click the captions button to re-enable captions when a new section starts playing.

@mcwhitaker

This comment has been minimized.

Copy link

commented May 15, 2019

@joncameron @davidschober I would be fine with closing this, but I think we need to include it in our known issues page with the workaround documented.

@joncameron

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

I've updated the Known Issues page and will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.