New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change harcoded string in form theming #82

Closed
shakaran opened this Issue Dec 11, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@shakaran
Collaborator

shakaran commented Dec 11, 2015

On the file:

https://github.com/avanzu/AdminThemeBundle/blob/master/Resources/views/layout/form-theme.html.twig#L159

In the span, the title text should be a string with l18n support at least for the phrase "Dies ist ein Pflichtfeld":

<span class="required" title="Dies ist ein Pflichtfeld">*</span>
@chteuchteu

This comment has been minimized.

Show comment
Hide comment
@chteuchteu

chteuchteu Dec 11, 2015

Collaborator

That should get translated indeed... Could you open a pull request for this please?

Collaborator

chteuchteu commented Dec 11, 2015

That should get translated indeed... Could you open a pull request for this please?

@avanzu

This comment has been minimized.

Show comment
Hide comment
@avanzu

avanzu Dec 29, 2015

Owner

Dammit, you're totally right. Will be translatable in the 2.0 release.
In the meantime please override the form-theme.html.twig. Sorry for that. :(

Owner

avanzu commented Dec 29, 2015

Dammit, you're totally right. Will be translatable in the 2.0 release.
In the meantime please override the form-theme.html.twig. Sorry for that. :(

@shakaran

This comment has been minimized.

Show comment
Hide comment
@shakaran

shakaran Sep 15, 2017

Collaborator

This issue has been resolved as far I could check:

https://github.com/avanzu/AdminThemeBundle/blob/master/Resources/views/layout/form-theme.html.twig#L165

So closing my own issue, since I have the permissions enough! ;)

Collaborator

shakaran commented Sep 15, 2017

This issue has been resolved as far I could check:

https://github.com/avanzu/AdminThemeBundle/blob/master/Resources/views/layout/form-theme.html.twig#L165

So closing my own issue, since I have the permissions enough! ;)

@shakaran shakaran closed this Sep 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment