New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backbone dependence #140

Merged
merged 1 commit into from Sep 16, 2017

Conversation

Projects
None yet
5 participants
@Big-Shark
Contributor

Big-Shark commented Aug 29, 2016

No description provided.

@OskarStark

This comment has been minimized.

Show comment
Hide comment
@OskarStark

OskarStark Aug 29, 2016

Contributor

Can you please explain, WHY we should remove this?

Contributor

OskarStark commented Aug 29, 2016

Can you please explain, WHY we should remove this?

@Big-Shark

This comment has been minimized.

Show comment
Hide comment
@Big-Shark

Big-Shark Aug 29, 2016

Contributor

@OskarStark because AdminLTE doe's not use backbone by default, and we don't need add it by default

Contributor

Big-Shark commented Aug 29, 2016

@OskarStark because AdminLTE doe's not use backbone by default, and we don't need add it by default

@numerogeek

This comment has been minimized.

Show comment
Hide comment
@numerogeek

numerogeek Sep 13, 2016

That would be great to merge it as Backbone is the source of a bug here.

numerogeek commented Sep 13, 2016

That would be great to merge it as Backbone is the source of a bug here.

@chteuchteu

This comment has been minimized.

Show comment
Hide comment
@chteuchteu

chteuchteu Nov 15, 2016

Collaborator

@OskarStark, what do you think?

Collaborator

chteuchteu commented Nov 15, 2016

@OskarStark, what do you think?

@shakaran

This comment has been minimized.

Show comment
Hide comment
@shakaran

shakaran Sep 16, 2017

Collaborator

I am temptative merging this PR since I don't see backbone as real dependency. If someone see weird behaviour or bug, please reopen to revert

Collaborator

shakaran commented Sep 16, 2017

I am temptative merging this PR since I don't see backbone as real dependency. If someone see weird behaviour or bug, please reopen to revert

@shakaran shakaran merged commit 47ae070 into avanzu:master Sep 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment